From f459cae4c3520c4e44c486e10a92bb388f136399 Mon Sep 17 00:00:00 2001 From: Alex Zolotarev Date: Wed, 16 Mar 2016 14:11:08 +0300 Subject: [PATCH] Speed up strings::to_XXX conversion by removing unnecessary variable check. --- base/string_utils.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/base/string_utils.cpp b/base/string_utils.cpp index f03f91ab28..30a619dd13 100644 --- a/base/string_utils.cpp +++ b/base/string_utils.cpp @@ -45,7 +45,7 @@ bool to_int(char const * s, int & i, int base /*= 10*/) { char * stop; long const x = strtol(s, &stop, base); - if (stop && *stop == 0) + if (*stop == 0) { i = static_cast(x); ASSERT_EQUAL(static_cast(i), x, ()); @@ -62,7 +62,7 @@ bool to_uint64(char const * s, uint64_t & i) #else i = strtoull(s, &stop, 10); #endif - return stop && *stop == 0; + return *stop == 0; } bool to_int64(char const * s, int64_t & i) @@ -73,14 +73,14 @@ bool to_int64(char const * s, int64_t & i) #else i = strtoll(s, &stop, 10); #endif - return stop && *stop == 0; + return *stop == 0; } bool to_double(char const * s, double & d) { char * stop; d = strtod(s, &stop); - return stop && *stop == 0 && s != stop; + return *stop == 0 && s != stop; } UniString MakeLowerCase(UniString const & s)