From f551d401407a4ad881e19ee89cc4410b89fa56d0 Mon Sep 17 00:00:00 2001
From: Alexander Boriskov <a.boriskov@corp.mail.ru>
Date: Thu, 28 Nov 2019 14:25:24 +0300
Subject: [PATCH] [iOS] Added statistics for outdoor in Place Page

---
 .../Common/Statistics/StatisticsStrings.h     |  1 +
 iphone/Maps/UI/PlacePage/MWMPlacePageData.h   |  1 +
 iphone/Maps/UI/PlacePage/MWMPlacePageData.mm  | 19 +++++++++++++++++--
 .../PlacePageLayout/MWMPlacePageLayout.mm     |  8 ++++----
 4 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/iphone/Maps/Common/Statistics/StatisticsStrings.h b/iphone/Maps/Common/Statistics/StatisticsStrings.h
index 7db2501980..813944044d 100644
--- a/iphone/Maps/Common/Statistics/StatisticsStrings.h
+++ b/iphone/Maps/Common/Statistics/StatisticsStrings.h
@@ -324,6 +324,7 @@ static NSString * const kStatOverview = @"overview";
 static NSString * const kStatPedestrian = @"Pedestrian";
 static NSString * const kStatPhone = @"Phone";
 static NSString * const kStatPlacePage = @"placepage";
+static NSString * const kStatPlacePageOutdoor = @"placepage_outdoor";
 static NSString * const kStatPlacePageToponims = @"placepage_large_toponyms";
 static NSString * const kStatPlacePageSightSeeing = @"placepage_sightseeings";
 static NSString * const kStatPlacePageBannerBlank = @"Placepage_Banner_blank";
diff --git a/iphone/Maps/UI/PlacePage/MWMPlacePageData.h b/iphone/Maps/UI/PlacePage/MWMPlacePageData.h
index 818be6b7e7..a613618d4a 100644
--- a/iphone/Maps/UI/PlacePage/MWMPlacePageData.h
+++ b/iphone/Maps/UI/PlacePage/MWMPlacePageData.h
@@ -279,6 +279,7 @@ typedef void (^RefreshPromoCallbackBlock)(NSIndexSet *insertedSections);
 - (RoadWarningMarkType)roadType;
 - (BOOL)isPreviewPlus;
 - (BOOL)isPartnerAppInstalled;
+- (nonnull NSString*)statPlacement;
 
 + (UgcSummaryRatingType)ratingValueType:(place_page::rating::Impress)impress;
 
diff --git a/iphone/Maps/UI/PlacePage/MWMPlacePageData.mm b/iphone/Maps/UI/PlacePage/MWMPlacePageData.mm
index afb7cc42a9..6b98463860 100644
--- a/iphone/Maps/UI/PlacePage/MWMPlacePageData.mm
+++ b/iphone/Maps/UI/PlacePage/MWMPlacePageData.mm
@@ -846,7 +846,22 @@ NSString * const kUserDefaultsLatLonAsDMSKey = @"UserDefaultsLatLonAsDMS";
   return [UIApplication.sharedApplication canOpenURL:self.deepLink];
 }
 
-+ (UgcSummaryRatingType)ratingValueType:(rating::Impress)impress
+- (nonnull NSString*)statPlacement
+{
+  switch (m_info.GetSponsoredType())
+  {
+  case SponsoredType::PromoCatalogCity:
+    return kStatPlacePageToponims;
+  case SponsoredType::PromoCatalogSightseeings:
+    return kStatPlacePageSightSeeing;
+  case SponsoredType:: PromoCatalogOutdoor:
+    return kStatPlacePageOutdoor;
+  default:
+     return kStatUnknownError;
+  }
+}
+
++ (MWMRatingSummaryViewValueType)ratingValueType:(rating::Impress)impress
 {
   switch (impress)
   {
@@ -930,7 +945,7 @@ NSString * const kUserDefaultsLatLonAsDMSKey = @"UserDefaultsLatLonAsDMS";
         [Statistics logEvent:kStatPlacepageSponsoredShow
               withParameters:@{
                                kStatProvider: kStatMapsmeGuides,
-                               kStatPlacement: self.isLargeToponym ? kStatPlacePageToponims : kStatPlacePageSightSeeing,
+                               kStatPlacement: [self statPlacement],
                                kStatState: kStatOnline,
                                kStatCount: @(cityGallery.m_items.size())
                                }];
diff --git a/iphone/Maps/UI/PlacePage/PlacePageLayout/MWMPlacePageLayout.mm b/iphone/Maps/UI/PlacePage/PlacePageLayout/MWMPlacePageLayout.mm
index 2f7c14d144..2205458a8a 100644
--- a/iphone/Maps/UI/PlacePage/PlacePageLayout/MWMPlacePageLayout.mm
+++ b/iphone/Maps/UI/PlacePage/PlacePageLayout/MWMPlacePageLayout.mm
@@ -630,7 +630,7 @@ std::map<MetainfoRows, Class> const kMetaInfoCells = {
           [Statistics logEvent:kStatPlacepageSponsoredItemSelected
                 withParameters:@{
                                  kStatProvider: kStatMapsmeGuides,
-                                 kStatPlacement: kStatPlacePageSightSeeing,
+                                 kStatPlacement: [self.data statPlacement],
                                  kStatItem: @(0),
                                  kStatDestination: kStatCatalogue
                                  }];
@@ -643,7 +643,7 @@ std::map<MetainfoRows, Class> const kMetaInfoCells = {
           [Statistics logEvent:kStatPlacepageSponsoredItemSelected
                 withParameters:@{
                                  kStatProvider: kStatMapsmeGuides,
-                                 kStatPlacement: kStatPlacePageSightSeeing,
+                                 kStatPlacement: [self.data statPlacement],
                                  kStatItem: @(0),
                                  kStatDestination: kStatCatalogue
                                  }];
@@ -895,7 +895,7 @@ std::map<MetainfoRows, Class> const kMetaInfoCells = {
     [Statistics logEvent:kStatPlacepageSponsoredMoreSelected
           withParameters:@{
                            kStatProvider: kStatMapsmeGuides,
-                           kStatPlacement: self.data.isLargeToponym ? kStatPlacePageToponims : kStatPlacePageSightSeeing,
+                           kStatPlacement: [self.data statPlacement],
                            }];
   } else {
     promo::CityGallery::Item const &item = [self.data.promoGallery galleryItemAtIndex:indexPath.row];
@@ -908,7 +908,7 @@ std::map<MetainfoRows, Class> const kMetaInfoCells = {
     [Statistics logEvent:kStatPlacepageSponsoredItemSelected
           withParameters:@{
                            kStatProvider: kStatMapsmeGuides,
-                           kStatPlacement: self.data.isLargeToponym ? kStatPlacePageToponims : kStatPlacePageSightSeeing,
+                           kStatPlacement: [self.data statPlacement],
                            kStatItem: @(indexPath.item + 1),
                            kStatDestination: kStatCatalogue
                            }];