From fde771280f56f111d5b224a1f73291b6e381e026 Mon Sep 17 00:00:00 2001
From: velichkomarija <velichkomarija4@gmail.com>
Date: Mon, 19 Oct 2020 14:30:58 +0300
Subject: [PATCH] [android] Fixes after review.

---
 .../maps/bookmarks/BookmarkCollectionAdapter.java  |  6 +++---
 .../src/com/mapswithme/maps/bookmarks/Holders.java | 14 ++++++++------
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/android/src/com/mapswithme/maps/bookmarks/BookmarkCollectionAdapter.java b/android/src/com/mapswithme/maps/bookmarks/BookmarkCollectionAdapter.java
index 315bc7e3ed..7e98d71aaa 100644
--- a/android/src/com/mapswithme/maps/bookmarks/BookmarkCollectionAdapter.java
+++ b/android/src/com/mapswithme/maps/bookmarks/BookmarkCollectionAdapter.java
@@ -256,7 +256,7 @@ public class BookmarkCollectionAdapter extends RecyclerView.Adapter<RecyclerView
     return true;
   }
 
-  private void updateAllVisibility(@BookmarkManager.CompilationType int compilationType)
+  private void updateItemsByType(@BookmarkManager.CompilationType int compilationType)
   {
     if (compilationType == BookmarkManager.COLLECTION)
       mItemsCollection = BookmarkManager.INSTANCE.getChildrenCollections(mParentCategoryId);
@@ -270,7 +270,7 @@ public class BookmarkCollectionAdapter extends RecyclerView.Adapter<RecyclerView
     public void onHideAll(@BookmarkManager.CompilationType int compilationType)
     {
       BookmarkManager.INSTANCE.setChildCategoriesVisibility(mParentCategoryId, compilationType, false);
-      updateAllVisibility(compilationType);
+      updateItemsByType(compilationType);
       notifyDataSetChanged();
     }
 
@@ -278,7 +278,7 @@ public class BookmarkCollectionAdapter extends RecyclerView.Adapter<RecyclerView
     public void onShowAll(@BookmarkManager.CompilationType int compilationType)
     {
       BookmarkManager.INSTANCE.setChildCategoriesVisibility(mParentCategoryId, compilationType, true);
-      updateAllVisibility(compilationType);
+      updateItemsByType(compilationType);
       notifyDataSetChanged();
     }
   }
diff --git a/android/src/com/mapswithme/maps/bookmarks/Holders.java b/android/src/com/mapswithme/maps/bookmarks/Holders.java
index 4c42f38deb..696a9906c4 100644
--- a/android/src/com/mapswithme/maps/bookmarks/Holders.java
+++ b/android/src/com/mapswithme/maps/bookmarks/Holders.java
@@ -97,18 +97,21 @@ public class Holders
       mButton.setText(showAll
                       ? R.string.bookmarks_groups_show_all
                       : R.string.bookmarks_groups_hide_all);
-      mButton.setOnClickListener(new ToggleShowAllChildCategoryClickListener(action, showAll, compilationType));
+      mButton.setOnClickListener(new ToggleShowAllChildCategoryClickListener(
+          action, showAll, compilationType));
     }
 
     public interface HeaderAction
-  {
-    void onHideAll();
-    void onShowAll();
-  }
+    {
+      void onHideAll();
+
+      void onShowAll();
+    }
 
     public interface HeaderActionChildCategories
     {
       void onHideAll(@BookmarkManager.CompilationType int compilationType);
+
       void onShowAll(@BookmarkManager.CompilationType int compilationType);
     }
 
@@ -132,7 +135,6 @@ public class Holders
       {
         if (mShowAll)
           mAction.onShowAll(mCompilationType);
-
         else
           mAction.onHideAll(mCompilationType);
       }