organicmaps/harfbuzz
13
Fork 0
mirror of https://github.com/harfbuzz/harfbuzz.git synced 2025-04-05 05:25:05 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 9

Merge pull request #5194 from harfbuzz/test-directwite-variations
Some checks failed
arm / arm-none-eabi (push) Waiting to run
Details
configs-ci / build (push) Waiting to run
Details
fontations / build (push) Waiting to run
Details
linux-ci / build (push) Waiting to run
Details
macos-ci / build (push) Waiting to run
Details
msvc / msvc-2019-amd64 (push) Waiting to run
Details
msvc / msvc-2019-x86 (push) Waiting to run
Details
msys2 / MINGW32 (push) Waiting to run
Details
msys2 / MINGW64 (push) Waiting to run
Details
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1s
Details

Browse source 
[test/directwrite] Make the variations test actually test variations
This commit is contained in:
Behdad Esfahbod 2025-03-23 09:21:47 -06:00 • committed by GitHub
commit e4b633deb8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 47 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/hb-directwrite.cc
View file

@ -346,7 +346,7 @@ hb_directwrite_font_create (IDWriteFontFace *dw_face)
hb_face_destroy (face);
if (unlikely (hb_object_is_immutable (font)))
goto done;
return font;
/* Copy font variations */
if (SUCCEEDED (dw_face->QueryInterface (__uuidof (IDWriteFontFace5), (void**) &dw_face5)))
@ -378,8 +378,6 @@ hb_directwrite_font_create (IDWriteFontFace *dw_face)
dw_face->AddRef ();
font->data.directwrite.cmpexch (nullptr, (hb_directwrite_font_data_t *) dw_face);
done:
dw_face->Release ();
return font;
}

56
test/api/test-directwrite.cc
View file

@ -45,8 +45,7 @@ get_dwfontface (const char *font_path)
dw_font_face->AddRef ();
// Don't destroy face, as dw_font_face is backed by its data I think.
//hb_face_destroy (face);
hb_face_destroy (face);
return dw_font_face;
}
@ -76,21 +75,58 @@ test_native_directwrite_basic (void)
static void
test_native_directwrite_variations (void)
{
IDWriteFontFace *dwfontface;
IDWriteFontFace *dw_face;
IDWriteFontResource *dw_fontresource;
IDWriteFontFace5 *dw_face5, *dw_facevariations;
DWRITE_FONT_AXIS_VALUE dw_axisvalues[5];
hb_font_t *font;
const float *coords;
unsigned int length;
dwfontface = get_dwfontface ("fonts/AdobeVFPrototype.abc.otf");
g_assert_nonnull (dwfontface);
dw_face = get_dwfontface ("fonts/AdobeVFPrototype.abc.otf");
g_assert_nonnull (dw_face);
font = hb_directwrite_font_create (dwfontface);
hb_font_get_var_coords_normalized(font, &length);
// Currently we optimize out coords if none is non-zero
//g_assert_cmpuint (length, !=, 0);
dw_face->QueryInterface (__uuidof(IDWriteFontFace5), (void **)&dw_face5);
dw_face->Release ();
g_assert_nonnull (dw_face5);
// Check that wght axis originally set on the face is different from what we will set.
if (!dw_face5->HasVariations ())
{
g_test_skip ("Font has no variations. Possiply using Wine’s DWrite.dll");
return;
}
g_assert_cmpuint (dw_face5->GetFontAxisValueCount (), ==, 5);
dw_face5->GetFontAxisValues (dw_axisvalues, 5);
g_assert_cmpuint (dw_axisvalues[0].axisTag, ==, DWRITE_FONT_AXIS_TAG_WEIGHT);
g_assert_cmpfloat (dw_axisvalues[0].value, !=, 900.0f);
dw_face5->GetFontResource (&dw_fontresource);
dw_face5->Release();
g_assert_nonnull (dw_fontresource);
// Set wght axis to 900.0
dw_axisvalues[0].value = 900.0f;
dw_fontresource->CreateFontFace (DWRITE_FONT_SIMULATIONS_NONE, dw_axisvalues, 5, &dw_facevariations);
dw_fontresource->Release ();
g_assert_nonnull (dw_facevariations);
// Check that wght axis is now set to 900.0
g_assert_cmpuint (dw_facevariations->GetFontAxisValueCount (), ==, 5);
dw_facevariations->GetFontAxisValues (dw_axisvalues, 5);
g_assert_cmpuint (dw_axisvalues[0].axisTag, ==, DWRITE_FONT_AXIS_TAG_WEIGHT);
g_assert_cmpfloat (dw_axisvalues[0].value, ==, 900.0f);
font = hb_directwrite_font_create (dw_facevariations);
// Check that wght axis is also set to 900.0 on the hb_font_t
coords = hb_font_get_var_coords_design(font, &length);
g_assert_cmpuint (length, ==, 2);
g_assert_cmpfloat (coords[0], ==, 900.0f);
hb_font_destroy (font);
dwfontface->Release ();
dw_facevariations->Release ();
}