* Update `U_PF_IPHONE` to be 0 when building for macOS/macCatalyst.
* add macro definition for `attribute((visibility("hidden")))` for cases
where internal structs exist within exposed classes.
This cleans up inconsistent annotations between declared APIs in headers
vs defined implementations in cpp's. This better ensures the API's
referenceable in headers represent what is exposed and defined in the
ultimate binary library's symbol table.
This is the normal standard way in C, C++ as well as Java and there's no
longer any reason for ICU to be different. The various internal macros
providing custom boolean constants can all be deleted and code as well
as documentation can be updated to use lowercase true/false everywhere.
Removed logKnownIssue(ICU-21322) in plurults.cpp, ICU-21322 is done and the
entire if-statement was commented out.
Replaced CLDR-13700 with CLDR-13701 in several TODOs. 13700 is a duplicate of
13701.
Likewise for CLDR-14502 --> CLDR-14582.
PR#1999 from ICU 71 release missed some of the cases.
- Changed all public Javadoc to use the proper verbiage for identifying this code as
a tech preview.
- Changed all references to ULocale in the API to use Locale instead.
- Changed PersonNameFormatter and SimplePersonName so that they're constructed by way
of separate builder objects.
- Added an internal constructor for PersonNameFormatter just for the use of the unit tests,
and added some unit tests that take advantage of the new constructor to test the internals
more thoroughly.
- Renamed format() to formatToString(), to make room to add a format() method later that
returns a FormattedPersonName.
- Added logic to guess the locale of a name object when the name object doesn't supply
a locale.
- Moved the function that constructs a SimplePersonName from a single string containing
key-value pairs out of the API and into the unit tests.
- Various smaller changes in response to API- and code-review comments.
The makefile hardcodes paths to the build directory into icu-config. It doesn’t
need to do this and it unnecessarily breaks build reproducibility. This patch
makes a simple change to avoid this.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Adjust RuleBasedBreakIterator::BreakCache::populateNear() to retain the cache
the cache contents in additional cases where are still useful, resulting in
improved performance.
This change is related to PR #2039, which addressed the same problem. This one
retains the cache contents in more situations.
String.split(String) and Pattern.split(CharSequence) have surprising behaviour.
"a:🅱️".split(":") produces ["a", "b"], when one would expect ["a", "", "b", ""]
The recommended fix is to use the Guava Splitter, or setting an explicit limit:
String.split(String,int limit) and Pattern.split(CharSequence,int limit)
part of a high concurrency performance test setup. This will disperse commits
of performance test results into the data branch over a wider time frame and
drastically reduces the chance of data uploads failing after ten unsuccesful
commit attempts.
Test runs showed a huge drop in failed commits/retry, from a high of 113
without wait down to only 4 with the extra wait.
ICU-22075 Add comment explaining the rationale of the random
sleep period prior to test execution.
This helps to avoid missleading error message:
```
./source/configure: line 7981: syntax error near unexpected token 'newline'
./source/configure: line 7981: 'AX_CHECK_COMPILE_FLAG('
```
This patch also includes marking `=delete` on specific `normal` member functions, as opposed to compiler generated functions,
based on the description of such functions' surrounding comments.
