Commit graph

31824 commits

Author SHA1 Message Date
Hugo van der Merwe
77bb747002
Merge pull request #66 from icu-units/liststyles
For MixedUnits, use the correct ListFormatter styles.
2020-08-28 10:57:39 +02:00
Hugo van der Merwe
ce23846f70 Merge branch 'units-staging' into liststyles 2020-08-28 10:02:16 +02:00
Hugo van der Merwe
cc5a122021
Merge pull request #52 from icu-units/mixedunits
ICU-20941 Support Mixed Units in NumberFormatter when using usage()
2020-08-28 09:56:18 +02:00
Hugo van der Merwe
53e6a9ac69 Partially fix test order in .h file 2020-08-27 13:36:26 +02:00
Hugo van der Merwe
24a3c48892 Merge remote-tracking branch 'units/units-staging' into mixedunits 2020-08-27 13:18:40 +02:00
Hugo van der Merwe
16547f3298
Merge pull request #61 from icu-units/output_skeletons
Implement Precision handling in UsagePrefsHandler::processQuantity
2020-08-27 01:05:37 +02:00
Hugo van der Merwe
d2264474f4 Code review feedback incorporated. 2020-08-26 22:37:06 +02:00
Hugo van der Merwe
9906ef6958 One more comment: clarifying roundingMode use in NumberPropertyMapper::oldToNew 2020-08-26 13:12:38 +02:00
Hugo van der Merwe
e57d4a93f8 Reorder functions in number_usageprefs.cpp for consistency. 2020-08-26 12:59:34 +02:00
Hugo van der Merwe
12efd77d64 Cleanup: undo unnecessary changes. Shuffle code around for friendship. 2020-08-26 12:53:39 +02:00
Hugo van der Merwe
3cd5702f71 Drop Precision::fRoundingMode entirely. 2020-08-26 12:24:05 +02:00
Hugo van der Merwe
38e6e6e042 Fix RoundingMode. FIXMEs annotating fRoundingMode use. 2020-08-26 12:13:14 +02:00
Hugo van der Merwe
c2ae5b48ef Test parsing units to built-ins in MeasureFormatTest::TestParseToBuiltIn(). 2020-08-26 00:03:04 +02:00
Hugo van der Merwe
93efe1fe2b Add a cmemory.h TODO about icu-units#64. 2020-08-25 22:27:58 +02:00
Hugo van der Merwe
8bf746c882 Use assertFormatSingle where reasonable. 2020-08-25 22:23:00 +02:00
Hugo van der Merwe
a13b37c095 For MixedUnits, use the correct ListFormatter styles. 2020-08-25 18:41:37 +02:00
Hugo van der Merwe
41b3c0f89a Small cleanup of unit tests. Add a TODO for listformatter styles. 2020-08-25 16:19:55 +02:00
Hugo van der Merwe
a065a05c3d UserPrefsHandler, as friend of RoundingImpl, now replaces only fPrecision. 2020-08-24 23:24:00 +02:00
Hugo van der Merwe
7f6014f3cc Clean up some if(U_FAILURE(status)) checks. (Reviewed called code's status handling.) 2020-08-23 01:58:59 +02:00
Hugo van der Merwe
5915cfcd79 Drop the 'testCase' temporary in NumberFormatterApiTest::unitUsage() 2020-08-23 01:41:59 +02:00
Hugo van der Merwe
45ad74ae5f Code review feedback incorporated 2020-08-23 01:37:27 +02:00
Hugo van der Merwe
e5492b8184 Reordered test cases (no code changes) 2020-08-23 01:35:14 +02:00
Hugo van der Merwe
893851d9da Add a scientific & square-meter example to unitUsage(). 2020-08-22 19:38:14 +02:00
Hugo van der Merwe
d85dad9b19 Made sense of scientific notation. WAI, so fix unit testing examples. 2020-08-22 15:04:18 +02:00
Hugo van der Merwe
d9ce728f6c Add scientific and compact notation test cases. WIP: a bug in scientific formatting. 2020-08-22 10:00:38 +02:00
Hugo van der Merwe
c6ad33d35b Use assertFormatSingle: it is neat and to the point. 2020-08-22 09:46:31 +02:00
Hugo van der Merwe
6d320dbefe Move "default rounding" bool into private Precision member 2020-08-21 16:32:47 +02:00
Hugo van der Merwe
bd41bca957 Rename new group to 'number_usageprefs', now that the dust has settled. 2020-08-21 07:25:53 +02:00
Hugo van der Merwe
051b31713e Add Precision::bogus() factory to keep Precision() private. 2020-08-21 04:16:51 +02:00
Hugo van der Merwe
b4833af6c8 While we've moved code, might as well clang-format it. 2020-08-21 04:13:19 +02:00
Hugo van der Merwe
49dccd5087 number_symbolswrapper.cpp & co: thorough/consistent shuffling of code. 2020-08-21 03:56:16 +02:00
Hugo van der Merwe
f07f3f091d Move to number_symbolswrapper.cpp the SymbolsWrapper code from number_usageprefs.cpp 2020-08-21 03:54:50 +02:00
Hugo van der Merwe
5ce53b4c72 A relatively minimal but slightly haphazard code shuffle to fix dependencies.txt. 2020-08-21 03:34:25 +02:00
Hugo van der Merwe
95c0a17d19 Revert "dependencies.txt: merge numberformatter and number_skeletons groups. :-("
This reverts commit 0589bc95b4.
2020-08-18 20:44:02 +02:00
Hugo van der Merwe
0589bc95b4 dependencies.txt: merge numberformatter and number_skeletons groups. :-( 2020-08-18 19:58:05 +02:00
Hugo van der Merwe
f0ec488046 Move scientific unit tests to a different branch, rounder WAI. 2020-08-18 18:52:40 +02:00
Hugo van der Merwe
e254b05cec Implement overrideable rounding behaviour 2020-08-18 17:40:43 +02:00
Hugo van der Merwe
461d5ea950 Back-propagate a U_ASSERT(U_SUCCESS(status)), and also add to parseStem. 2020-08-18 15:29:42 +02:00
Hugo van der Merwe
3f41767790 Officially move the initNumberSkeletons call into parseSkeleton. 2020-08-18 14:57:48 +02:00
Hugo van der Merwe
9c99964ddf Implement Precision handling in UsagePrefsHandler::processQuantity 2020-08-18 13:21:53 +02:00
Hugo van der Merwe
bb89950dea Remove unitMixedMeasure test from this PR. 2020-08-17 23:27:39 +02:00
Hugo van der Merwe
f247b5d261 Improved testing, some other code-review improvements. 2020-08-17 23:27:18 +02:00
Hugo van der Merwe
e343e5c858 Merge remote-tracking branch 'units/units-staging' into mixedunits 2020-08-17 21:20:05 +02:00
Hugo van der Merwe
0673716b4e Revert "ICU-21059 Add missing (temperature-)'generic' simple unit." [alt fix]
This reverts commit 220095c162.

Instead, the unit test failure is fixed by not calling getComplexity()
on an unparseable unit yet. (Leaving that for a different PR.)
2020-08-16 22:12:51 +02:00
Hugo van der Merwe
25ed27786c Drop CopyableMaybeStackArray from cmemory.h 2020-08-16 02:22:04 +02:00
Hugo van der Merwe
d2318cfe84 Merge remote-tracking branch 'upstream/master' into units-staging 2020-08-16 00:14:17 +02:00
Markus Scherer
9279e49d2f ICU-21030 validate ACE label edge cases 2020-08-14 14:32:47 -07:00
Markus Scherer
e19d12997b ICU-21212 full range check for Punycode digits 2020-08-14 11:37:40 -07:00
Paul Smith
e3f2c0dd70 ICU-21217 Windows: Fix link command for extra/scrptrun 2020-08-14 00:43:24 -07:00
Shane F. Carr
2ea56b531a ICU-21182 Adding UNumberRangeFormatter (C API).
See #1193
2020-08-12 21:33:38 -05:00