organicmaps/kothic
13
Fork 0
Code Issues Pull requests 2 Projects Releases Wiki Activity Actions

Require protobuf 3.21+ #30

Merged
root merged 1 commit from pastk-protobuf3.21 into master 2024-12-01 22:02:50 +00:00
Conversation 2 Commits 1 Files changed 1 +3 -1
pastk commented 2024-11-29 18:56:01 +00:00
Member
Copy link

There is no point to require 4.23 as the core uses 3.3.0 still.

E.g. Ubuntu 24.04 LTS ships with python3-protobuf 3.21.12 and it works fine (probably works with lower versions too).

4.23 requirement was added when only the kothic part (https://github.com/organicmaps/kothic/pull/15) of the https://github.com/organicmaps/organicmaps/pull/5557 was merged.

@AndrewShkrob

There is no point to require 4.23 as the core uses 3.3.0 still. E.g. Ubuntu 24.04 LTS ships with python3-protobuf 3.21.12 and it works fine (probably works with lower versions too). 4.23 requirement was added when only the kothic part (https://github.com/organicmaps/kothic/pull/15) of the https://github.com/organicmaps/organicmaps/pull/5557 was merged. @AndrewShkrob
vng (Migrated from github.com) reviewed 2024-11-29 18:56:01 +00:00
AndrewShkrob approved these changes 2024-11-30 21:15:40 +00:00
biodranik (Migrated from github.com) approved these changes 2024-12-01 20:14:19 +00:00
biodranik (Migrated from github.com) left a comment
Copy link

@pastk can you please add your comment from PR into the requirements.txt?

@pastk can you please add your comment from PR into the requirements.txt?
pastk commented 2024-12-01 21:14:13 +00:00
Author
Member
Copy link

@pastk can you please add your comment from PR into the requirements.txt?

Done!

> @pastk can you please add your comment from PR into the requirements.txt? Done!
biodranik commented 2024-12-01 21:39:23 +00:00 (Migrated from github.com)
Copy link

@pastk you have rights to merge yourself ;-)

@pastk you have rights to merge yourself ;-)
Sign in to join this conversation.
Reviewers
No reviewers
vng
AndrewShkrob
biodranik
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/kothic#30
No description provided.
Delete branch "pastk-protobuf3.21"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?