organicmaps/organicmaps-tmp

Archived

Fork 1

[qt] The desktop app crashes when launched in russian locale #1638

New issue

Closed

opened 2021-11-29 19:34:11 +00:00 by pastk · 13 comments

pastk commented

2021-11-29 19:34:11 +00:00

Member

organicmaps$ LC_ALL=ru_RU.utf8 ../omim-build-debug/OMaps -data_path ./data

TID(3) ASSERT FAILED
drape/texture_manager.cpp:104
CHECK(strings::to_double(token, d)) 
OMaps: /home/pastk/dev/organicmaps/drape/texture_manager.cpp:104: dp::{anonymous}::ParsePatternsList(const string&, ToDo)::<lambda(const string&)>::<lambda(const string&)> [with ToDo = dp::TextureManager::Init(ref_ptr<dp::GraphicsContext>, const dp::TextureManager::Params&)::<lambda(const buffer_vector<double, 8>&)>; std::__cxx11::string = std::__cxx11::basic_string<char>]: Assertion `false' failed.

It works fine with en locale though.
Looks like parsing of doubles can't handle the comma "," decimal separator used in ru locale.

``` organicmaps$ LC_ALL=ru_RU.utf8 ../omim-build-debug/OMaps -data_path ./data TID(3) ASSERT FAILED drape/texture_manager.cpp:104 CHECK(strings::to_double(token, d)) OMaps: /home/pastk/dev/organicmaps/drape/texture_manager.cpp:104: dp::{anonymous}::ParsePatternsList(const string&, ToDo)::<lambda(const string&)>::<lambda(const string&)> [with ToDo = dp::TextureManager::Init(ref_ptr<dp::GraphicsContext>, const dp::TextureManager::Params&)::<lambda(const buffer_vector<double, 8>&)>; std::__cxx11::string = std::__cxx11::basic_string<char>]: Assertion `false' failed. ``` It works fine with `en` locale though. Looks like parsing of doubles can't handle the comma "," decimal separator used in `ru` locale.

pastk commented

2021-11-29 19:34:26 +00:00

Author

Member

@biodranik

biodranik commented

2021-12-05 15:49:06 +00:00

(Migrated from github.com)

Please make sure that you don't have LC_ALL set already in your shell, it overrides everything. Use LANG=ru_RU.utf8 ../omim-build-debug/OMaps to override the locale.

Please make sure that you don't have LC_ALL set already in your shell, it overrides everything. Use `LANG=ru_RU.utf8 ../omim-build-debug/OMaps` to override the locale.

pastk commented

2021-12-18 16:06:46 +00:00

Author

Member

It starts now, thanks!

Though there is absolutely no change in the app, e.g. the app itself is not translated and e.g. POI names are still shown both in en (first) and ru (second).

Moreover there is no change in the search behavior, e.g. the reason I wanted to start it in ru locale was to test #1621 - when "пит" is entered into the search box it should show a "питьевая вода" search suggestion - but it doesn't (works for en "drink"->"drinking water"). Also when entered manually "питьевая вода" doesn't search for drinking water types.

So I guess the desktop app doesn't support any localization ATM.

It starts now, thanks! Though there is absolutely no change in the app, e.g. the app itself is not translated and e.g. POI names are still shown both in en (first) and ru (second). Moreover there is no change in the search behavior, e.g. the reason I wanted to start it in ru locale was to test #1621 - when "пит" is entered into the search box it should show a "питьевая вода" search suggestion - but it doesn't (works for en "drink"->"drinking water"). Also when entered manually "питьевая вода" doesn't search for drinking water types. So I guess the desktop app doesn't support any localization ATM.

biodranik commented

2021-12-18 17:40:46 +00:00

(Migrated from github.com)

On Mac, the map language changes when LANG variable is changed (after unset LC_ALL). It should work also on Linux.

What is displayed in logs? Does it show ru?

On Mac, the map language changes when LANG variable is changed (after unset LC_ALL). It should work also on Linux. What is displayed in logs? Does it show ru?

pastk commented

2021-12-19 12:45:12 +00:00

Author

Member

On Mac, the map language changes when LANG variable is changed (after unset LC_ALL). It should work also on Linux.

What is displayed in logs? Does it show ru?

I nailed it finally!
The issue was I had a LANGUAGE=en_US env var set. Apparently it has a precedence over LANG.

Now when I start LANGUAGE=ru_RU ../omim-build-release/OMaps -data_path ./data the map is shown in Russian (and it appears in the logs too). The search works as expected now, except selecting a search suggestion doesn't do anything (its not copied in the search input field).

> On Mac, the map language changes when LANG variable is changed (after unset LC_ALL). It should work also on Linux. > > What is displayed in logs? Does it show ru? I nailed it finally! The issue was I had a `LANGUAGE=en_US` env var set. Apparently it has a precedence over `LANG`. Now when I start `LANGUAGE=ru_RU ../omim-build-release/OMaps -data_path ./data` the map is shown in Russian (and it appears in the logs too). The search works as expected now, except selecting a search suggestion doesn't do anything (its not copied in the search input field).

biodranik commented

2021-12-19 21:54:38 +00:00

(Migrated from github.com)

except selecting a search suggestion doesn't do anything (its not copied in the search input field).

Did it work before overriding? Should be easy to fix IMO.

> except selecting a search suggestion doesn't do anything (its not copied in the search input field). Did it work before overriding? Should be easy to fix IMO.

biodranik commented

2021-12-19 21:55:11 +00:00

(Migrated from github.com)

It would be great to document locale vars for developers.

pastk commented

2021-12-19 22:09:07 +00:00

Author

Member

except selecting a search suggestion doesn't do anything (its not copied in the search input field).

Did it work before overriding? Should be easy to fix IMO.

Nope, it did not work in en locale either.

> > except selecting a search suggestion doesn't do anything (its not copied in the search input field). > > Did it work before overriding? Should be easy to fix IMO. Nope, it did not work in en locale either.

pastk commented

2021-12-19 22:14:54 +00:00

Author

Member

Now that's really weird - the app shows the russian map always even if I start it with LANGUAGE=en_US (and in the log there is LOG TID(1) INFO 0.131926 search/processor.cpp:232 SetPreferredLocale() New preferred locale: en)
When I click "edit place" it shows both ru and en names as containing russian, though before it was russian and english accordingly.
Is it possible the app had overwritten the map data when it was in ru locale? Or maybe it stores the locale is some config?

Now that's really weird - the app shows the russian map always even if I start it with `LANGUAGE=en_US` (and in the log there is `LOG TID(1) INFO 0.131926 search/processor.cpp:232 SetPreferredLocale() New preferred locale: en`) When I click "edit place" it shows both ru and en names as containing russian, though before it was russian and english accordingly. Is it possible the app had overwritten the map data when it was in ru locale? Or maybe it stores the locale is some config?

biodranik commented

2021-12-20 11:29:34 +00:00

(Migrated from github.com)

No, locale is not stored. Please double check all env vars, and try to use LANG

And let's close this issue after updating documentation.

No, locale is not stored. Please double check all env vars, and try to use LANG And let's close this issue after updating documentation.

biodranik commented

2021-12-20 12:21:18 +00:00

(Migrated from github.com)

Clicking search results works on Mac, they are properly inserted into the search field.

pastk commented

2021-12-22 13:26:30 +00:00

Author

Member

No, locale is not stored. Please double check all env vars, and try to use LANG

LANG works only if I unset manually LANGUAGE first, so LANGUAGE seems to have a higher priority. Hence I suggest to add LANGUAGE to the docs.

And let's close this issue after updating documentation.

> No, locale is not stored. Please double check all env vars, and try to use LANG LANG works only if I unset manually LANGUAGE first, so LANGUAGE seems to have a higher priority. Hence I suggest to add LANGUAGE to the docs. > And let's close this issue after updating documentation.

pastk commented

2021-12-24 21:40:05 +00:00

Author

Member

The issue could be closed now.

This repo is archived. You cannot comment on issues.