organicmaps/organicmaps-tmp

Archived

Fork 1

[localisation] Initiate addition of Marathi language for maps #2247

Merged

sanketgarade merged 3 commits from marathi-maps into master

2022-04-27 13:30:04 +00:00

sanketgarade commented

2022-03-12 08:34:25 +00:00

(Migrated from github.com)

Hi,

I am submitting the changes which were discussed in #662 .

Marathi language is added in the supported language list.
Font for the Devanagari script is added and mapped to the Unicode block.

Note - I haven't compiled and tested the changes.
Let me know in case I need to do anything else.

Thanks!

Hi, I am submitting the changes which were discussed in #662 . - Marathi language is added in the supported language list. - Font for the Devanagari script is added and mapped to the Unicode block. Note - I haven't compiled and tested the changes. Let me know in case I need to do anything else. Thanks!

biodranik commented

2022-04-04 16:38:37 +00:00

(Migrated from github.com)

At the moment in OSM there are only about 10K names in Marathi: https://taginfo.openstreetmap.org/search?q=name%3Amr

sanketgarade commented

2022-04-05 10:21:24 +00:00

(Migrated from github.com)

Yes. More are getting added on a regular basis so it will increase gradually.

biodranik commented

2022-04-05 12:59:31 +00:00

(Migrated from github.com)

Do you also plan to add the app's localizations as well (see #2335)? Or just draw Marathi texts on the map?

sanketgarade commented

2022-04-05 13:48:53 +00:00

(Migrated from github.com)

Sure I can do the app's localisation as well. Such that app menu, buttons etc. start appearing in Marathi right?

biodranik commented

2022-04-05 16:42:41 +00:00

(Migrated from github.com)

Sure I can do the app's localisation as well. Such that app menu, buttons etc. start appearing in Marathi right?

Right. But you need to make sure that Marathi is supported by iOS and Android first.

> Sure I can do the app's localisation as well. Such that app menu, buttons etc. start appearing in Marathi right? Right. But you need to make sure that Marathi is supported by iOS and Android first.

sanketgarade commented

2022-04-05 21:44:33 +00:00

(Migrated from github.com)

Yes it is supported.

Android reference is here.

On iPhone it is supported under "preferred languages". If set there at the top of the order then apps that support Marathi start displaying their content in Marathi language. Below is Signal app screenshot from my iPhone.

Yes it is supported. Android reference is [here](https://support.google.com/googleplay/android-developer/answer/9844778#zippy=%2Cview-list-of-available-languages). ![image](https://user-images.githubusercontent.com/74632379/161854992-eefb20a8-cef3-4775-bce4-dca6e3ddd742.png) On iPhone it is supported under "preferred languages". If set there at the top of the order then apps that support Marathi start displaying their content in Marathi language. Below is Signal app screenshot from my iPhone. ![image](https://user-images.githubusercontent.com/74632379/161854728-bb47d173-271f-48b4-afbe-9af5cef9bb35.jpeg)

sanketgarade commented

2022-04-27 13:11:15 +00:00

(Migrated from github.com)

Hey 👋🏼
How do you plan to take this forward?

Do you want me to do the app localisation changes (similar to #2335) in this PR itself?

Or can you merge this PR and I'll submit the app localisation changes in a separate PR?

Hey 👋🏼 How do you plan to take this forward? Do you want me to do the app localisation changes (similar to #2335) in this PR itself? Or can you merge this PR and I'll submit the app localisation changes in a separate PR?

biodranik (Migrated from github.com) approved these changes 2022-04-27 13:29:57 +00:00

biodranik (Migrated from github.com) left a comment

Let's merge it. You can proceed with other localizations :)

biodranik commented

2022-04-27 13:30:37 +00:00

(Migrated from github.com)

@vng do we need to reference the font somewhere else in Android?

This repo is archived. You cannot comment on pull requests.

No reviewers

biodranik