organicmaps/organicmaps-tmp
Archived
13
Fork 1
Code Issues 2.7k Pull requests 182 Projects Releases 65 Wiki Activity Actions

Add several healthcare POI's #4053

Merged
Mr-Mime merged 5 commits from master into master 2023-02-15 18:43:10 +00:00
Conversation 3 Commits 5 Files changed 132 +10112 -6981
Mr-Mime commented 2022-12-09 12:41:39 +00:00 (Migrated from github.com)
Copy link

This commit adds the following healthcare POI's including icons:

  • alternative
  • audiologist
  • blood_donation
  • optometrist
  • podiatrist
  • psychotherapist
  • sample_collection
  • speech_therapist

This is related to organicmaps/organicmaps#1050

Right now I haven't tested this on a device, as my generator_tool does not work as I wish.
However I wanted to create the PR so that it can be reviewed.

Where I am not sure / need help:

  • which icons should I add to the vehicle styles?
  • in categories.txt there is the option with the number in the begining, saying when the search should show results, hoiw to determine when to use a number?
This commit adds the following healthcare POI's including icons: * alternative * audiologist * blood_donation * optometrist * podiatrist * psychotherapist * sample_collection * speech_therapist This is related to https://git.omaps.dev/organicmaps/organicmaps/issues/1050 Right now I haven't tested this on a device, as my generator_tool does not work as I wish. However I wanted to create the PR so that it can be reviewed. Where I am not sure / need help: * which icons should I add to the vehicle styles? * in `categories.txt` there is the option with the number in the begining, saying when the search should show results, hoiw to determine when to use a number?
Mr-Mime commented 2022-12-09 12:46:45 +00:00 (Migrated from github.com)
Copy link

Forgot to mention, that it also changes the icon for laboratory to use the same as sample_collection instead of the red cross from the hospital

Forgot to mention, that it also changes the icon for `laboratory` to use the same as `sample_collection` instead of the red cross from the `hospital`
matheusgomesms (Migrated from github.com) requested changes 2022-12-09 13:49:37 +00:00
matheusgomesms (Migrated from github.com) left a comment

Fixed PT and PT-BR strings. Congrats on your work!

Fixed PT and PT-BR strings. Congrats on your work!
data/strings/types_strings.txt
matheusgomesms (Migrated from github.com) commented 2022-12-09 13:42:47 +00:00

pt-BR = Fonoaudiólogo

pt-BR = Fonoaudiólogo
matheusgomesms (Migrated from github.com) commented 2022-12-09 13:47:03 +00:00

pt = Podologista
pt-BR = Podólogo

pt = Podologista pt-BR = Podólogo
matheusgomesms (Migrated from github.com) commented 2022-12-09 13:48:46 +00:00

pt = Audiologista
pt-BR = Fonoaudiólogo

pt = Audiologista pt-BR = Fonoaudiólogo
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 13:55:14 +00:00
data/strings/types_strings.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 13:55:14 +00:00

Thanks!
Done in 5d32dd98de7b8591e4719e2842b617d50026572f

Thanks! Done in 5d32dd98de7b8591e4719e2842b617d50026572f
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 13:55:24 +00:00
data/strings/types_strings.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 13:55:23 +00:00

Thanks!
Done in 5d32dd98de7b8591e4719e2842b617d50026572f

Thanks! Done in 5d32dd98de7b8591e4719e2842b617d50026572f
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 13:55:34 +00:00
data/strings/types_strings.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 13:55:34 +00:00

Thanks!
Done in 5d32dd98de7b8591e4719e2842b617d50026572f

Thanks! Done in 5d32dd98de7b8591e4719e2842b617d50026572f
strump reviewed 2022-12-09 13:57:11 +00:00
data/categories.txt
strump commented 2022-12-09 13:52:25 +00:00
Member

Please replace uk:Лікар-оптометрист with shorter uk:Оптометрист

Please replace `uk:Лікар-оптометрист` with shorter `uk:Оптометрист`
strump commented 2022-12-09 13:53:18 +00:00
Member

Please replace uk:Лікар-ортопед with shorter uk:Ортопед

Please replace `uk:Лікар-ортопед` with shorter `uk:Ортопед`
data/strings/types_strings.txt
strump commented 2022-12-09 13:55:55 +00:00
Member

Please replace uk:Лікар-оптометрист with shorter uk:Оптометрист

Please replace `uk:Лікар-оптометрист` with shorter `uk:Оптометрист`
strump commented 2022-12-09 13:56:09 +00:00
Member

Please replace uk:Лікар-ортопед with shorter uk:Ортопед

Please replace `uk:Лікар-ортопед` with shorter `uk:Ортопед`
matheusgomesms (Migrated from github.com) approved these changes 2022-12-09 14:00:08 +00:00
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 14:04:22 +00:00
data/categories.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 14:04:22 +00:00

Thanks for the help!
Fixed in 5ef28758fcfa61e0467e87e92aa4fdac92cc967e

Thanks for the help! Fixed in 5ef28758fcfa61e0467e87e92aa4fdac92cc967e
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 14:04:26 +00:00
data/categories.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 14:04:25 +00:00

Thanks for the help!
Fixed in 5ef28758fcfa61e0467e87e92aa4fdac92cc967e

Thanks for the help! Fixed in 5ef28758fcfa61e0467e87e92aa4fdac92cc967e
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 14:04:30 +00:00
data/strings/types_strings.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 14:04:29 +00:00

Thanks for the help!
Fixed in 5ef28758fcfa61e0467e87e92aa4fdac92cc967e

Thanks for the help! Fixed in 5ef28758fcfa61e0467e87e92aa4fdac92cc967e
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 14:04:33 +00:00
data/strings/types_strings.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 14:04:32 +00:00

Thanks for the help!
Fixed in 5ef28758fcfa61e0467e87e92aa4fdac92cc967e

Thanks for the help! Fixed in 5ef28758fcfa61e0467e87e92aa4fdac92cc967e
Kazing (Migrated from github.com) requested changes 2022-12-09 14:53:57 +00:00
Kazing (Migrated from github.com) left a comment

here are my comments for fr
Thanks!

here are my comments for `fr` Thanks!
data/categories.txt
Kazing (Migrated from github.com) commented 2022-12-09 14:50:45 +00:00

fr:Prélèvements biologiques

fr:Prélèvements biologiques
data/strings/types_strings.txt
Kazing (Migrated from github.com) commented 2022-12-09 14:48:42 +00:00

fr = Prélèvements biologiques

fr = Prélèvements biologiques
biodranik (Migrated from github.com) requested changes 2022-12-09 15:41:42 +00:00
data/categories.txt
biodranik (Migrated from github.com) commented 2022-12-09 15:32:52 +00:00

Альтэрнатыўная медыцына

Альтэрнатыўная медыцына
biodranik (Migrated from github.com) commented 2022-12-09 15:33:14 +00:00

Альтернативна медицина

Альтернативна медицина
biodranik (Migrated from github.com) commented 2022-12-09 15:34:08 +00:00

Артапед

Артапед
biodranik (Migrated from github.com) commented 2022-12-09 15:34:28 +00:00

Ортопед

Ортопед
biodranik (Migrated from github.com) commented 2022-12-09 15:40:15 +00:00

Збір аналізів

Збір аналізів
biodranik (Migrated from github.com) commented 2022-12-09 15:40:26 +00:00

Збор аналізаў

Збор аналізаў
biodranik (Migrated from github.com) commented 2022-12-09 15:40:42 +00:00

Сдача анализов

Сдача анализов
data/categories.txt
@ -4811,0 +4995,4 @@
sw:Matibabu ya miguu|Daktari wa miguu
th:แก้โรคเท้า|แพทย์โรคเท้า
tr:Podiatri|Podiatrist
uk:Подологія
biodranik (Migrated from github.com) commented 2022-12-09 15:39:53 +00:00

Google incorrectly translated "Sample" for some languages. It's hard to translate in many cases.

Google incorrectly translated "Sample" for some languages. It's hard to translate in many cases.
data/editor.config
@ -440,2 +440,4 @@
<include group="poi_internet" />
</type>
<type id="healthcare-alternative" group="health">
<include group="poi_internet" />
biodranik (Migrated from github.com) commented 2022-12-09 15:41:34 +00:00

It would make sense to create a group poi_internet and use it here too. A private doctor can have wifi for his patients.

It would make sense to create a group poi_internet and use it here too. A private doctor can have wifi for his patients.
j13m126 (Migrated from github.com) reviewed 2022-12-09 15:59:51 +00:00
data/strings/types_strings.txt
j13m126 (Migrated from github.com) commented 2022-12-09 15:59:50 +00:00

I would prefer being consistent here using Psychotherapeut, Psychotherapie or Psychotherapiepraxis.

I would prefer being consistent here using Psychotherapeut, Psychotherapie or Psychotherapiepraxis.
j13m126 (Migrated from github.com) reviewed 2022-12-09 16:01:28 +00:00
data/strings/types_strings.txt
j13m126 (Migrated from github.com) commented 2022-12-09 16:01:28 +00:00

same here, Logopäde, Logopädie or Logopädiepraxis

same here, Logopäde, Logopädie or Logopädiepraxis
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 23:50:28 +00:00
data/categories.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 23:50:28 +00:00

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 23:50:38 +00:00
data/categories.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 23:50:37 +00:00

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 23:50:48 +00:00
data/categories.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 23:50:48 +00:00

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 23:50:54 +00:00
data/categories.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 23:50:54 +00:00

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 23:50:59 +00:00
data/categories.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 23:50:59 +00:00

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 23:51:04 +00:00
data/categories.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 23:51:04 +00:00

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 23:51:10 +00:00
data/categories.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 23:51:10 +00:00

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 23:51:18 +00:00
data/categories.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 23:51:18 +00:00

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 23:51:21 +00:00
data/strings/types_strings.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 23:51:20 +00:00

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc

Thanks updated in fc7f0d210d023bef89b935a634311e2fc29019dc
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 23:54:05 +00:00
data/categories.txt
@ -4811,0 +4995,4 @@
sw:Matibabu ya miguu|Daktari wa miguu
th:แก้โรคเท้า|แพทย์โรคเท้า
tr:Podiatri|Podiatrist
uk:Подологія
Mr-Mime (Migrated from github.com) commented 2022-12-09 23:54:05 +00:00

Yes it is.
I also manually adjusted the German translation.
Unfortunately it can only be mastered with help of native speakers.

I'll try to check the translations manually, sometimes deepl/goolge give alternatives.

IMO the shorter the better, in mo

Yes it is. I also manually adjusted the German translation. Unfortunately it can only be mastered with help of native speakers. I'll try to check the translations manually, sometimes deepl/goolge give alternatives. IMO the shorter the better, in mo
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 23:55:42 +00:00
data/editor.config
@ -440,2 +440,4 @@
<include group="poi_internet" />
</type>
<type id="healthcare-alternative" group="health">
<include group="poi_internet" />
Mr-Mime (Migrated from github.com) commented 2022-12-09 23:55:41 +00:00

I agree.
Changed organicmaps/organicmaps#4053/commits/7dd0719b3f287dbad1ade77d2d1bbb0f61504ec0

I agree. Changed https://git.omaps.dev/organicmaps/organicmaps/pulls/4053/commits/7dd0719b3f287dbad1ade77d2d1bbb0f61504ec0
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 23:58:22 +00:00
data/strings/types_strings.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 23:58:21 +00:00

While the official osm tag is psychotherapist I agree that it would be better to use psychotherapy.

@biodranik is it "ok" if not the direct tag name is used?

I would add the other variants as alternatives in categories.txt so that they are searchable.

While the official osm tag is `psychotherapist` I agree that it would be better to use `psychotherapy`. @biodranik is it "ok" if not the direct tag name is used? I would add the other variants as alternatives in `categories.txt` so that they are searchable.
Mr-Mime (Migrated from github.com) reviewed 2022-12-09 23:58:55 +00:00
data/strings/types_strings.txt
Mr-Mime (Migrated from github.com) commented 2022-12-09 23:58:55 +00:00

Same as above

Same as above
lunarna-gh (Migrated from github.com) reviewed 2022-12-10 00:37:21 +00:00
data/strings/types_strings.txt
lunarna-gh (Migrated from github.com) commented 2022-12-10 00:37:21 +00:00

pl = Krwiodawstwo, though I feel like "Blood donation" is a little ambiguous, wouldn't something like "Blood donation center"/"Blood donation facility" be a better name for the tag?

`pl = Krwiodawstwo`, though I feel like "Blood donation" is a little ambiguous, wouldn't something like "Blood donation center"/"Blood donation facility" be a better name for the tag?
lunarna-gh (Migrated from github.com) reviewed 2022-12-10 00:43:59 +00:00
data/strings/types_strings.txt
lunarna-gh (Migrated from github.com) commented 2022-12-10 00:43:59 +00:00

The iD editor calls it a Blood Donor Center (though I personally prefer Blood Donation Center, because the iD name makes it seem like it's a place for gatherings of blood donors instead of for donating blood, especially when translated)

The iD editor calls it a `Blood Donor Center` (though I personally prefer `Blood Donation Center`, because the iD name makes it seem like it's a place for gatherings of blood donors instead of for donating blood, especially when translated)
d4f5409d commented 2022-12-10 13:19:53 +00:00 (Migrated from github.com)
Copy link

Line 923 and line 4938 is problematic. I wrote down there my best suggestions, however this is hard to translate too.
organicmaps/organicmaps#4053

Line 923 and line 4938 is problematic. I wrote down there my best suggestions, however this is hard to translate too. https://git.omaps.dev/organicmaps/organicmaps/pulls/4053#pullrequestreview-1212567201
biodranik (Migrated from github.com) reviewed 2022-12-10 14:12:13 +00:00
data/strings/types_strings.txt
biodranik (Migrated from github.com) commented 2022-12-10 14:12:13 +00:00

It's ok, don't copy everything blindly, let's make it convenient for common folks.

It's ok, don't copy everything blindly, let's make it convenient for common folks.
Kazing (Migrated from github.com) approved these changes 2022-12-10 14:35:48 +00:00
biodranik (Migrated from github.com) reviewed 2022-12-11 09:45:39 +00:00
data/editor.config
@ -440,2 +440,4 @@
<include group="poi_internet" />
</type>
<type id="healthcare-alternative" group="health">
<include group="poi_internet" />
biodranik (Migrated from github.com) commented 2022-12-11 09:45:39 +00:00

We discussed that a new group "poi_internet" should be added (in a separate PR) and used for all locations where it is possible to have public or "for visitors only" internet access.

We discussed that a new group "poi_internet" should be added (in a separate PR) and used for all locations where it is possible to have public or "for visitors only" internet access.
biodranik (Migrated from github.com) reviewed 2022-12-11 09:49:30 +00:00
data/strings/types_strings.txt
biodranik (Migrated from github.com) commented 2022-12-11 09:49:30 +00:00

Psychotherapeutin is a feminine form of the word. While it is ok for categories synonyms, the displayed form on the screen should be gender-neutral (obviously).

Psychotherapeutin is a feminine form of the word. While it is ok for categories synonyms, the displayed form on the screen should be gender-neutral (obviously).
biodranik (Migrated from github.com) reviewed 2022-12-11 09:49:52 +00:00
data/strings/types_strings.txt
biodranik (Migrated from github.com) commented 2022-12-11 09:49:51 +00:00

Here and in all other places too.

Here and in all other places too.
Mr-Mime (Migrated from github.com) reviewed 2022-12-11 13:50:37 +00:00
data/editor.config
@ -440,2 +440,4 @@
<include group="poi_internet" />
</type>
<type id="healthcare-alternative" group="health">
<include group="poi_internet" />
Mr-Mime (Migrated from github.com) commented 2022-12-11 13:50:36 +00:00

So should I add this group to all new healthcare POI's ?
Or should I remove the internet field and the new group will be added later?

So should I add this group to all new healthcare POI's ? Or should I remove the internet field and the new group will be added later?
Mr-Mime commented 2022-12-11 13:53:16 +00:00 (Migrated from github.com)
Copy link

Line 923 and line 4938 is problematic. I wrote down there my best suggestions, however this is hard to translate too. #4053 (review)

Unfortunately I do not see you review :(
Clicking on the link just takes me back to this PR.

> Line 923 and line 4938 is problematic. I wrote down there my best suggestions, however this is hard to translate too. [#4053 (review)](https://git.omaps.dev/organicmaps/organicmaps/pulls/4053#pullrequestreview-1212567201) Unfortunately I do not see you review :( Clicking on the link just takes me back to this PR.
biodranik (Migrated from github.com) reviewed 2022-12-11 13:58:02 +00:00
data/editor.config
@ -440,2 +440,4 @@
<include group="poi_internet" />
</type>
<type id="healthcare-alternative" group="health">
<include group="poi_internet" />
biodranik (Migrated from github.com) commented 2022-12-11 13:58:02 +00:00

You can change it to poi_internet now, we'll merge this PR when #4050 will be merged.

You can change it to poi_internet now, we'll merge this PR when #4050 will be merged.
Mr-Mime (Migrated from github.com) reviewed 2022-12-11 16:16:46 +00:00
data/editor.config
@ -440,2 +440,4 @@
<include group="poi_internet" />
</type>
<type id="healthcare-alternative" group="health">
<include group="poi_internet" />
Mr-Mime (Migrated from github.com) commented 2022-12-11 16:16:45 +00:00

Okay added in organicmaps/organicmaps#4053/commits/d647b9e7369265917c07c1a2dbc4df9b1871ce5c

Okay added in https://git.omaps.dev/organicmaps/organicmaps/pulls/4053/commits/d647b9e7369265917c07c1a2dbc4df9b1871ce5c
Mr-Mime (Migrated from github.com) reviewed 2022-12-11 23:12:23 +00:00
data/strings/types_strings.txt
Mr-Mime (Migrated from github.com) commented 2022-12-11 23:12:23 +00:00

Done in organicmaps/organicmaps#4053/commits/364e17743570beb3392aa841183d54a371c4f5b3

Done in https://git.omaps.dev/organicmaps/organicmaps/pulls/4053/commits/364e17743570beb3392aa841183d54a371c4f5b3
Mr-Mime (Migrated from github.com) reviewed 2022-12-11 23:12:45 +00:00
data/strings/types_strings.txt
Mr-Mime (Migrated from github.com) commented 2022-12-11 23:12:45 +00:00

All places which had this problem fixed in organicmaps/organicmaps#4053/commits/364e17743570beb3392aa841183d54a371c4f5b3

All places which had this problem fixed in https://git.omaps.dev/organicmaps/organicmaps/pulls/4053/commits/364e17743570beb3392aa841183d54a371c4f5b3
Mr-Mime (Migrated from github.com) reviewed 2022-12-11 23:13:50 +00:00
data/categories.txt
@ -4811,0 +4995,4 @@
sw:Matibabu ya miguu|Daktari wa miguu
th:แก้โรคเท้า|แพทย์โรคเท้า
tr:Podiatri|Podiatrist
uk:Подологія
Mr-Mime (Migrated from github.com) commented 2022-12-11 23:13:49 +00:00

Adjusted the translations in organicmaps/organicmaps#4053/commits/364e17743570beb3392aa841183d54a371c4f5b3
They are now based on the german "Probenahme", which in many cases translated in shorter terms.

Adjusted the translations in https://git.omaps.dev/organicmaps/organicmaps/pulls/4053/commits/364e17743570beb3392aa841183d54a371c4f5b3 They are now based on the german "Probenahme", which in many cases translated in shorter terms.
Mr-Mime (Migrated from github.com) reviewed 2022-12-11 23:16:32 +00:00
data/strings/types_strings.txt
Mr-Mime (Migrated from github.com) commented 2022-12-11 23:16:32 +00:00

Good point and I totally agree.
I will change it to "Blood Donation Center" 👍

Good point and I totally agree. I will change it to "Blood Donation Center" :+1:
Kazing (Migrated from github.com) reviewed 2022-12-12 09:02:27 +00:00
data/strings/types_strings.txt
@ -9280,0 +9480,4 @@
cs = Psychoterapie
da = Psykoterapi
de = Psychotherapie
el = Ψυχοθεραπεία
Kazing (Migrated from github.com) commented 2022-12-12 09:02:13 +00:00

fr = Orthophonie
Orthophonie is used in France & Canada, Logopédie is used in Switzerland and Belgium (see https://fr.wikipedia.org/wiki/Orthophonie)
IDK how we can handle this

fr = Orthophonie Orthophonie is used in France & Canada, Logopédie is used in Switzerland and Belgium (see https://fr.wikipedia.org/wiki/Orthophonie) IDK how we can handle this
biodranik (Migrated from github.com) reviewed 2022-12-12 09:04:03 +00:00
data/strings/types_strings.txt
@ -9280,0 +9480,4 @@
cs = Psychoterapie
da = Psykoterapi
de = Psychotherapie
el = Ψυχοθεραπεία
biodranik (Migrated from github.com) commented 2022-12-12 09:04:02 +00:00

fr-CH and fr-BE?

fr-CH and fr-BE?
jimcarst (Migrated from github.com) approved these changes 2022-12-12 18:19:23 +00:00
matheusgomesms (Migrated from github.com) requested changes 2022-12-17 23:20:51 +00:00
matheusgomesms (Migrated from github.com) left a comment

Reviewed in Portuguese again, trying to be gender neutral

Reviewed in Portuguese again, trying to be gender neutral
data/categories.txt
matheusgomesms (Migrated from github.com) commented 2022-12-17 23:07:02 +00:00

pt:Podiatria|Podiatra
pt-BR:Podiatria|Podiatra

pt:Podiatria|Podiatra pt-BR:Podiatria|Podiatra
matheusgomesms (Migrated from github.com) commented 2022-12-17 23:12:41 +00:00

pt:Terapia da fala|Terapeuta da fala
pt-BR:Terapia da fala|Terapeuta da fala

(there is no logopedics in Portuguese anymore)

pt:Terapia da fala|Terapeuta da fala pt-BR:Terapia da fala|Terapeuta da fala (there is no logopedics in Portuguese anymore)
data/categories.txt
matheusgomesms (Migrated from github.com) commented 2022-12-17 22:59:21 +00:00

pt-BR:Fonoaudiologia|Fonoaudiólogo

pt-BR:Fonoaudiologia|Fonoaudiólogo
data/categories.txt
@ -4811,0 +4864,4 @@
fr:Audiologie|Audiologiste
he:אודיולוג|אודיולוגיה
hu:Audiológia|Audiológus
id:Audiologi|Audiologis
matheusgomesms (Migrated from github.com) commented 2022-12-17 23:19:56 +00:00

pt-BR:Hemocentro|Doação de sangue

pt-BR:Hemocentro|Doação de sangue
data/categories.txt
@ -4811,0 +4877,4 @@
ro:Audiologie|Audiolog
ru:Аудиология|Аудиолог
sk:Audiológia|Audiológ
sv:Audiologi|Audiolog
matheusgomesms (Migrated from github.com) commented 2022-12-17 23:04:29 +00:00

pt:Podiatria|Podiatra
pt-BR:Podiatria|Podiatra

pt:Podiatria|Podiatra pt-BR:Podiatria|Podiatra
data/strings/types_strings.txt
matheusgomesms (Migrated from github.com) commented 2022-12-17 23:13:46 +00:00

pt-BR = Fonoaudiologia

pt-BR = Fonoaudiologia
matheusgomesms (Migrated from github.com) commented 2022-12-17 23:16:20 +00:00

pt-BR = Hemocentro

pt-BR = Hemocentro
matheusgomesms (Migrated from github.com) commented 2022-12-17 23:18:09 +00:00

pt = Terapia da fala
pt-BR = Terapia da fala

pt = Terapia da fala pt-BR = Terapia da fala
Mr-Mime (Migrated from github.com) reviewed 2022-12-19 16:11:48 +00:00
data/categories.txt
@ -4811,0 +4864,4 @@
fr:Audiologie|Audiologiste
he:אודיולוג|אודיולוגיה
hu:Audiológia|Audiológus
id:Audiologi|Audiologis
Mr-Mime (Migrated from github.com) commented 2022-12-19 16:11:48 +00:00

Thanks changed in organicmaps/organicmaps#4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2

Thanks changed in https://git.omaps.dev/organicmaps/organicmaps/pulls/4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2
Mr-Mime (Migrated from github.com) reviewed 2022-12-19 16:11:57 +00:00
data/strings/types_strings.txt
Mr-Mime (Migrated from github.com) commented 2022-12-19 16:11:57 +00:00

Thanks changed in organicmaps/organicmaps#4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2

Thanks changed in https://git.omaps.dev/organicmaps/organicmaps/pulls/4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2
Mr-Mime (Migrated from github.com) reviewed 2022-12-19 16:12:04 +00:00
data/strings/types_strings.txt
Mr-Mime (Migrated from github.com) commented 2022-12-19 16:12:03 +00:00

Thanks changed in organicmaps/organicmaps#4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2

Thanks changed in https://git.omaps.dev/organicmaps/organicmaps/pulls/4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2
Mr-Mime (Migrated from github.com) reviewed 2022-12-19 16:12:12 +00:00
data/strings/types_strings.txt
Mr-Mime (Migrated from github.com) commented 2022-12-19 16:12:11 +00:00

Thanks changed in organicmaps/organicmaps#4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2

Thanks changed in https://git.omaps.dev/organicmaps/organicmaps/pulls/4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2
Mr-Mime (Migrated from github.com) reviewed 2022-12-19 16:12:18 +00:00
data/categories.txt
Mr-Mime (Migrated from github.com) commented 2022-12-19 16:12:18 +00:00

Thanks changed in organicmaps/organicmaps#4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2

Thanks changed in https://git.omaps.dev/organicmaps/organicmaps/pulls/4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2
Mr-Mime (Migrated from github.com) reviewed 2022-12-19 16:12:25 +00:00
data/categories.txt
@ -4811,0 +4877,4 @@
ro:Audiologie|Audiolog
ru:Аудиология|Аудиолог
sk:Audiológia|Audiológ
sv:Audiologi|Audiolog
Mr-Mime (Migrated from github.com) commented 2022-12-19 16:12:24 +00:00

Thanks changed in organicmaps/organicmaps#4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2

Thanks changed in https://git.omaps.dev/organicmaps/organicmaps/pulls/4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2
Mr-Mime (Migrated from github.com) reviewed 2022-12-19 16:12:26 +00:00
data/categories.txt
Mr-Mime (Migrated from github.com) commented 2022-12-19 16:12:25 +00:00

Thanks changed in organicmaps/organicmaps#4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2

Thanks changed in https://git.omaps.dev/organicmaps/organicmaps/pulls/4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2
Mr-Mime (Migrated from github.com) reviewed 2022-12-19 16:12:32 +00:00
data/categories.txt
Mr-Mime (Migrated from github.com) commented 2022-12-19 16:12:32 +00:00

Thanks changed in organicmaps/organicmaps#4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2

Thanks changed in https://git.omaps.dev/organicmaps/organicmaps/pulls/4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2
Mr-Mime (Migrated from github.com) reviewed 2022-12-19 16:12:58 +00:00
data/strings/types_strings.txt
Mr-Mime (Migrated from github.com) commented 2022-12-19 16:12:58 +00:00

Renaming done in organicmaps/organicmaps#4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2

Renaming done in https://git.omaps.dev/organicmaps/organicmaps/pulls/4053/commits/dad75fe91b511fd26108fab402f7fc0a38781fe2
LaoshuBaby (Migrated from github.com) reviewed 2022-12-20 02:02:42 +00:00
LaoshuBaby (Migrated from github.com) left a comment

OK, here is my review suggestion about zh-Hans translation, I changed them to the same as id-tagging-schema because those will be more natural and normal, the previous one seems a little stiff.

I can't commit directly (failed), so this is all my unsaved edit. 😰🤬 This need to be apply to both Android and iOS format.

OK, here is my review suggestion about zh-Hans translation, I changed them to the same as [id-tagging-schema](https://github.com/openstreetmap/id-tagging-schema/blob/b2b1ba645a3535b89f5a17a8dd1775eacea74ec4/dist/translations/zh-CN.json) because those will be more natural and normal, the previous one seems a little stiff. I can't commit directly (failed), so this is all my unsaved edit. 😰🤬 This need to be apply to both Android and iOS format.
data/strings/types_strings.txt
LaoshuBaby (Migrated from github.com) commented 2022-12-20 01:57:57 +00:00 
    zh-Hans = 替代医学
```suggestion zh-Hans = 替代医学 ```
LaoshuBaby (Migrated from github.com) commented 2022-12-20 01:58:15 +00:00 
    zh-Hans = 听力学家
```suggestion zh-Hans = 听力学家 ```
LaoshuBaby (Migrated from github.com) commented 2022-12-20 01:58:27 +00:00 
    zh-Hans = 验光师
```suggestion zh-Hans = 验光师 ```
LaoshuBaby (Migrated from github.com) commented 2022-12-20 01:58:40 +00:00 
    zh-Hans = 足疗师
```suggestion zh-Hans = 足疗师 ```
LaoshuBaby (Migrated from github.com) commented 2022-12-20 01:58:51 +00:00 
    zh-Hans = 心理治疗师
```suggestion zh-Hans = 心理治疗师 ```
LaoshuBaby (Migrated from github.com) commented 2022-12-20 01:59:04 +00:00 
    zh-Hans = 样本采集设施
```suggestion zh-Hans = 样本采集设施 ```
LaoshuBaby (Migrated from github.com) commented 2022-12-20 01:59:16 +00:00 
    zh-Hans = 语言治疗师
```suggestion zh-Hans = 语言治疗师 ```
lunarna-gh (Migrated from github.com) approved these changes 2022-12-22 00:19:46 +00:00
vng (Migrated from github.com) reviewed 2023-02-14 16:05:20 +00:00
vng (Migrated from github.com) left a comment

I really like this PR and want to merge it.
Could you please check comments once again, rebase and make 4 final commits.

I really like this PR and want to merge it. Could you please check comments once again, rebase and make 4 final commits.
data/categories.txt
@ -4811,0 +4841,4 @@
sv:Alternativ medicin
sw:Dawa mbadala
th:การแพทย์ทางเลือก
tr:Alternatif tıp
vng (Migrated from github.com) commented 2023-02-14 16:02:35 +00:00

Please, comment/remove this category or make simple "Blood"
Due to search specific it will interfere with other categories (by tokens "center").

Please, comment/remove this category or make simple "Blood" Due to search specific it will interfere with other categories (by tokens "center").
data/categories.txt
@ -4811,0 +4994,4 @@
sv:Fotvård|Fotvårdare
sw:Matibabu ya miguu|Daktari wa miguu
th:แก้โรคเท้า|แพทย์โรคเท้า
tr:Podiatri|Podiatrist
vng (Migrated from github.com) commented 2023-02-14 16:04:16 +00:00

Please, comment/remove this category.
Due to search specific it will interfere with other categories and translations are strange IMHO (because of "sample").

Please, comment/remove this category. Due to search specific it will interfere with other categories and translations are strange IMHO (because of "sample").
biodranik (Migrated from github.com) reviewed 2023-02-14 23:36:45 +00:00
data/categories.txt
@ -4811,0 +4879,4 @@
sk:Audiológia|Audiológ
sv:Audiologi|Audiolog
sw:Mtaalamu wa kusikia|Audiology
th:โสตวิทยา|นักโสตสัมผัสวิทยา
biodranik (Migrated from github.com) commented 2023-02-14 23:36:45 +00:00

It can be just blood donation for the search. Later we'll implement automatic suggestions even without numbers.

It can be just blood donation for the search. Later we'll implement automatic suggestions even without numbers.
biodranik (Migrated from github.com) reviewed 2023-02-14 23:37:47 +00:00
data/categories.txt
@ -4811,0 +5036,4 @@
tr:Psikoterapi|Psikoterapist
uk:Психотерапія|Психотерапевт
vi:Tâm lý trị liệu|nhà trị liệu tâm lý
zh-Hans:心理治疗师
biodranik (Migrated from github.com) commented 2023-02-14 23:37:47 +00:00

Can we leave only a few valid translations here for maps generation, and add other translations later?

Can we leave only a few valid translations here for maps generation, and add other translations later?
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
biodranik
Kazing
jimcarst
matheusgomesms
lunarna-gh
Labels
Clear labels   
Accessibility

issues affecting users with specific needs

  
Accessibility

issues affecting users with specific needs

  
Address

Issues with addresses, post codes, city/town/village borders

  
Address

Issues with addresses, post codes, city/town/village borders

  
Android

Android development

  
Android

Android development

  
Android Auto

Android Auto

  
Android Auto

Android Auto

  
Android Automotive (AAOS)

   
Android Automotive (AAOS)

   
API

Short Links, deep links and url schemes, including ge0 and om://

  
API

Short Links, deep links and url schemes, including ge0 and om://

  
AppGallery

Huawei AppGallery

  
AppGallery

Huawei AppGallery

  
AppStore

Apple AppStore

  
AppStore

Apple AppStore

  
Battery and Performance

Performance and battery consumption-related issues and optimizations

  
Battery and Performance

Performance and battery consumption-related issues and optimizations

  
Blocker

An issue blocking the release

  
Blocker

An issue blocking the release

  
Bookmarks and Tracks

Bookmarks, imported tracks, and KML, KMZ, KMB, GPX, GPZ import or export

  
Bookmarks and Tracks

Bookmarks, imported tracks, and KML, KMZ, KMB, GPX, GPZ import or export

  
Borders

Country borders and polygons

  
Borders

Country borders and polygons

  
Bug

Something isn't working

  
Bug

Something isn't working

  
Build

Compilation issue

  
Build

Compilation issue

  
CarPlay

CarPlay Integration

  
CarPlay

CarPlay Integration

  
Classificator

Classify object by types

  
Classificator

Classify object by types

  
Community

Community relations

  
Community

Community relations

  
Core

Cross-platform C++ libraries with a core functionality

  
Core

Cross-platform C++ libraries with a core functionality

  
CrashReports

Crash Reporting

  
CrashReports

Crash Reporting

  
Cycling

Bike, cycle, biking and related

  
Cycling

Bike, cycle, biking and related

  
Desktop

Desktop application

  
Desktop

Desktop application

  
DevEx

Developer Experience

  
DevEx

Developer Experience

  
DevOps

Automation and pipelines

  
DevOps

Automation and pipelines

  
dev_sandbox

A desktop app to debug rendering

  
dev_sandbox

A desktop app to debug rendering

  
Directions

Issues with next turns, labels, streets, voice instructions

  
Directions

Issues with next turns, labels, streets, voice instructions

  
Documentation

Improvements or additions to documentation

  
Documentation

Improvements or additions to documentation

  
Downloader

Map dowloader

  
Downloader

Map dowloader

  
Drape

Drape OpenGL, Vulkan and Metal graphics rendering engine

  
Drape

Drape OpenGL, Vulkan and Metal graphics rendering engine

  
Driving

Drive a car related issues

  
Driving

Drive a car related issues

  
Duplicate

This issue or pull request already exists

  
Duplicate

This issue or pull request already exists

  
Editor

OSM Editor

  
Editor

OSM Editor

  
Elevation

Isolines and altitude

  
Elevation

Isolines and altitude

  
Enhancement

New feature or request, an improvement of some existing feature

  
Enhancement

New feature or request, an improvement of some existing feature

  
Epic

A large body work

  
Epic

A large body work

  
External Map Datasets

TIGER, Ordnance Survey, ASTER, SRTM, etc.

  
External Map Datasets

TIGER, Ordnance Survey, ASTER, SRTM, etc.

  
F-Droid

F-Droid build and distribution

  
F-Droid

F-Droid build and distribution

  
Fonts

Font and text rendering

  
Fonts

Font and text rendering

  
Frequently User Reported

Most annoying UX and other issues for users reported by many people

  
Frequently User Reported

Most annoying UX and other issues for users reported by many people

  
Fund

   
Fund

   
Generator

Related to generator tool.

  
Generator

Related to generator tool.

  
Good first issue

Good for newcomers

  
Good first issue

Good for newcomers

  
Google Play

Google Play

  
Google Play

Google Play

  
GPS

Location and positioning issues

  
GPS

Location and positioning issues

  
GSoC

Ideas for Google Summer of Code

  
GSoC

Ideas for Google Summer of Code

  
iCloud

   
iCloud

   
Icons

Map and app icons

  
Icons

Map and app icons

  
iOS

iOS development

  
iOS

iOS development

  
Legal

Legal aspects

  
Legal

Legal aspects

  
Linux Desktop

Ubuntu, Gentoo, Red Hat, Debian, Cent OS, Fedora, etc.

  
Linux Desktop

Ubuntu, Gentoo, Red Hat, Debian, Cent OS, Fedora, etc.

  
Linux packaging

   
Linux packaging

   
Linux Phone

LibreM, PinePhone, Wayland and other mobile Linux versions

  
Linux Phone

LibreM, PinePhone, Wayland and other mobile Linux versions

  
Mac OS

Desktop issues related to Mac OS X, OM running on M1, M2, M3 Apple silicon, or Qt version

  
Mac OS

Desktop issues related to Mac OS X, OM running on M1, M2, M3 Apple silicon, or Qt version

  
Map Data

OpenStreetMap data related issues

  
Map Data

OpenStreetMap data related issues

  
Metro

Subway, Tube, light-rail public transport issues

  
Metro

Subway, Tube, light-rail public transport issues

  
Navigation

Issues related to the active Navigator / Navigation mode

  
Navigation

Issues related to the active Navigator / Navigation mode

  
Need Feedback

Further information is requested

  
Need Feedback

Further information is requested

  
Night Mode

Night or dark mode feature

  
Night Mode

Night or dark mode feature

  
NLnet 2024-06-281

Tasks related to NLnet 2024-06-281 project.

  
NLnet 2024-06-281

Tasks related to NLnet 2024-06-281 project.

  
No Feature Parity

A platform needs this to be implemented to have feature parity with other platforms

  
No Feature Parity

A platform needs this to be implemented to have feature parity with other platforms

  
Opening Hours

Business Hours, off time, holidays, seasonal

  
Opening Hours

Business Hours, off time, holidays, seasonal

  
Outdoors

Hiking, mtb, 4x4...

  
Outdoors

Hiking, mtb, 4x4...

  
POI Info

Feature metadata, OSM tags that are displayed in Place Page

  
POI Info

Feature metadata, OSM tags that are displayed in Place Page

  
Privacy

Privacy

  
Privacy

Privacy

  
Public Transport

Bus, trolleybus, train, tram, metro, subway, light rail

  
Public Transport

Bus, trolleybus, train, tram, metro, subway, light rail

  
Raw Idea

An idea that needs to be elaborated

  
Raw Idea

An idea that needs to be elaborated

  
Refactoring

   
Refactoring

   
Regional

This issue is different depending on the country or region

  
Regional

This issue is different depending on the country or region

  
Regression

A regression bug

  
Regression

A regression bug

  
Releases

Meta-tickets for tracking the release procedure

  
Releases

Meta-tickets for tracking the release procedure

  
RoboTest

Robo / Monkey Auto Tests

  
RoboTest

Robo / Monkey Auto Tests

  
Route Planning

Preview and plan your track

  
Route Planning

Preview and plan your track

  
Routing

Route building issues, e.g. valid route, valid ETA

  
Routing

Route building issues, e.g. valid route, valid ETA

  
Ruler

Helicopter routing, "as a crow flies"

  
Ruler

Helicopter routing, "as a crow flies"

  
Search

Search

  
Search

Search

  
Security

Security improvements

  
Security

Security improvements

  
Styles

Map drawing styles

  
Styles

Map drawing styles

  
Tests

   
Tests

   
Track Recording

Track Recording

  
Track Recording

Track Recording

  
Translations

Localization and translations issues

  
Translations

Localization and translations issues

  
TTS

Text-to-Speech

  
TTS

Text-to-Speech

  
UI

User interface issues

  
UI

User interface issues

  
UX

User eXperience, an issue with usability

  
UX

User eXperience, an issue with usability

  
Walk Navigation

Foot pedestrian mode

  
Walk Navigation

Foot pedestrian mode

  
Watches

Android Watches or Apple Watches support

  
Watches

Android Watches or Apple Watches support

  
Web

https://organicmaps.app/

  
Web

https://organicmaps.app/

  
Wikipedia

Issues related to Wiki articles embedded in OM data files.

  
Wikipedia

Issues related to Wiki articles embedded in OM data files.

  
Windows

Windows

  
Windows

Windows

  
Won't fix

Unfeasible or impossible to resolve

  
Won't fix

Unfeasible or impossible to resolve

  
World Map

Issues about improving the base map of the whole world that is bundled with the app

  
World Map

Issues about improving the base map of the whole world that is bundled with the app

No labels
Accessibility
Accessibility
Address
Address
Android
Android
Android Auto
Android Auto
Android Automotive (AAOS)
Android Automotive (AAOS)
API
API
AppGallery
AppGallery
AppStore
AppStore
Battery and Performance
Battery and Performance
Blocker
Blocker
Bookmarks and Tracks
Bookmarks and Tracks
Borders
Borders
Bug
Bug
Build
Build
CarPlay
CarPlay
Classificator
Classificator
Community
Community
Core
Core
CrashReports
CrashReports
Cycling
Cycling
Desktop
Desktop
DevEx
DevEx
DevOps
DevOps
dev_sandbox
dev_sandbox
Directions
Directions
Documentation
Documentation
Downloader
Downloader
Drape
Drape
Driving
Driving
Duplicate
Duplicate
Editor
Editor
Elevation
Elevation
Enhancement
Enhancement
Epic
Epic
External Map Datasets
External Map Datasets
F-Droid
F-Droid
Fonts
Fonts
Frequently User Reported
Frequently User Reported
Fund
Fund
Generator
Generator
Good first issue
Good first issue
Google Play
Google Play
GPS
GPS
GSoC
GSoC
iCloud
iCloud
Icons
Icons
iOS
iOS
Legal
Legal
Linux Desktop
Linux Desktop
Linux packaging
Linux packaging
Linux Phone
Linux Phone
Mac OS
Mac OS
Map Data
Map Data
Metro
Metro
Navigation
Navigation
Need Feedback
Need Feedback
Night Mode
Night Mode
NLnet 2024-06-281
NLnet 2024-06-281
No Feature Parity
No Feature Parity
Opening Hours
Opening Hours
Outdoors
Outdoors
POI Info
POI Info
Privacy
Privacy
Public Transport
Public Transport
Raw Idea
Raw Idea
Refactoring
Refactoring
Regional
Regional
Regression
Regression
Releases
Releases
RoboTest
RoboTest
Route Planning
Route Planning
Routing
Routing
Ruler
Ruler
Search
Search
Security
Security
Styles
Styles
Tests
Tests
Track Recording
Track Recording
Translations
Translations
TTS
TTS
UI
UI
UX
UX
Walk Navigation
Walk Navigation
Watches
Watches
Web
Web
Wikipedia
Wikipedia
Windows
Windows
Won't fix
Won't fix
World Map
World Map
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#4053
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?