[android] Reworked descriptions in the editor #6173

map-per · 2023-10-01T15:15:22Z

map-per commented

2023-10-01 15:15:22 +00:00

Reworked descriptions in the editor:

Placed info about OSM at the top to prevent people from using the editor for personal notes. Moreover it is a good practice for a privacy focused app to inform users about what and where data is send.
Improved the hint of the the note field. Currently the description below the field is very misleading and many people use it like a changeset comment as they don't know it's for OSM notes.
Apart from the slight change in the "Note to OpenStreetMap volunteers" string this PR doesn't affect iOS

Now	Before

Todo:

Translations

Reworked descriptions in the editor: - Placed info about OSM at the top to prevent people from using the editor for personal notes. Moreover it is a good practice for a privacy focused app to inform users about what and where data is send. - Improved the hint of the the note field. Currently the description below the field is very misleading and many people use it like a changeset comment as they don't know it's for OSM notes. - Apart from the slight change in the "Note to OpenStreetMap volunteers" string this PR doesn't affect iOS | Now | Before | |--------|--------| |![%2Fstorage%2Femulated%2F0%2FDCIM%2FScreenshots%2FIMG_20240824_210007](https://github.com/user-attachments/assets/49ff54ea-a773-4a4d-afe2-0670aa52603e)|![Screenshot_2024-08-18-18-17-28-581_app organicmaps](https://github.com/user-attachments/assets/f69e5452-724c-4d9f-8607-9df56bfc839b)| |![Screenshot_2024-08-24-20-45-21-816_app organicmaps debug](https://github.com/user-attachments/assets/58defcfd-8594-40de-a6de-7c8c5d8d7bdc)|![Screenshot_2024-08-18-18-15-01-604_app organicmaps](https://github.com/user-attachments/assets/da08b60e-8f24-4df8-9c65-4469207812e3)| ### Todo: - [x] Translations

❤️ 1 🚀 1

biodranik (Migrated from github.com) reviewed 2023-10-07 11:33:39 +00:00

android/app/src/main/res/layout/fragment_editor.xml

biodranik (Migrated from github.com) commented

2023-10-07 11:33:38 +00:00

Is this text replaced by another from strings.txt?

map-per reviewed 2023-10-07 12:03:58 +00:00

android/app/src/main/res/layout/fragment_editor.xml

map-per commented

2023-10-07 12:03:58 +00:00

I now added editor_note_description to strings.txt

I now added `editor_note_description` to strings.txt

biodranik (Migrated from github.com) reviewed 2023-10-07 12:15:23 +00:00

biodranik (Migrated from github.com) left a comment

Thanks! The next step would be to make it simpler (if possible).

Now the note has 3 texts:

Title
Description
Edit text hint

Can we squash them and make a better wording text, and use only edit text hint, without title and description? OM is about simplicity and efficiency ;-) Maybe in a separate PR?

Thanks! The next step would be to make it simpler (if possible). Now the note has 3 texts: 1. Title 2. Description 3. Edit text hint Can we squash them and make a better wording text, and use only edit text hint, without title and description? OM is about simplicity and efficiency ;-) Maybe in a separate PR?

android/app/src/main/java/app/organicmaps/editor/EditorFragment.java

					
				@ -476,7 +477,8 @@ public class EditorFragment extends BaseMwmFragment implements View.OnClickListe

				    mOpeningHours.setOnClickListener(this);

biodranik (Migrated from github.com) commented

2023-10-07 12:13:45 +00:00

Is cardMore used somewhere? Can it be deleted?

				`@ -476,7 +477,8 @@ public class EditorFragment extends BaseMwmFragment implements View.OnClickListe`
				`mOpeningHours.setOnClickListener(this);`

 @ -16589,0 +16588,4 @@
   [editor_note_hint]
     comment = Hint of the input field in the OSM note section of the editor
     tags = android

 @ -16589,0 +16592,4 @@
     en = Describe errors on the map or things that cannot be edited with Organic Maps
     af = Beskryf foute in die kaart of wat nie met Organiese Kaarte geredigeer kan word nie
     ar = وصف الأخطاء على الخريطة أو الأشياء التي لا يمكن تحريرها باستخدام الخرائط العضوية
     az = Xəritədəki səhvləri və ya Üzvi Xəritələrdən istifadə edərək redaktə edilə bilməyənləri təsvir edin

 @ -16589,0 +16586,4 @@
     zh-Hans = OpenStreetMap 志愿者须知（可选）
     zh-Hant = OpenStreetMap 志工注意事項（可選）
   [editor_note_hint]

 @ -16589,0 +16647,4 @@
     el = Οι επεξεργασίες σας μεταφορτώνονται στη δημόσια βάση δεδομένων <a href="https://wiki.openstreetmap.org/wiki/El:About_OpenStreetMap">OpenStreetMap</a>. Παρακαλούμε μην προσθέτετε προσωπικές πληροφορίες ή πληροφορίες που προστατεύονται από πνευματικά δικαιώματα.
     es = Sus ediciones se cargan en la base de datos pública <a href="https://wiki.openstreetmap.org/wiki/ES:Acerca_de_OpenStreetMap">OpenStreetMap</a>. Por favor, no añada información personal o protegida por derechos de autor.
     et = Teie muudatused laaditakse üles avalikku <a href="https://wiki.openstreetmap.org/wiki/About_OpenStreetMap">OpenStreetMap</a> andmebaasi. Palun ärge lisage isiklikku või autoriõigusega kaitstud teavet.
     eu = Zure aldaketak <a href="https://wiki.openstreetmap.org/wiki/About_OpenStreetMap">OpenStreetMap</a> datu-base publikora kargatzen dira. Mesedez, ez gehitu informazio pertsonalik edo copyrightdun informaziorik.

Rows
Columns