organicmaps/organicmaps-tmp

Archived

[editor] Clarify building_levels description in editor hint #10069

Open

DeshDeepakKant wants to merge 1 commit from DeshDeepakKant/fix/building_levels_hint into master

DeshDeepakKant commented

2025-01-14 21:36:06 +00:00

(Migrated from github.com)

Description

Updated the hint text for building levels in the editor to make it clearer that:

Ground floor should be included in the count
Roof levels should be excluded
Removed the maximum value mention from the hint as it's already shown in the error popup

Fixes #10025.

Changed from:
"Number of floors (maximum of %d)"

To:
"Floors (inc. ground floor, excl. roof levels)"

Before

After

Alternative Solutions Considered

Tried longer, more explicit version:
"Number of floors (including ground floor, excluding roof levels)"
Issues found:
- Text was getting truncated in the UI

Signed-off-by: Desh Deepak Kant deshdeepakkant@gmail.com

# Description Updated the hint text for building levels in the editor to make it clearer that: - Ground floor should be included in the count - Roof levels should be excluded - Removed the maximum value mention from the hint as it's already shown in the error popup ## Related Issue - Fixes **#10025**. Changed from: ```"Number of floors (maximum of %d)"``` To: ```"Floors (inc. ground floor, excl. roof levels)"``` ## Before ![3aae0c78-6d4a-4103-8c88-17fcb7c2d322](https://github.com/user-attachments/assets/97a54e94-0ecb-4f6a-9823-a5a55b1cde3d) ## After ![843e8a36-f949-4041-9309-7a999e5d9e3e](https://github.com/user-attachments/assets/ed1a288b-207a-4fdd-84b1-e554c8396aae) ## Alternative Solutions Considered 1. Tried longer, more explicit version: ```"Number of floors (including ground floor, excluding roof levels)"``` Issues found: - Text was getting truncated in the UI ![4fe59c56-ab4f-42c7-aff7-5a2260e1301b](https://github.com/user-attachments/assets/55991daf-7a03-4828-b809-2867da9bcf66) Signed-off-by: Desh Deepak Kant <deshdeepakkant@gmail.com>

map-per requested changes 2025-01-15 12:26:28 +00:00

map-per left a comment

Contributor

Thanks for the PR, here a few remarks:

The code that programmatically injects "50" into the string should be removed
The editor_storey_number string is also used in iOS. To not brake iOS it's probably best to create a separate string that can be used just for Android until iOS is changed as well.
The string should be translated into all languages (see: TRANSLATIONS.md).

General tip: You can use tools/unix/generate_localizations.sh to distribute changes from strings.txt to the Android and iOS translation files.

Thanks for the PR, here a few remarks: - The code that programmatically injects "50" into the string should be removed - The `editor_storey_number` string is also used in iOS. To not brake iOS it's probably best to create a separate string that can be used just for Android until iOS is changed as well. - The string should be translated into all languages (see: [TRANSLATIONS.md](https://github.com/organicmaps/organicmaps/blob/master/docs/TRANSLATIONS.md)). General tip: You can use `tools/unix/generate_localizations.sh` to distribute changes from _strings.txt_ to the Android and iOS translation files.

This repo is archived. You cannot comment on pull requests.

No reviewers

No labels

Android Automotive (AAOS)

Android Automotive (AAOS)

Battery and Performance

Battery and Performance

Bookmarks and Tracks

Bookmarks and Tracks

External Map Datasets

External Map Datasets

Frequently User Reported

Frequently User Reported

Good first issue

Good first issue

Linux packaging

Linux packaging

NLnet 2024-06-281

NLnet 2024-06-281

No Feature Parity

No Feature Parity

Public Transport

Public Transport

Track Recording

Track Recording

Walk Navigation

Walk Navigation

No milestone

No project

No assignees

2 participants

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#10069

No description provided.