organicmaps/organicmaps-tmp
Archived
13
Fork 1
Code Issues 2.7k Pull requests 182 Projects Releases 65 Wiki Activity Actions

Disable .so libraries compression in the apk #10076

Open
zeac wants to merge 1 commit from zeac/feature/1 into master
pull from: zeac/feature/1
merge into: organicmaps:master
Conversation 0 Commits 1 Files changed 1 +6
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
android/app/build.gradle
View file

@ -360,6 +360,12 @@ android {
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}
packagingOptions {
jniLibs {
useLegacyPackaging = false
biodranik commented 2025-01-16 17:57:59 +00:00 (Migrated from github.com)
Review
Copy link

Whether to use the legacy convention of compressing all .so files in the APK. If null, .so files will be uncompressed and page-aligned when minSdk >= 23.

  1. What happens for minSdk 21?
  2. What are the pros and cons? Will apk size increase significantly?
> Whether to use the legacy convention of compressing all .so files in the APK. If null, .so files will be uncompressed and page-aligned when minSdk >= 23. 1. What happens for minSdk 21? 2. What are the pros and cons? Will apk size increase significantly?
zeac commented 2025-01-16 19:11:34 +00:00 (Migrated from github.com)
Review
Copy link

  1. On minSdk 21 .so files will continue to be extracted from the APK, so they will exist in 2 copies on the device instead of one and one compressed. Android 5 users are victims of this change but how many of them are there? Many apps in Play Store have minSdk 23 these days.

  2. Raw APK size increase increased significantly. webDebug APK with all ABIs is about two times larger (83Mb vs 154Mb). But:
    a) gzipped size of the APK slightly decreases(66Mb vs 60Mb), because compression works better if applied at the end. So less data is consumed if HTTP gzip is enabled.
    b) storage occupied by the app decreases because it no longer necessary to extract .so files. So only one copy of each library is on the disk, instead one and a half.

So it could negatively affect distribution channels which do not support HTTP gzip and use single APK for all ABIs. And it looks like F-Droid is one of them which is sad.

https://developer.android.com/build/releases/past-releases/agp-3-6-0-release-notes#extractNativeLibs
https://developer.android.com/build/releases/past-releases/agp-4-2-0-release-notes#compress-native-libs-dsl

1. On minSdk 21 .so files will continue to be extracted from the APK, so they will exist in 2 copies on the device instead of one and one compressed. Android 5 users are victims of this change but how many of them are there? Many apps in Play Store have minSdk 23 these days. 2. Raw APK size increase increased significantly. webDebug APK with all ABIs is about two times larger (83Mb vs 154Mb). But: a) gzipped size of the APK slightly decreases(66Mb vs 60Mb), because compression works better if applied at the end. So less data is consumed if HTTP gzip is enabled. b) storage occupied by the app decreases because it no longer necessary to extract .so files. So only one copy of each library is on the disk, instead one and a half. So it could negatively affect distribution channels which do not support HTTP gzip and use single APK for all ABIs. And it looks like F-Droid is one of them which is sad. https://developer.android.com/build/releases/past-releases/agp-3-6-0-release-notes#extractNativeLibs https://developer.android.com/build/releases/past-releases/agp-4-2-0-release-notes#compress-native-libs-dsl
pastk commented 2025-01-22 07:56:23 +00:00
Review
Copy link

And also all our apks distributed via Github directly or via Obtainium? And likely the ones distributed via Accrescent.
What about Huawei store?

Is it possible to apply this change to Google build flavor only?

And also all our apks distributed via Github directly or via Obtainium? And likely the ones distributed via Accrescent. What about Huawei store? Is it possible to apply this change to Google build flavor only?
zeac commented 2025-01-23 08:25:20 +00:00 (Migrated from github.com)
Review
Copy link

This change doesn't affect Google Play, it uses different packaging mechanism – app bundles, in which compression is already disabled.

Huawei Store also supports App bundles, but I don't know how Organic Maps are uploaded there.

This change doesn't affect Google Play, it uses different packaging mechanism – app bundles, in which compression is already disabled. Huawei Store also supports [App bundles](https://developer.huawei.com/consumer/en/agconnect/app-bundle/), but I don't know how Organic Maps are uploaded there.
pastk commented 2025-01-24 06:19:20 +00:00
Review
Copy link

So what current OM distribution channels that would benefit from this change for sure? (i.e. have single apks and http gzip enabled)

So what current OM distribution channels that would benefit from this change for sure? (i.e. have single apks and http gzip enabled)
rtsisyk commented 2025-01-26 09:43:35 +00:00
Review
Copy link

On minSdk 21 .so files will continue to be extracted from the APK, so they will exist in 2 copies on the device instead of one and one compressed. Android 5 users are victims of this change but how many of them are there?

SDK < 23 isn't a big deal, but we'll likely need to drop support for it sooner or later.

Raw APK size increase increased significantly. webDebug APK with all ABIs is about two times larger (83Mb vs 154Mb). But:
a) gzipped size of the APK slightly decreases(66Mb vs 60Mb), because compression works better if applied at the end. So less data is consumed if HTTP gzip is enabled.
b) storage occupied by the app decreases because it no longer necessary to extract .so files. So only one copy of each library is on the disk, instead one and a half.

This is huge!

This change doesn't affect Google Play, it uses different packaging mechanism – app bundles, in which compression is already disabled.
Huawei Store also supports App bundles, but I don't know how Organic Maps are uploaded there.

Both Google Play and Huawei AppGallery are distributed via AAB bundles.

So it could negatively affect distribution channels which do not support HTTP gzip and use single APK for all ABIs.

The F-Droid team initially requested that we reduce the APK size to 50MB (without the World.mwm file).

> On minSdk 21 .so files will continue to be extracted from the APK, so they will exist in 2 copies on the device instead of one and one compressed. Android 5 users are victims of this change but how many of them are there? SDK < 23 isn't a big deal, but we'll likely need to drop support for it sooner or later. > Raw APK size increase increased significantly. webDebug APK with all ABIs is about two times larger (83Mb vs 154Mb). But: a) gzipped size of the APK slightly decreases(66Mb vs 60Mb), because compression works better if applied at the end. So less data is consumed if HTTP gzip is enabled. b) storage occupied by the app decreases because it no longer necessary to extract .so files. So only one copy of each library is on the disk, instead one and a half. This is huge! > This change doesn't affect Google Play, it uses different packaging mechanism – app bundles, in which compression is already disabled. > Huawei Store also supports [App bundles](https://developer.huawei.com/consumer/en/agconnect/app-bundle/), but I don't know how Organic Maps are uploaded there. Both Google Play and Huawei AppGallery are distributed via AAB bundles. > So it could negatively affect distribution channels which do not support HTTP gzip and use single APK for all ABIs. The F-Droid team initially requested that we reduce the APK size to 50MB (without the World.mwm file).
rtsisyk commented 2025-01-26 09:43:53 +00:00
Review
Copy link

What problem does this PR fix? Is it organicmaps/organicmaps#539 or something else?

What problem does this PR fix? Is it https://git.omaps.dev/organicmaps/organicmaps/issues/539 or something else?
}
}
}
dependencies {