[android][sdk] Create OrganicMaps sdk class #10078

Open

AndrewShkrob wants to merge 4 commits from AndrewShkrob/android/sdk-om into master

AndrewShkrob commented

2025-01-16 19:23:35 +00:00

Member

Each commit can be reviewed (and even merged) separately but in the specified order.

The main idea is to move all core-related classes into a separate package - app.organicmaps.sdk.
Then we make sure that the UI part of the application doesn't use/call native methods directly. For all such cases we need to create separate wrapper classes, f.e. in routing case we'll need app.organicmaps.sdk.routing.RoutingManager that will be used by Routing/NavigationController.
Then we move app.organicmaps.sdk package into a separate android module.
We'll also have to configure resources for this module - assets, strings, drawables.
And the first step is done.
After that - more refactorings, improvements and so on.

Commit 1 - OrganicMaps class:
Let's begin separating the UI from the core.
Created app.organicmaps.sdk package. Created OrganicMaps class.
Moved OM's core-related logic from MwmApplication to OrganicMaps class.

Commit 2 Framework class:
Framework class decomposition.
Internal interfaces and enums are moved to app.organicmaps.sdk package.
Some of the functions are moved to related enum classes. F.e. nativeSetMapStyle is moved to the newly created enum class MapStyle. It's not a final solution but I feel that it's better to keep these methods close to the types during refactoring.

Commit 3 Routing:
Moved routing types from app.organicmaps.routing to app.organicmaps.sdk.routing

Commit 4 Routing part 2:
Moved inner classes/enum into separate class files. F.e. CarDirection, LaneWay, ...
Moved jni creation logic of such type into separate cpp files.
Mark java constructors private for the types that are created only from cpp code.
Remove old-style enum defs via annotations and create separate enum classes. f.e. RouteMarkType.

Each commit can be reviewed (and even merged) separately but in the specified order. The main idea is to move all core-related classes into a separate package - `app.organicmaps.sdk`. Then we make sure that the UI part of the application doesn't use/call native methods directly. For all such cases we need to create separate wrapper classes, f.e. in routing case we'll need `app.organicmaps.sdk.routing.RoutingManager` that will be used by `Routing/NavigationController`. Then we move `app.organicmaps.sdk` package into a separate android module. We'll also have to configure resources for this module - assets, strings, drawables. And the first step is done. After that - more refactorings, improvements and so on. Commit 1 - OrganicMaps class: Let's begin separating the UI from the core. Created `app.organicmaps.sdk` package. Created OrganicMaps class. Moved OM's core-related logic from MwmApplication to OrganicMaps class. Commit 2 Framework class: Framework class decomposition. Internal interfaces and enums are moved to app.organicmaps.sdk package. Some of the functions are moved to related enum classes. F.e. nativeSetMapStyle is moved to the newly created enum class MapStyle. It's not a final solution but I feel that it's better to keep these methods close to the types during refactoring. Commit 3 Routing: Moved routing types from `app.organicmaps.routing` to `app.organicmaps.sdk.routing` Commit 4 Routing part 2: Moved inner classes/enum into separate class files. F.e. `CarDirection`, `LaneWay`, ... Moved jni creation logic of such type into separate cpp files. Mark java constructors private for the types that are created only from cpp code. Remove old-style enum defs via annotations and create separate enum classes. f.e. `RouteMarkType`.

Rows
Columns