Create script that generates `taginfo.json` files #10289

Open

soshial wants to merge 1 commit from soshial/generate-taginfo-json into master

soshial commented

2025-02-19 09:43:22 +00:00

(Migrated from github.com)

This PR creates taginfo.json for each style needed to eventually show Organic Maps supported features in the TagInfo list of OSM projects.

This PR replaces organicmaps/organicmaps#9058.

This PR creates `taginfo.json` for each style needed to eventually show Organic Maps supported features in the [TagInfo list of OSM projects](https://taginfo.openstreetmap.org/projects#projects). This PR replaces https://git.omaps.dev/organicmaps/organicmaps/pulls/9058.

👍 1

RedAuburn reviewed 2025-02-19 16:23:03 +00:00

RedAuburn left a comment

Member

Neat!
a few things:

Why's it in android/scripts? it'd be better to have it in tools IMO. (and run it as part of one of the generation scripts?)
It doesn't handle metadata types like outdoor_seating=yes (defined in the code, not in the styles). IMO it's fine for now, and worth merging anyway as long as we open a new issue for it.
there's a case where metadata is rendered (drinking_water=no), but it's converted from no to not in generator. It probably doesn't matter too much as the proper solution is to fix the generator, but maybe hard-coding an exception would be fine for now

Neat! a few things: 1. Why's it in `android/scripts`? it'd be better to have it in `tools` IMO. (and run it as part of one of the generation scripts?) 2. It doesn't handle metadata types like `outdoor_seating=yes` (defined in the code, not in the styles). IMO it's fine for now, and worth merging anyway as long as we open a new issue for it. 3. there's a case where metadata is rendered (`drinking_water=no`), but it's converted from `no` to `not` in generator. It probably doesn't matter too much as the proper solution is to fix the generator, but maybe hard-coding an exception would be fine for now

data/styles/default/taginfo.json

RedAuburn commented

2025-02-19 16:15:56 +00:00

Member

might need to hardcode removing this? IIRC it's converted to not because the generator can't handle no properly yet.

might need to hardcode removing this? IIRC it's converted to `not` because the generator can't handle `no` properly yet.

soshial (Migrated from github.com) reviewed 2025-02-20 15:34:04 +00:00

data/styles/default/taginfo.json

soshial (Migrated from github.com) commented

2025-02-20 15:34:04 +00:00

Thanks for reviewing the PR, @RedAuburn! I have improved the code a lot and now each JSON contain 6000+ lines and without duplicates.

What is this generator and why cannot it output "no" values instead of "not"?

Thanks for reviewing the PR, @RedAuburn! I have improved the code a lot and now each JSON contain 6000+ lines and without duplicates. What is this generator and why cannot it output "no" values instead of "not"?

This repo is archived. You cannot comment on pull requests.

No reviewers