organicmaps/organicmaps-tmp

Archived

Fork 1

[android] Add home screen widget for favorite bookmarks #10372

Open

coderang-gk wants to merge 3 commits from coderang-gk/feature-homescreen-widget-bookmark into master

coderang-gk commented

2025-03-01 16:03:14 +00:00

(Migrated from github.com)

This PR adds a home screen widget feature that displays a user-selected bookmark and opens directly to that location when tapped.

Key components:

FavoriteBookmarkWidget provider class
Configuration activity for selecting bookmarks
Supporting layouts and drawables
Integration with MwmActivity for handling widget taps

The widget improves user experience by providing one-tap access to frequently used locations without needing to navigate through the app's UI.

Screenshots

Resolves: #3649

# Home Screen Widget Feature This PR adds a home screen widget feature that displays a user-selected bookmark and opens directly to that location when tapped. ## Key components: - FavoriteBookmarkWidget provider class - Configuration activity for selecting bookmarks - Supporting layouts and drawables - Integration with MwmActivity for handling widget taps The widget improves user experience by providing one-tap access to frequently used locations without needing to navigate through the app's UI. ## Screenshots <div align="center"> <table> <tr> <td><img src="https://github.com/user-attachments/assets/c2934062-0ff5-45c1-a51e-e667a15cdc7e" width="200"/></td> <td><img src="https://github.com/user-attachments/assets/30197ab3-02d0-41db-803c-d13a6bae7d1e" width="200"/></td> <td><img src="https://github.com/user-attachments/assets/bee7e171-2929-4e94-8983-65ff0239bd42" width="200"/></td> </tr> <tr> <td><img src="https://github.com/user-attachments/assets/91697bcb-9af6-4d25-919c-c3ec06584c72" width="200"/></td> <td><img src="https://github.com/user-attachments/assets/442af3d7-7781-4707-90a9-3b418ced3966" width="200"/></td> <td><img src="https://github.com/user-attachments/assets/5d9cfed9-869e-4e1d-88e4-c6050679199f" width="200"/></td> </tr> </table> </div> Resolves: #3649

👍 1 🚀 1

strump reviewed 2025-03-01 16:03:14 +00:00

kavikhalique (Migrated from github.com) reviewed 2025-03-01 16:03:14 +00:00

AndrewShkrob reviewed 2025-03-01 16:03:14 +00:00

rtsisyk reviewed 2025-03-01 16:03:14 +00:00

kirylkaveryn reviewed 2025-03-01 16:03:14 +00:00

strump reviewed 2025-03-02 11:29:33 +00:00

android/app/src/main/res/values/strings.xml

strump commented

2025-03-02 11:28:20 +00:00

Member

Please see translation documentation to understand how OrganicMaps handles texts. If you need to introduce new strings to the project then use ‘data/strings/strings.txt’ file

Please see translation [documentation](https://github.com/organicmaps/organicmaps/blob/master/docs/TRANSLATIONS.md) to understand how OrganicMaps handles texts. If you need to introduce new strings to the project then use ‘data/strings/strings.txt’ file

coderang-gk (Migrated from github.com) reviewed 2025-03-02 12:23:56 +00:00

android/app/src/main/res/values/strings.xml

coderang-gk (Migrated from github.com) commented

2025-03-02 12:23:55 +00:00

Sure, I will make changes accordingly.

kavikhalique (Migrated from github.com) requested changes 2025-03-04 18:33:39 +00:00

android/app/src/main/AndroidManifest.xml

kavikhalique (Migrated from github.com) commented

2025-03-04 11:02:03 +00:00

Please format the code as described in docs.

android/app/src/main/java/app/organicmaps/MwmActivity.java

kavikhalique (Migrated from github.com) commented

2025-03-04 11:04:29 +00:00

Curly braces will start from new line, please check https://github.com/organicmaps/organicmaps/blob/master/docs/JAVA_STYLE.md

kirylkaveryn requested changes 2025-03-06 11:17:31 +00:00

android/app/src/main/java/app/organicmaps/MwmActivity.java

kirylkaveryn commented

2025-03-06 10:41:13 +00:00

Member

Why the catch block is empty? At least there should be exception logging.

android/app/src/main/java/app/organicmaps/MwmActivity.java

kirylkaveryn commented

2025-03-06 10:42:03 +00:00

Member

pls remove empty line

android/app/src/main/java/app/organicmaps/bookmarks/data/BookmarkManager.java

kirylkaveryn commented

2025-03-06 11:05:05 +00:00

Member

Why is it necessary to iterate twice by all the categories bookmarks in the whole app?
It looks like a huge overhead with a lot of custom logic for such operation that is equal to single tap on the map.

There are already exist method in the c++ core that finds the bookmark by tap: BuildAndSetPlacePageInfo. You can just create a build info with coords and pass it:

  place_page::BuildInfo info;
  info.m_mercator = mercator::FromLatLon(lat, lon);
  fm.BuildAndSetPlacePageInfo(info);

Please use the core c++ API to work with the bookmarks.

Why is it necessary to iterate **twice** by all the categories bookmarks in the whole app? It looks like a huge overhead with a lot of custom logic for such operation that is equal to single tap on the map. There are already exist method in the c++ core that finds the bookmark by tap: `BuildAndSetPlacePageInfo`. You can just create a build info with coords and pass it: ``` place_page::BuildInfo info; info.m_mercator = mercator::FromLatLon(lat, lon); fm.BuildAndSetPlacePageInfo(info); ``` Please use the core c++ API to work with the bookmarks.

kirylkaveryn commented

2025-03-06 11:06:43 +00:00

Member

Can you explain why there are 2 iterations over the categories?

kirylkaveryn commented

2025-03-06 11:15:23 +00:00

Member

All this logic is already implemented in the
d7db7df723/geometry/distance_on_sphere.cpp (L10-L23)

There should not be duplications. Please check how the android app works with the core.

All this logic is already implemented in the https://github.com/organicmaps/organicmaps/blob/d7db7df72373f31463e0c355a9baeb51b8bee4f1/geometry/distance_on_sphere.cpp#L10-L23 There should not be duplications. Please check how the android app works with the core.

kirylkaveryn commented

2025-03-06 11:17:16 +00:00

Member

I assume that instead of 5 method with almost the same signature, there should only be the one that trigger the core method, which is already implemented. It finds the bookmark and opens the place page.

This repo is archived. You cannot comment on pull requests.

No reviewers

strump

kavikhalique

AndrewShkrob

rtsisyk

kirylkaveryn