[ios] Fix new search screen bugs #10476

Open

kirylkaveryn wants to merge 3 commits from ios/search-fix-to-child-vc into master

kirylkaveryn commented

2025-03-12 11:54:22 +00:00

Member

Closes organicmaps/organicmaps#10451

This PR fixes 3 bugs:

UI blocking issue when the user tries to edit the poi/bookmark selected from the search results.
The previous solution used UIPresentationController for the modal display. This implementation was bad because the native modal presentation adds a transparent view (UITransitionView) to the background that blocks the underlying UI elements. This behavior cannot be fixed because the background view is a private API.
We use for such purposes TouchTransparentView that sends events to the underlying elements. But with UIPresentationController we cannot replace the background.
This buggy implementation was replaced with the custom child view controller with animations using the TouchTransparentView.
Pasting the coordinates to the search field will display the result instead of immediately displaying map.
Should fix Exception on the iPad with the ios12.5
The exception was raised by the NSLayoutConstrait when the priority is changed after constraint activation. All of the constraints set up should be done before activation.

Results:
Fix 1:

Selection the Layers is also working:

Fix 2:

Closes https://git.omaps.dev/organicmaps/organicmaps/issues/10451 This PR fixes 3 bugs: 1. **UI blocking** issue when the user tries to edit the poi/bookmark selected from the search results. The previous solution used `UIPresentationController` for the modal display. This implementation was bad because the native modal presentation adds a transparent view (UITransitionView) to the background that blocks the underlying UI elements. This behavior cannot be fixed because the background view is a private API. We use for such purposes `TouchTransparentView` that sends events to the underlying elements. But with `UIPresentationController` we cannot replace the background. This buggy implementation was replaced with the custom child view controller with animations using the `TouchTransparentView`. 2. **Pasting the coordinates to the search** field will display the result instead of immediately displaying map. 3. Should fix **Exception** on the iPad with the **ios12.5** The exception was raised by the NSLayoutConstrait when the priority is changed after constraint activation. All of the constraints set up should be done **before** activation. Results: Fix 1: ![Simulator Screen Recording - iPhone 16 Pro - 2025-03-12 at 15 48 11](https://github.com/user-attachments/assets/4fa4ee14-b542-412e-a006-619d6eae2714) ![Simulator Screen Recording - iPhone 16 Pro - 2025-03-12 at 15 48 39](https://github.com/user-attachments/assets/bd33c0ba-4a6e-453f-85cd-c0f40f2486ec) ![Simulator Screen Recording - iPad mini (6th generation) - 2025-03-12 at 15 45 45](https://github.com/user-attachments/assets/6f010d50-9c01-4ef4-8c99-b5f282ef28e6) ![Simulator Screen Recording - iPhone 16 Pro - 2025-03-12 at 15 52 36](https://github.com/user-attachments/assets/87a339da-41e1-4a8e-8f83-12b12b8d6694) Selection the Layers is also working: ![Simulator Screen Recording - iPhone 16 Pro - 2025-03-12 at 15 52 21](https://github.com/user-attachments/assets/26a70ae9-0f30-48cd-9910-82bb69540145) Fix 2: ![Simulator Screen Recording - iPhone 16 Pro - 2025-03-12 at 15 49 51](https://github.com/user-attachments/assets/d42307f5-8fc0-45d0-807d-24866231d1e2)

This repo is archived. You cannot comment on pull requests.

No reviewers