[android] Fixed RTL zoom buttons covered by Search and Bookmarks in Routing mode #2307

Merged

biodranik merged 1 commit from android/fix-search-bookmarks-rtl into master 2022-03-29 22:18:02 +00:00

Conversation 4 Commits 1 Files changed 3 +3

biodranik commented 2022-03-28 19:28:17 +00:00 (Migrated from github.com)

Copy link

Надо протестить, фиксил без теста.

Надо протестить, фиксил без теста.

pastk requested changes 2022-03-29 11:51:04 +00:00

pastk left a comment

Owner

Хм, ты пофиксил в ландшафтной компоновке по ошибке?

Там получается так:

Если фикс убрать, то так (компас и кнопка слоёв накладываются):

Твой предыдущий фикс для компаса был только для портретки, может?

Если добавить фикс (layoutDirection="ltr") в портретку, то в ней всё хорошо выглядит:

Тестил только на эмуле 5.0 пока.

Хм, ты пофиксил в ландшафтной компоновке по ошибке? Там получается так:  Если фикс убрать, то так (компас и кнопка слоёв накладываются):  Твой предыдущий фикс для компаса был только для портретки, может? Если добавить фикс (`layoutDirection="ltr"`) в портретку, то в ней всё хорошо выглядит:  Тестил только на эмуле 5.0 пока.

biodranik commented 2022-03-29 12:27:46 +00:00 (Migrated from github.com)

Copy link

Спасибо! Пофиксил. Надо будет вообще эти плавающие кнопки переделать по-другому.

Спасибо! Пофиксил. Надо будет вообще эти плавающие кнопки переделать по-другому.

pastk approved these changes 2022-03-29 17:37:11 +00:00

pastk left a comment

Owner

Now portrait mode is fixed.

And the landscape mode looks good too except that in nav mode the next turn sign covers zoom buttons partly - dependent on screen size / resolution.
However if it was in left upper corner (as it is LTR layouts) then it would cover the layers button.

Now portrait mode is fixed. And the landscape mode looks good too except that in nav mode the next turn sign covers zoom buttons partly - dependent on screen size / resolution. However if it was in left upper corner (as it is LTR layouts) then it would cover the layers button. 

biodranik commented 2022-03-29 22:17:44 +00:00 (Migrated from github.com)

Copy link

All these cases obviously need UI redesign. Let's create an issue for that.

All these cases obviously need UI redesign. Let's create an issue for that.

pastk commented 2022-03-30 11:14:56 +00:00

Owner

Copy link

In the meantime maybe the next turn sign should be moved to the left as well?

In the meantime maybe the next turn sign should be moved to the left as well?

biodranik commented 2022-03-30 13:20:19 +00:00 (Migrated from github.com)

Copy link

You can try it.

You can try it.

This repo is archived. You cannot comment on pull requests.

Reviewers

No reviewers

pastk

Labels

Clear labels   

Accessibility

issues affecting users with specific needs

  

Accessibility

issues affecting users with specific needs

  

Address

Issues with addresses, post codes, city/town/village borders

  

Address

Issues with addresses, post codes, city/town/village borders

  

Android

Android development

  

Android

Android development

  

Android Auto

Android Auto

  

Android Auto

Android Auto

  

Android Automotive (AAOS)

  

Android Automotive (AAOS)

  

API

Short Links, deep links and url schemes, including ge0 and om://

  

API

Short Links, deep links and url schemes, including ge0 and om://

  

AppGallery

Huawei AppGallery

  

AppGallery

Huawei AppGallery

  

AppStore

Apple AppStore

  

AppStore

Apple AppStore

  

Battery and Performance

Performance and battery consumption-related issues and optimizations

  

Battery and Performance

Performance and battery consumption-related issues and optimizations

  

Blocker

An issue blocking the release

  

Blocker

An issue blocking the release

  

Bookmarks and Tracks

Bookmarks, imported tracks, and KML, KMZ, KMB, GPX, GPZ import or export

  

Bookmarks and Tracks

Bookmarks, imported tracks, and KML, KMZ, KMB, GPX, GPZ import or export

  

Borders

Country borders and polygons

  

Borders

Country borders and polygons

  

Bug

Something isn't working

  

Bug

Something isn't working

  

Build

Compilation issue

  

Build

Compilation issue

  

CarPlay

CarPlay Integration

  

CarPlay

CarPlay Integration

  

Classificator

Classify object by types

  

Classificator

Classify object by types

  

Community

Community relations

  

Community

Community relations

  

Core

Cross-platform C++ libraries with a core functionality

  

Core

Cross-platform C++ libraries with a core functionality

  

CrashReports

Crash Reporting

  

CrashReports

Crash Reporting

  

Cycling

Bike, cycle, biking and related

  

Cycling

Bike, cycle, biking and related

  

Desktop

Desktop application

  

Desktop

Desktop application

  

DevEx

Developer Experience

  

DevEx

Developer Experience

  

DevOps

Automation and pipelines

  

DevOps

Automation and pipelines

  

dev_sandbox

A desktop app to debug rendering

  

dev_sandbox

A desktop app to debug rendering

  

Directions

Issues with next turns, labels, streets, voice instructions

  

Directions

Issues with next turns, labels, streets, voice instructions

  

Documentation

Improvements or additions to documentation

  

Documentation

Improvements or additions to documentation

  

Downloader

Map dowloader

  

Downloader

Map dowloader

  

Drape

Drape OpenGL, Vulkan and Metal graphics rendering engine

  

Drape

Drape OpenGL, Vulkan and Metal graphics rendering engine

  

Driving

Drive a car related issues

  

Driving

Drive a car related issues

  

Duplicate

This issue or pull request already exists

  

Duplicate

This issue or pull request already exists

  

Editor

OSM Editor

  

Editor

OSM Editor

  

Elevation

Isolines and altitude

  

Elevation

Isolines and altitude

  

Enhancement

New feature or request, an improvement of some existing feature

  

Enhancement

New feature or request, an improvement of some existing feature

  

Epic

A large body work

  

Epic

A large body work

  

External Map Datasets

TIGER, Ordnance Survey, ASTER, SRTM, etc.

  

External Map Datasets

TIGER, Ordnance Survey, ASTER, SRTM, etc.

  

F-Droid

F-Droid build and distribution

  

F-Droid

F-Droid build and distribution

  

Fonts

Font and text rendering

  

Fonts

Font and text rendering

  

Frequently User Reported

Most annoying UX and other issues for users reported by many people

  

Frequently User Reported

Most annoying UX and other issues for users reported by many people

  

Fund

  

Fund

  

Generator

Related to generator tool.

  

Generator

Related to generator tool.

  

Good first issue

Good for newcomers

  

Good first issue

Good for newcomers

  

Google Play

Google Play

  

Google Play

Google Play

  

GPS

Location and positioning issues

  

GPS

Location and positioning issues

  

GSoC

Ideas for Google Summer of Code

  

GSoC

Ideas for Google Summer of Code

  

iCloud

  

iCloud

  

Icons

Map and app icons

  

Icons

Map and app icons

  

iOS

iOS development

  

iOS

iOS development

  

Legal

Legal aspects

  

Legal

Legal aspects

  

Linux Desktop

Ubuntu, Gentoo, Red Hat, Debian, Cent OS, Fedora, etc.

  

Linux Desktop

Ubuntu, Gentoo, Red Hat, Debian, Cent OS, Fedora, etc.

  

Linux packaging

  

Linux packaging

  

Linux Phone

LibreM, PinePhone, Wayland and other mobile Linux versions

  

Linux Phone

LibreM, PinePhone, Wayland and other mobile Linux versions

  

Mac OS

Desktop issues related to Mac OS X, OM running on M1, M2, M3 Apple silicon, or Qt version

  

Mac OS

Desktop issues related to Mac OS X, OM running on M1, M2, M3 Apple silicon, or Qt version

  

Map Data

OpenStreetMap data related issues

  

Map Data

OpenStreetMap data related issues

  

Metro

Subway, Tube, light-rail public transport issues

  

Metro

Subway, Tube, light-rail public transport issues

  

Navigation

Issues related to the active Navigator / Navigation mode

  

Navigation

Issues related to the active Navigator / Navigation mode

  

Need Feedback

Further information is requested

  

Need Feedback

Further information is requested

  

Night Mode

Night or dark mode feature

  

Night Mode

Night or dark mode feature

  

NLnet 2024-06-281

Tasks related to NLnet 2024-06-281 project.

  

NLnet 2024-06-281

Tasks related to NLnet 2024-06-281 project.

  

No Feature Parity

A platform needs this to be implemented to have feature parity with other platforms

  

No Feature Parity

A platform needs this to be implemented to have feature parity with other platforms

  

Opening Hours

Business Hours, off time, holidays, seasonal

  

Opening Hours

Business Hours, off time, holidays, seasonal

  

Outdoors

Hiking, mtb, 4x4...

  

Outdoors

Hiking, mtb, 4x4...

  

POI Info

Feature metadata, OSM tags that are displayed in Place Page

  

POI Info

Feature metadata, OSM tags that are displayed in Place Page

  

Privacy

Privacy

  

Privacy

Privacy

  

Public Transport

Bus, trolleybus, train, tram, metro, subway, light rail

  

Public Transport

Bus, trolleybus, train, tram, metro, subway, light rail

  

Raw Idea

An idea that needs to be elaborated

  

Raw Idea

An idea that needs to be elaborated

  

Refactoring

  

Refactoring

  

Regional

This issue is different depending on the country or region

  

Regional

This issue is different depending on the country or region

  

Regression

A regression bug

  

Regression

A regression bug

  

Releases

Meta-tickets for tracking the release procedure

  

Releases

Meta-tickets for tracking the release procedure

  

RoboTest

Robo / Monkey Auto Tests

  

RoboTest

Robo / Monkey Auto Tests

  

Route Planning

Preview and plan your track

  

Route Planning

Preview and plan your track

  

Routing

Route building issues, e.g. valid route, valid ETA

  

Routing

Route building issues, e.g. valid route, valid ETA

  

Ruler

Helicopter routing, "as a crow flies"

  

Ruler

Helicopter routing, "as a crow flies"

  

Search

Search

  

Search

Search

  

Security

Security improvements

  

Security

Security improvements

  

Styles

Map drawing styles

  

Styles

Map drawing styles

  

Tests

  

Tests

  

Track Recording

Track Recording

  

Track Recording

Track Recording

  

Translations

Localization and translations issues

  

Translations

Localization and translations issues

  

TTS

Text-to-Speech

  

TTS

Text-to-Speech

  

UI

User interface issues

  

UI

User interface issues

  

UX

User eXperience, an issue with usability

  

UX

User eXperience, an issue with usability

  

Walk Navigation

Foot pedestrian mode

  

Walk Navigation

Foot pedestrian mode

  

Watches

Android Watches or Apple Watches support

  

Watches

Android Watches or Apple Watches support

  

Web

https://organicmaps.app/

  

Web

https://organicmaps.app/

  

Wikipedia

Issues related to Wiki articles embedded in OM data files.

  

Wikipedia

Issues related to Wiki articles embedded in OM data files.

  

Windows

Windows

  

Windows

Windows

  

Won't fix

Unfeasible or impossible to resolve

  

Won't fix

Unfeasible or impossible to resolve

  

World Map

Issues about improving the base map of the whole world that is bundled with the app

  

World Map

Issues about improving the base map of the whole world that is bundled with the app

No labels

Accessibility

Accessibility

Address

Address

Android

Android

Android Auto

Android Auto

Android Automotive (AAOS)

Android Automotive (AAOS)

API

API

AppGallery

AppGallery

AppStore

AppStore

Battery and Performance

Battery and Performance

Blocker

Blocker

Bookmarks and Tracks

Bookmarks and Tracks

Borders

Borders

Bug

Bug

Build

Build

CarPlay

CarPlay

Classificator

Classificator

Community

Community

Core

Core

CrashReports

CrashReports

Cycling

Cycling

Desktop

Desktop

DevEx

DevEx

DevOps

DevOps

dev_sandbox

dev_sandbox

Directions

Directions

Documentation

Documentation

Downloader

Downloader

Drape

Drape

Driving

Driving

Duplicate

Duplicate

Editor

Editor

Elevation

Elevation

Enhancement

Enhancement

Epic

Epic

External Map Datasets

External Map Datasets

F-Droid

F-Droid

Fonts

Fonts

Frequently User Reported

Frequently User Reported

Fund

Fund

Generator

Generator

Good first issue

Good first issue

Google Play

Google Play

GPS

GPS

GSoC

GSoC

iCloud

iCloud

Icons

Icons

iOS

iOS

Legal

Legal

Linux Desktop

Linux Desktop

Linux packaging

Linux packaging

Linux Phone

Linux Phone

Mac OS

Mac OS

Map Data

Map Data

Metro

Metro

Navigation

Navigation

Need Feedback

Need Feedback

Night Mode

Night Mode

NLnet 2024-06-281

NLnet 2024-06-281

No Feature Parity

No Feature Parity

Opening Hours

Opening Hours

Outdoors

Outdoors

POI Info

POI Info

Privacy

Privacy

Public Transport

Public Transport

Raw Idea

Raw Idea

Refactoring

Refactoring

Regional

Regional

Regression

Regression

Releases

Releases

RoboTest

RoboTest

Route Planning

Route Planning

Routing

Routing

Ruler

Ruler

Search

Search

Security

Security

Styles

Styles

Tests

Tests

Track Recording

Track Recording

Translations

Translations

TTS

TTS

UI

UI

UX

UX

Walk Navigation

Walk Navigation

Watches

Watches

Web

Web

Wikipedia

Wikipedia

Windows

Windows

Won't fix

Won't fix

World Map

World Map

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#2307

No description provided.