[Routing] Fixes: #2422 + GetTurnDirection() refactoring #2427

Merged
AntonM030481 merged 9 commits from navigation-turn-directions-2422 into master 2022-04-22 08:46:20 +00:00

9 commits

Author SHA1 Message Date
Anton Makouski
c2bbe51418 [Routing] Refactoring
Comments

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-04-21 22:18:31 +03:00
Anton Makouski
6f529ad728 [Routing] Refactoring
Tests update

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-04-21 18:55:39 +03:00
Anton Makouski
58e233bc5d [Routing] Refactoring
Tests update

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-04-21 16:38:11 +03:00
Anton Makouski
d6f42ac795 [Routing] Refactoring
Added logic for routes which go straight and don't go to a smaller road.

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-04-21 16:22:00 +03:00
Anton Makouski
d4337fd060 [Routing] Refactoring
Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-04-21 14:06:21 +03:00
Anton Makouski
2c085b2c1a [Routing] Refactoring
DiscardTurnByIngoingAndOutgoingEdges() removed as absolete.

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-04-21 12:46:08 +03:00
Anton Makouski
f30dfd471e [Routing] Refactoring
It was checked trough debugging that
there are no significant changes.

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-04-21 12:26:00 +03:00
Anton Makouski
ddb2bbfd36 [Routing] coding standard
Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-04-20 18:45:56 +03:00
Anton Makouski
adfa27a6e8 [Routing] Fixes: #2422 + refactoring
Currently GetTurnDirection() is overcomplicated.
This is an attempt to make is more straightforward.
Also some bugs were found and fixed.
nodes.candidates was used in many cases
where uturn had to be excluded.
The issue #2422 was expected to be handled even twice:
- Removing a slight turn if ingoing and outgoing edges
are not links and all other possible ways out are links.
- Usage of RightmostDirection() if
the route goes along the rightmost candidate.

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-04-20 16:09:40 +03:00