[Navigation] Refactoring of CarDirectionsEngine and PedestrianDirectionsEngine #2547

Merged
AntonM030481 merged 11 commits from navigation-refactoring into master 2022-05-16 16:29:59 +00:00

11 commits

Author SHA1 Message Date
Anton Makouski
05d857163b [Routing] Refactoring
Small fixes for review.

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-05-16 16:24:28 +03:00
Anton Makouski
525b03154b [Routing] Fix of rare cases
Better handling of nodes.isCandidatesAngleValid == false
from IRoutingResult::GetPossibleTurns() in GetTurnDirection().

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-05-16 11:17:34 +03:00
Anton Makouski
be8f4e064e
Merge branch 'master' into navigation-refactoring 2022-05-16 10:56:50 +03:00
Anton Makouski
1d660547d7 [Routing] Refactoring
Code style.

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-05-13 15:45:16 +03:00
Anton Makouski
1b998cd35b [Routing] Refactoring
Almost identical Generate()
from CarDirectionsEngine and PedestrianDirectionsEngine
moved to parent class.

MakeTurnAnnotation() - became method of DirectionsEngine.

All VehicleType dependent logic was incapsulated in virtual methods:
- GetTurnDirection()
- FixupTurns().

According existing functions became methods of
CarDirectionsEngine and PedestrianDirectionsEngine.

VehicleType dependent functions moved
from turns_generator to according DirectionsEngines.

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-05-13 12:41:33 +03:00
Anton Makouski
083a5f264e [Routing] Refactoring
Comments.

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-05-12 18:27:20 +03:00
Anton Makouski
c363cde673 [Routing] Refactoring
Merge of MakeTurnAnnotation and MakeTurnAnnotationPedestrian.
Part 3. Fix of missed "else".

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-05-12 18:14:19 +03:00
Anton Makouski
66e5af0855 [Routing] Refactoring
Merge of MakeTurnAnnotation and MakeTurnAnnotationPedestrian.
Part 2. Remove MakeTurnAnnotationPedestrian.

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-05-12 13:07:17 +03:00
Anton Makouski
de4b68c3e5 [Routing] Refactoring
Merge of MakeTurnAnnotation and MakeTurnAnnotationPedestrian.
Part 1. Make them the same, but hold different names.
Line by line comparisong can be seen here.

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-05-12 12:46:45 +03:00
Anton Makouski
be70c20043 [Routing] Refactoring
Pedestrian turn tests - check RouteLength first.

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-05-12 11:41:01 +03:00
Anton Makouski
2e942abe9a [Routing] Refactoring
Renamed pedestrian turn tests.

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-05-12 11:39:43 +03:00