organicmaps/organicmaps-tmp

Archived

Fork 1

Add missing string amenity.events_venue #2872 #2932

Merged

csidirop merged 3 commits from master into master

2022-07-08 07:04:29 +00:00

csidirop commented

2022-07-06 15:56:33 +00:00

(Migrated from github.com)

Added missing strings for amenity.events_venue like asked in issue #2872 .

Not sure if I insert it correctly, but I added english, german and greek translations.

Signed-off-by: Christos Sidiropoulos csidirop@runbox.com

Added missing strings for amenity.events_venue like asked in issue #2872 . Not sure if I insert it correctly, but I added english, german and greek translations. Signed-off-by: Christos Sidiropoulos csidirop@runbox.com

csidirop commented

2022-07-06 16:02:03 +00:00

(Migrated from github.com)

I have no idea why DCO failed again. In case I don't forget, i'll commit with -s through cli instead VS Code git integration next time.

j13m126 commented

2022-07-06 21:10:20 +00:00

(Migrated from github.com)

The language code for greek is 'el' not 'gr'.

while you're at it, would you mind adding the other languages as well?
EDIT: I replaced search term 'Event Venue' with 'Events Venue' using Deepl where possible. Also added pt-BR (was identical in singular)

en = Events Venue
ar = مكان الأحداث
be = Месца правядзення мерапрыемстваў
bg = Място за провеждане на събития
cs = Místo konání akcí
da = Sted for arrangementer
de = Veranstaltungszentrum
el = Κέντρο εκδηλώσεων
es = Lugar de los eventos
eu = Ekitaldien Lekua
fa = محل برگزاری رویدادها
fi = Tapahtumapaikka
fr = Lieu des événements
he = מקום אירועים 
hu = Rendezvények helyszíne
id = Tempat acara
it = Sede degli eventi
ja = イベント会場
ko = 행사장
mr = कार्यक्रमाचे ठिकाण
nb = Arrangementssted
nl = Evenementenlocatie
pl = Miejsce wydarzeń
pt = Local dos eventos
pt-BR = Local do evento
ro = Locul de desfășurare a evenimentelor
ru = Место проведения мероприятий
sk = Miesto konania podujatí
sv = Evenemangslokal
sw = Ukumbi wa Matukio
th = สถานที่จัดงาน
tr = Etkinlik mekanı
uk = Місце проведення подій
vi = Địa điểm tổ chức sự kiện
zh-Hans = 活动场所
zh-Hant = 活動場所

and for categories.txt:

en:Events Venue
ar:مكان الأحداث
be:Месца правядзення мерапрыемстваў
bg:Място за провеждане на събития
cs:Místo konání akcí
da:Sted for arrangementer
de:Veranstaltungszentrum
el:Κέντρο εκδηλώσεων
es:Lugar de los eventos
eu:Ekitaldien Lekua
fa:محل برگزاری رویدادها
fi:Tapahtumapaikka
fr:Lieu des événements
he:מקום אירועים 
hu:Rendezvények helyszíne
id:Tempat acara
it:Sede degli eventi
ja:イベント会場
ko:행사장
mr:कार्यक्रमाचे ठिकाण
nb:Arrangementssted
nl:Evenementenlocatie
pl:Miejsce wydarzeń
pt:Local dos eventos
pt-BR:Local do evento
ro:Locul de desfășurare a evenimentelor
ru:Место проведения мероприятий
sk:Miesto konania podujatí
sv:Evenemangslokal
sw:Ukumbi wa Matukio
th:สถานที่จัดงาน
tr:Etkinlik mekanı
uk:Місце проведення подій
vi:Địa điểm tổ chức sự kiện
zh-Hans:活动场所
zh-Hant:活動場所

Thanks :)

The language code for greek is 'el' not 'gr'. while you're at it, would you mind adding the other languages as well? EDIT: I replaced search term 'Event Venue' with 'Events Venue' using Deepl where possible. Also added pt-BR (was identical in singular) en = Events Venue ar = مكان الأحداث be = Месца правядзення мерапрыемстваў bg = Място за провеждане на събития cs = Místo konání akcí da = Sted for arrangementer de = Veranstaltungszentrum el = Κέντρο εκδηλώσεων es = Lugar de los eventos eu = Ekitaldien Lekua fa = محل برگزاری رویدادها fi = Tapahtumapaikka fr = Lieu des événements he = מקום אירועים hu = Rendezvények helyszíne id = Tempat acara it = Sede degli eventi ja = イベント会場 ko = 행사장 mr = कार्यक्रमाचे ठिकाण nb = Arrangementssted nl = Evenementenlocatie pl = Miejsce wydarzeń pt = Local dos eventos pt-BR = Local do evento ro = Locul de desfășurare a evenimentelor ru = Место проведения мероприятий sk = Miesto konania podujatí sv = Evenemangslokal sw = Ukumbi wa Matukio th = สถานที่จัดงาน tr = Etkinlik mekanı uk = Місце проведення подій vi = Địa điểm tổ chức sự kiện zh-Hans = 活动场所 zh-Hant = 活動場所 and for `categories.txt`: en:Events Venue ar:مكان الأحداث be:Месца правядзення мерапрыемстваў bg:Място за провеждане на събития cs:Místo konání akcí da:Sted for arrangementer de:Veranstaltungszentrum el:Κέντρο εκδηλώσεων es:Lugar de los eventos eu:Ekitaldien Lekua fa:محل برگزاری رویدادها fi:Tapahtumapaikka fr:Lieu des événements he:מקום אירועים hu:Rendezvények helyszíne id:Tempat acara it:Sede degli eventi ja:イベント会場 ko:행사장 mr:कार्यक्रमाचे ठिकाण nb:Arrangementssted nl:Evenementenlocatie pl:Miejsce wydarzeń pt:Local dos eventos pt-BR:Local do evento ro:Locul de desfășurare a evenimentelor ru:Место проведения мероприятий sk:Miesto konania podujatí sv:Evenemangslokal sw:Ukumbi wa Matukio th:สถานที่จัดงาน tr:Etkinlik mekanı uk:Місце проведення подій vi:Địa điểm tổ chức sự kiện zh-Hans:活动场所 zh-Hant:活動場所 Thanks :)

👍 1

biodranik commented

2022-07-06 21:16:15 +00:00

(Migrated from github.com)

en:Events Venue
ar:ﺙﺍﺪﺣﻷﺍ ﻥﺎﻜﻣ
be:Месца правядзення мерапрыемстваў
bg:Място на провеждане на събития
cs:Místo konání akcí
da:Arrangementssted
de:Veranstaltungsort
el:Χώρος Διεξαγωγής Εκδηλώσεων
es:Lugar de eventos
eu:Ekitaldien Lekua
fa:ﺎﻫﺩﺍﺪﯾﻭﺭ ﯼﺭﺍﺰﮔﺮﺑ ﻞﺤﻣ
fi:Tapahtumapaikka
fr:Lieu d'événements
he:םיעוריא םוקמ
hu:Rendezvények helyszíne
id:Tempat Acara
it:Sede degli eventi
ja:イベント会場
ko:"행사장"
nb:Arrangementssted
nl:Evenementenlocatie
pl:Miejsce wydarzeń
pt:Local de eventos
pt-BR:Local de eventos
ro:Locul evenimentelor
ru:Место проведения мероприятий
sk:Miesto konania podujatí
sv:Evenemangsplats
sw:Ukumbi wa Matukio
th:สถานที่จัดงาน
tr:Etkinlik Mekanı
uk:Місце проведення подій
vi:Địa điểm tổ chức sự kiện
zh-Hans:活动场地
zh-Hant:活動場地

Better translations are generated with "Events Venue" instead of "Event Venue". Also, if you have time, please try to double-check them with DeepL, it has better results, plus it has a proper support for pt and pt-BR: ``` en:Events Venue ar:ﺙﺍﺪﺣﻷﺍ ﻥﺎﻜﻣ be:Месца правядзення мерапрыемстваў bg:Място на провеждане на събития cs:Místo konání akcí da:Arrangementssted de:Veranstaltungsort el:Χώρος Διεξαγωγής Εκδηλώσεων es:Lugar de eventos eu:Ekitaldien Lekua fa:ﺎﻫﺩﺍﺪﯾﻭﺭ ﯼﺭﺍﺰﮔﺮﺑ ﻞﺤﻣ fi:Tapahtumapaikka fr:Lieu d'événements he:םיעוריא םוקמ hu:Rendezvények helyszíne id:Tempat Acara it:Sede degli eventi ja:イベント会場 ko:"행사장" nb:Arrangementssted nl:Evenementenlocatie pl:Miejsce wydarzeń pt:Local de eventos pt-BR:Local de eventos ro:Locul evenimentelor ru:Место проведения мероприятий sk:Miesto konania podujatí sv:Evenemangsplats sw:Ukumbi wa Matukio th:สถานที่จัดงาน tr:Etkinlik Mekanı uk:Місце проведення подій vi:Địa điểm tổ chức sự kiện zh-Hans:活动场地 zh-Hant:活動場地 ```

👍 2

j13m126 commented

2022-07-06 21:43:01 +00:00

(Migrated from github.com)

I updated the translations above

csidirop commented

2022-07-07 07:10:54 +00:00

(Migrated from github.com)

DCO check is still failing after letting git sign the commit with -s. Do you have any idea why this is the case?

csidirop commented

2022-07-07 07:11:55 +00:00

(Migrated from github.com)

I updated the translations above

And I updated my commits with your corrections. Thanks! Anything more?

> I updated the translations above And I updated my commits with your corrections. Thanks! Anything more?

biodranik commented

2022-07-07 21:35:31 +00:00

(Migrated from github.com)

I think DCO fails because this commit doesn't have <> in the email: organicmaps/organicmaps#2932/commits/96e70d9f8be2ef5ca4fd2145a45ff36146ce69fb
AUTHOR should also match with commit's one. It is possible to edit commits and modify their messages and author, but it's better to make a backup branch before doing it.

I think DCO fails because this commit doesn't have `<>` in the email: https://git.omaps.dev/organicmaps/organicmaps/pulls/2932/commits/96e70d9f8be2ef5ca4fd2145a45ff36146ce69fb AUTHOR should also match with commit's one. It is possible to edit commits and modify their messages and author, but it's better to make a backup branch before doing it.

👍 1

biodranik (Migrated from github.com) approved these changes 2022-07-08 07:04:13 +00:00

biodranik (Migrated from github.com) left a comment

The search can be improved by adding synonyms and a number of letters to hint after. But let's merge it first.

This repo is archived. You cannot comment on pull requests.

No reviewers

biodranik