3party/opening_hours/rules_evaluation.cpp

@@ -2,8 +2,10 @@
 #include "rules_evaluation_private.hpp"
 
 #include <algorithm>
+#include <cstdlib>
 #include <ctime>
 #include <iomanip>
+#include <iostream>
 #include <sstream>
 #include <tuple>
 
@@ -110,6 +112,9 @@ osmoh::RuleState ModifierToRuleState(osmoh::RuleSequence::Modifier const modifie
     case Modifier::Comment:
       return osmoh::RuleState::Unknown;
   }
+  std::cerr << "Unreachable\n";
+  std::abort();
+  return osmoh::RuleState::Unknown;
 }
 
 // Transform timspan with extended end of the form of

generator/generator_tests/collector_building_parts_tests.cpp

@@ -30,7 +30,7 @@ public:
   }
 
   // OSMElementCacheReaderInterface overrides:
-  bool Read(generator::cache::Key /* id */, WayElement & /* value */) override {
+  [[noreturn]] bool Read(generator::cache::Key /* id */, WayElement & /* value */) override {
     CHECK(false, ("Should not be called"));
   }
 

generator/generator_tests/relation_tags_tests.cpp

@@ -22,7 +22,7 @@ public:
   }
 
   // OSMElementCacheReaderInterface overrides:
-  bool Read(Key /* id */, WayElement & /* value */) override {
+  [[noreturn]] bool Read(Key /* id */, WayElement & /* value */) override {
     CHECK(false, ("Should not be called"));
   }
 

geometry/clipping.cpp

@@ -207,6 +207,8 @@ vector<m2::SharedSpline> ClipSplineByRect(m2::RectD const & rect, m2::SharedSpli
   case RectCase::Outside: return {};
   case RectCase::Intersect: return ClipPathByRectImpl(rect, spline->GetPath());
   }
+  CHECK(false, ("Unreachable"));
+  return {};
 }
 
 std::vector<m2::SharedSpline> ClipPathByRect(m2::RectD const & rect,
@@ -218,6 +220,8 @@ std::vector<m2::SharedSpline> ClipPathByRect(m2::RectD const & rect,
   case RectCase::Outside: return {};
   case RectCase::Intersect: return ClipPathByRectImpl(rect, path);
   }
+  CHECK(false, ("Unreachable"));
+  return {};
 }
 
 void ClipPathByRectBeforeSmooth(m2::RectD const & rect, std::vector<m2::PointD> const & path,

routing/cross_mwm_graph.cpp

@@ -210,6 +210,8 @@ CrossMwmGraph::MwmStatus CrossMwmGraph::GetMwmStatus(NumMwmId numMwmId, string c
   case MwmDataSource::SectionExists: return MwmStatus::SectionExists;
   case MwmDataSource::NoSection: return MwmStatus::NoSection;
   }
+  CHECK(false, ("Unreachable"));
+  return MwmStatus::NoSection;
 }
 
 CrossMwmGraph::MwmStatus CrossMwmGraph::GetCrossMwmStatus(NumMwmId numMwmId) const

routing/fake_vertex.hpp

@@ -71,5 +71,7 @@ inline std::string DebugPrint(FakeVertex::Type type)
   case FakeVertex::Type::PureFake: return "PureFake";
   case FakeVertex::Type::PartOfReal: return "PartOfReal";
   }
+  CHECK(false, ("Unreachable"));
+  return "UnknownFakeVertexType";
 }
 }  // namespace routing