[android] Minor search wheel clean up #3349

2022-09-05T07:40:49Z

arnaudvergnet commented

2022-09-05 07:40:49 +00:00

(Migrated from github.com)

Minor refactoring following organicmaps/organicmaps#2905

Minor refactoring following https://git.omaps.dev/organicmaps/organicmaps/pulls/2905#discussion_r962525996

vng (Migrated from github.com) reviewed 2022-09-05 07:49:38 +00:00

android/src/com/mapswithme/maps/maplayer/SearchWheel.java

					
				@ -122,40 +114,39 @@ public class SearchWheel implements View.OnClickListener

				    refreshSearchVisibility();

vng (Migrated from github.com) commented

2022-09-05 07:49:37 +00:00

mSearchLayout != null is not needed here and below. All checks should be done in initSearchLayout

arnaudvergnet (Migrated from github.com) reviewed 2022-09-05 08:03:34 +00:00

android/src/com/mapswithme/maps/maplayer/SearchWheel.java

					
				@ -122,40 +114,39 @@ public class SearchWheel implements View.OnClickListener

				    refreshSearchVisibility();

arnaudvergnet (Migrated from github.com) commented

2022-09-05 08:03:34 +00:00

If I omit the mSearchLayout != null check Android studio will show a warning each time I use mSearchLayout telling it could be null.

If I omit the `mSearchLayout != null` check Android studio will show a warning each time I use `mSearchLayout` telling it could be null.

arnaudvergnet (Migrated from github.com) reviewed 2022-09-05 08:12:49 +00:00

android/src/com/mapswithme/maps/maplayer/SearchWheel.java

					
				@ -122,40 +114,39 @@ public class SearchWheel implements View.OnClickListener

				    refreshSearchVisibility();

arnaudvergnet (Migrated from github.com) commented

2022-09-05 08:12:48 +00:00

A solution would be to remove the @Nullable annotation from the mSearchLayout variable declaration. The editor would not complain and using only if(initSearchLayout()) would not raise a warning, but you would not get a warning either if you forget to do the check before. Which solution do you prefer?

A solution would be to remove the `@Nullable` annotation from the `mSearchLayout` variable declaration. The editor would not complain and using only `if(initSearchLayout())` would not raise a warning, but you would not get a warning either if you forget to do the check before. Which solution do you prefer?

vng (Migrated from github.com) reviewed 2022-09-05 11:31:18 +00:00

android/src/com/mapswithme/maps/maplayer/SearchWheel.java

					
				@ -122,40 +114,39 @@ public class SearchWheel implements View.OnClickListener

				    refreshSearchVisibility();

vng (Migrated from github.com) commented

2022-09-05 11:31:17 +00:00

Well, I think that developers are smart enough to realize a logic in this simple case without IDE warnings :)
I'd prefer not to duplicate checks in code, so remove Nullable?

Well, I think that developers are smart enough to realize a logic in this simple case without IDE warnings :) I'd prefer not to duplicate checks in code, so remove Nullable?