organicmaps/organicmaps-tmp

Archived

Fork 1

WIP: [android] Increased the font for the next street #3645

Draft

pratyaksh1610 wants to merge 2 commits from pratyaksh1610/branch-3621 into master

pratyaksh1610 commented

2022-10-15 14:31:59 +00:00

(Migrated from github.com)

fixes #3621

Signed-off-by: pratyaksh1610 pratyakshkhuranaofficial@gmail.com

Before

After

fixes #3621 Signed-off-by: pratyaksh1610 <pratyakshkhuranaofficial@gmail.com> ## Before ![default](https://user-images.githubusercontent.com/76740999/195991858-922daf50-cecd-4299-a8a8-ce9ec30db39c.png) ## After ![after1](https://user-images.githubusercontent.com/76740999/195991862-55f5a56f-2272-48c8-8a66-a319fd5e7cfb.png)

👍 1

arnaudvergnet (Migrated from github.com) reviewed 2022-10-15 14:31:59 +00:00

rtsisyk approved these changes 2022-10-16 13:55:10 +00:00

rtsisyk left a comment

Owner

LGTM

arnaudvergnet commented

2022-10-17 15:42:54 +00:00

(Migrated from github.com)

Would it be possible to better handle when the street name is too long? Right now it simply cuts it off. As the name is now bigger it would happen more often.

👍 1

biodranik (Migrated from github.com) requested changes 2022-10-17 17:33:17 +00:00

biodranik (Migrated from github.com) left a comment

Please don't increase the height of the white background bar. It occupies an important map space.
Please test how it looks on longer texts/street names. Ideally the text should be autoscaled to fit.
Please show/test how it looks in landscape.

1. Please don't increase the height of the white background bar. It occupies an important map space. 2. Please test how it looks on longer texts/street names. Ideally the text should be autoscaled to fit. 3. Please show/test how it looks in landscape.

pratyaksh1610 commented

2022-10-22 09:45:02 +00:00

(Migrated from github.com)

Before

After

## Before ![before](https://user-images.githubusercontent.com/76740999/197332707-b3fbe757-b8b3-4462-b7d3-772b6d176116.png) ## After ![a1](https://user-images.githubusercontent.com/76740999/197332713-38c90b44-1f80-4824-bf6b-a18699085759.png) ![a1l](https://user-images.githubusercontent.com/76740999/197332714-872ace46-e6d3-4097-b461-38df230a0282.png) ![WhatsApp Image 2022-10-22 at 2 53 51 PM](https://user-images.githubusercontent.com/76740999/197332717-46cea8a4-a510-49d1-9d96-fa65f0fc385a.jpeg) ![WhatsApp Image 2022-10-22 at 2 57 20 PM](https://user-images.githubusercontent.com/76740999/197332720-843955e9-e731-47c4-8059-234f90ce4adf.jpeg)

biodranik commented

2022-10-22 11:43:16 +00:00

(Migrated from github.com)

The indent on the top looks too big, can you reduce it? The status bar itself creates some indentation.
The indent on the left and right can be increased slightly.
What is displayed if the street name is even longer?

1. The indent on the top looks too big, can you reduce it? The status bar itself creates some indentation. 2. The indent on the left and right can be increased slightly. 3. What is displayed if the street name is even longer?

pratyaksh1610 commented

2022-10-22 11:46:59 +00:00

(Migrated from github.com)

We can set android:autoSizeMinTextSize=" " android:autoSizeMaxTextSize=" " to a specific value, so that it does'nt look too big if the number of characters is less.

We can set ` android:autoSizeMinTextSize=" " android:autoSizeMaxTextSize=" "` to a specific value, so that it does'nt look too big if the number of characters is less.

biodranik commented

2022-10-22 11:55:04 +00:00

(Migrated from github.com)

Yes, the idea is to automatically scale and display the readable text of almost any size. But please carefully test it and make some screenshots for the comparison.

This repo is archived. You cannot comment on pull requests.

No reviewers

arnaudvergnet

rtsisyk

biodranik