[android] convert place page to fragment #4174

Merged
arnaudvergnet merged 30 commits from pp-refactor into master 2023-02-18 19:55:12 +00:00

30 commits

Author SHA1 Message Date
Arnaud Vergnet
24e5e35dac android: improve fragment handling
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-18 16:10:04 +01:00
Arnaud Vergnet
96eb5c671f android: allow up to 5 place page buttons
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 20:40:28 +01:00
Arnaud Vergnet
9c1052ef26 android: fix opening hours hidden when unparsed string
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 20:22:10 +01:00
Arnaud Vergnet
f4e49d8020 android: remove unused variables
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:10:01 +01:00
Arnaud Vergnet
91ab04797e android: fix download country crash
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:10:01 +01:00
Arnaud Vergnet
c2c7ad6e6f android: move links in own fragment
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:10:01 +01:00
Arnaud Vergnet
68deef023f android: simplify pp fragment handling
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:10:00 +01:00
Arnaud Vergnet
110ddcfb7a android: move opening hours to own fragment
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:10:00 +01:00
Arnaud Vergnet
40dc16d434 android: remove unused description header
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:10:00 +01:00
Arnaud Vergnet
c8664abee3 android: further improve sheet animation smoothness
Make sure the place page can always reach the peek height
and call the peek height animation
in the UI thread to prevent weird animations

Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:10:00 +01:00
Arnaud Vergnet
8abfc44a89 android: fix crash on orientation change
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:10:00 +01:00
Arnaud Vergnet
657b38c8f4 android: move wikipedia summary in own fragment
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:10:00 +01:00
Arnaud Vergnet
d8ce84990f android: collapse pp when content size stays the same
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:59 +01:00
Arnaud Vergnet
e10afa9e8b android: removed unnecessary null checks
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:59 +01:00
Arnaud Vergnet
f48d1e01ea android: improve place page resize animation
Make sure the extended background is the right color
and make animation a bit slower

Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:59 +01:00
Arnaud Vergnet
bcf3edba4e android: prevent mapObject from being null after first init
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:59 +01:00
Arnaud Vergnet
7ab2a9f2e0 android: fix add stop always shown
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:59 +01:00
Arnaud Vergnet
0b8ca5874f android: make peek height animation smoother
Make sure animates correctly when the content height changes

Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:58 +01:00
Arnaud Vergnet
51b5587608 android: only collapse place page when data changes
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:58 +01:00
Arnaud Vergnet
c0ee9855ff android: use peek height instead of half extended
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:58 +01:00
Arnaud Vergnet
b27cb5da42 android: make sure animating bottom sheet height works
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:58 +01:00
Arnaud Vergnet
69a537c42e android: move phone view to own fragment
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:58 +01:00
Arnaud Vergnet
b18c80e65d android: keep place page opened when map object changes
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:58 +01:00
Arnaud Vergnet
0cb55762d8 android: add more margin to bottom sheet handle
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:57 +01:00
Arnaud Vergnet
3b137ae1e4 android: move place page bookmark in fragment
Also reworked the peek height
to work better with lazy loading of webview

Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:57 +01:00
Arnaud Vergnet
96baacab0d android: fix peek height animation
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:57 +01:00
Arnaud Vergnet
6a45899a37 android: move place page view fragment
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:57 +01:00
Arnaud Vergnet
14c01964c2 android: move place page buttons to fragment
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:56 +01:00
Arnaud Vergnet
356b315263 android: reduce coupling with place page view and buttons
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:55 +01:00
Arnaud Vergnet
ef907425b0 chore: simplify place page controller
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
2023-02-17 19:09:54 +01:00