[editor] Migrate mapsme to omaps #4387

2023-02-01T19:03:06Z

Jean-BaptisteC commented

2023-02-01 19:03:06 +00:00

(Migrated from github.com)

This PR following works started here #4050

biodranik (Migrated from github.com) requested changes 2023-02-02 10:45:09 +00:00

biodranik (Migrated from github.com) left a comment

The code doesn't load an old config. To reproduce:

Build the version from master (desktop or mobile)
Run and make an edit (you don't need to upload it to OSM, so no logging in is necessary)
Close the app. Build this branch.
Run this branch version.
Observe the ASSERT crash:

LOG TID(1) ERROR     0.29318 editor/config_loader.cpp:154 LoadFromLocal(): Config can not be loaded.

Obviously, the loading code should check if either the old or new XML element is present in the root node. And always save a new value.

The code doesn't load an old config. To reproduce: 1. Build the version from master (desktop or mobile) 2. Run and make an edit (you don't need to upload it to OSM, so no logging in is necessary) 3. Close the app. Build this branch. 4. Run this branch version. 5. Observe the ASSERT crash: ``` LOG TID(1) ERROR 0.29318 editor/config_loader.cpp:154 LoadFromLocal(): Config can not be loaded. ``` Obviously, the loading code should check if either the old or new XML element is present in the root node. And always save a new value.

 @ -168,7 +168,12 @@ void Editor::LoadEdits()
   m_features.Set(make_shared<FeaturesContainer>());
   auto loadedFeatures = make_shared<FeaturesContainer>();

Rows
Columns