[search] Add ability to search generators #5084

Open
N-45div wants to merge 2 commits from N-45div/N-45div/issue4788 into master
N-45div commented 2023-05-04 10:52:49 +00:00 (Migrated from github.com)

Fixes #4788
Issue of search generators has been resolved please review it
regards,
N DIVIJ

Fixes #4788 Issue of search generators has been resolved please review it regards, N DIVIJ
biodranik (Migrated from github.com) reviewed 2023-05-06 18:07:41 +00:00
biodranik (Migrated from github.com) commented 2023-05-06 18:07:21 +00:00

Did you read the comment at the top of the file?

Did you read the comment at the top of the file?
biodranik (Migrated from github.com) commented 2023-05-06 18:07:36 +00:00

Why did you insert spaces?

Why did you insert spaces?
N-45div (Migrated from github.com) reviewed 2023-05-06 18:27:12 +00:00
N-45div (Migrated from github.com) commented 2023-05-06 18:27:11 +00:00

hmm, yes i think i have mistaken somewhere sorry from my side...

hmm, yes i think i have mistaken somewhere sorry from my side...
N-45div (Migrated from github.com) reviewed 2023-05-06 18:27:58 +00:00
N-45div (Migrated from github.com) commented 2023-05-06 18:27:57 +00:00

oh..k sir i will remove those spaces and again give the pull request
Thank you for reviewing..

oh..k sir i will remove those spaces and again give the pull request Thank you for reviewing..
N-45div (Migrated from github.com) reviewed 2023-05-06 18:37:30 +00:00
N-45div (Migrated from github.com) commented 2023-05-06 18:37:30 +00:00

oh..k sir i will remove those spaces and again give the pull request Thank you for reviewing..

@biodranik sir anywhere else any input needed please tell me...or just the problem of spaces is there..

> oh..k sir i will remove those spaces and again give the pull request Thank you for reviewing.. @biodranik sir anywhere else any input needed please tell me...or just the problem of spaces is there..
N-45div (Migrated from github.com) reviewed 2023-05-06 19:18:01 +00:00
N-45div (Migrated from github.com) commented 2023-05-06 19:18:00 +00:00

@biodranik sir i have pushed the code with changes and with some other fixes please review it...
Regards,
N DIVIJ

@biodranik sir i have pushed the code with changes and with some other fixes please review it... Regards, N DIVIJ
biodranik (Migrated from github.com) reviewed 2023-05-22 17:59:43 +00:00
@ -14994,0 +15007,4 @@
uk:Генератор
zh-Hans:发电机
power-generator-solar|@solar
biodranik (Migrated from github.com) commented 2023-05-22 17:59:43 +00:00
power-generator-solar|@generator

@vng right?

```suggestion power-generator-solar|@generator ``` @vng right?
biodranik (Migrated from github.com) reviewed 2023-05-22 18:00:18 +00:00
@ -14993,1 +14993,4 @@
zh-Hant:發電廠
power-generator|@generator
en:Generator
biodranik (Migrated from github.com) commented 2023-05-22 18:00:18 +00:00

Why didn't you copy all text values for all languages from types_strings.txt?

Why didn't you copy all text values for all languages from types_strings.txt?
N-45div (Migrated from github.com) reviewed 2023-05-22 19:49:48 +00:00
@ -14993,1 +14993,4 @@
zh-Hant:發電廠
power-generator|@generator
en:Generator
N-45div (Migrated from github.com) commented 2023-05-22 19:49:48 +00:00

Sir in every category that you mentioned in the issue i copied it. If still lacking anywhere i will check once again...
Thank you for reviewing it

Sir in every category that you mentioned in the issue i copied it. If still lacking anywhere i will check once again... Thank you for reviewing it
This repo is archived. You cannot comment on pull requests.
No reviewers
No labels
Accessibility
Accessibility
Address
Address
Android
Android
Android Auto
Android Auto
Android Automotive (AAOS)
Android Automotive (AAOS)
API
API
AppGallery
AppGallery
AppStore
AppStore
Battery and Performance
Battery and Performance
Blocker
Blocker
Bookmarks and Tracks
Bookmarks and Tracks
Borders
Borders
Bug
Bug
Build
Build
CarPlay
CarPlay
Classificator
Classificator
Community
Community
Core
Core
CrashReports
CrashReports
Cycling
Cycling
Desktop
Desktop
DevEx
DevEx
DevOps
DevOps
dev_sandbox
dev_sandbox
Directions
Directions
Documentation
Documentation
Downloader
Downloader
Drape
Drape
Driving
Driving
Duplicate
Duplicate
Editor
Editor
Elevation
Elevation
Enhancement
Enhancement
Epic
Epic
External Map Datasets
External Map Datasets
F-Droid
F-Droid
Fonts
Fonts
Frequently User Reported
Frequently User Reported
Fund
Fund
Generator
Generator
Good first issue
Good first issue
Google Play
Google Play
GPS
GPS
GSoC
GSoC
iCloud
iCloud
Icons
Icons
iOS
iOS
Legal
Legal
Linux Desktop
Linux Desktop
Linux packaging
Linux packaging
Linux Phone
Linux Phone
Mac OS
Mac OS
Map Data
Map Data
Metro
Metro
Navigation
Navigation
Need Feedback
Need Feedback
Night Mode
Night Mode
NLnet 2024-06-281
NLnet 2024-06-281
No Feature Parity
No Feature Parity
Opening Hours
Opening Hours
Outdoors
Outdoors
POI Info
POI Info
Privacy
Privacy
Public Transport
Public Transport
Raw Idea
Raw Idea
Refactoring
Refactoring
Regional
Regional
Regression
Regression
Releases
Releases
RoboTest
RoboTest
Route Planning
Route Planning
Routing
Routing
Ruler
Ruler
Search
Search
Security
Security
Styles
Styles
Tests
Tests
Track Recording
Track Recording
Translations
Translations
TTS
TTS
UI
UI
UX
UX
Walk Navigation
Walk Navigation
Watches
Watches
Web
Web
Wikipedia
Wikipedia
Windows
Windows
Won't fix
Won't fix
World Map
World Map
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#5084
No description provided.