Added altitude chart to the NavMenu while Expanded #5115

AndrewShkrob · 2023-05-10T14:44:09Z

codeskraps commented

2023-05-10 14:44:09 +00:00

(Migrated from github.com)

Signed-off-by: Carles Sentis me@codeskraps.com

Signed-off-by: Carles Sentis <me@codeskraps.com>

biodranik (Migrated from github.com) reviewed 2023-05-10 15:28:17 +00:00

biodranik (Migrated from github.com) left a comment

Thanks!

Does it work in landscape mode? Does it look good?
Does it work/look good in the night mode?
Does the graph show the remaining distance from the current position, or the whole initial route that was displayed when the route was built? How we can make it clear to users?

Thanks! 1. Does it work in landscape mode? Does it look good? 2. Does it work/look good in the night mode? 3. Does the graph show the remaining distance from the current position, or the whole initial route that was displayed when the route was built? How we can make it clear to users?

android/res/layout/layout_nav_bottom.xml

biodranik (Migrated from github.com) commented

2023-05-10 15:21:42 +00:00

Why tts?

android/src/app/organicmaps/widget/menu/NavMenu.java

					
				@ -27,2 +20,4 @@

				import java.util.concurrent.TimeUnit;

				import app.organicmaps.Framework;

				import app.organicmaps.R;

biodranik (Migrated from github.com) commented

2023-05-10 15:22:49 +00:00

Why imports are unsorted now?

android/src/app/organicmaps/widget/menu/NavMenu.java

biodranik (Migrated from github.com) commented

2023-05-10 15:26:28 +00:00

When we can have null here? Should we crash to debug and fix it earlier?
If error case is a valid one, should the view be in the GONE state?

1. When we can have null here? Should we crash to debug and fix it earlier? 2. If error case is a valid one, should the view be in the GONE state?

Jean-BaptisteC (Migrated from github.com) requested changes 2023-05-10 16:43:57 +00:00

Jean-BaptisteC (Migrated from github.com) left a comment

❌ Pixel 6 - Android 13

Search destination and start routing
Quit routing and search other destination
Start routing -> altitude chart is not update, OM show altitude chart from first routing

❌ Pixel 6 - Android 13 - Search destination and start routing - Quit routing and search other destination - Start routing -> altitude chart is not update, OM show altitude chart from first routing

AndrewShkrob reviewed 2023-05-10 21:58:12 +00:00

android/src/app/organicmaps/widget/menu/NavMenu.java

AndrewShkrob commented

2023-05-10 21:58:11 +00:00

        final int chartWidth = ((View) mRoutingChart.getParent()).getWidth();
        final int chartHeight = UiUtils.dimen(mActivity, R.dimen.altitude_chart_image_height);
        final Framework.RouteAltitudeLimits limits = new Framework.RouteAltitudeLimits();
        final Bitmap bm = Framework.generateRouteAltitudeChart(chartWidth, chartHeight, limits);

```suggestion final int chartWidth = ((View) mRoutingChart.getParent()).getWidth(); final int chartHeight = UiUtils.dimen(mActivity, R.dimen.altitude_chart_image_height); final Framework.RouteAltitudeLimits limits = new Framework.RouteAltitudeLimits(); final Bitmap bm = Framework.generateRouteAltitudeChart(chartWidth, chartHeight, limits); ```

codeskraps (Migrated from github.com) reviewed 2023-05-11 11:40:57 +00:00

android/res/layout/layout_nav_bottom.xml

codeskraps (Migrated from github.com) commented

2023-05-11 11:40:57 +00:00

Updated

codeskraps (Migrated from github.com) reviewed 2023-05-11 11:41:43 +00:00

android/src/app/organicmaps/widget/menu/NavMenu.java

					
				@ -27,2 +20,4 @@

				import java.util.concurrent.TimeUnit;

				import app.organicmaps.Framework;

				import app.organicmaps.R;

codeskraps (Migrated from github.com) commented

2023-05-11 11:41:42 +00:00

Sorry there were warning and I used the shortcut to optimise imports which automatically rearranged them. I won't do it again in this project

codeskraps (Migrated from github.com) reviewed 2023-05-11 11:43:54 +00:00

android/src/app/organicmaps/widget/menu/NavMenu.java

codeskraps (Migrated from github.com) commented

2023-05-11 11:43:54 +00:00

1.- The chart should now update for new routes searches. I didn't realised views where not recreated from scratch every time but saved.
2.- In case of NULL bm the chart is now GONE

1.- The chart should now update for new routes searches. I didn't realised views where not recreated from scratch every time but saved. 2.- In case of NULL bm the chart is now GONE