organicmaps/organicmaps-tmp
Archived
13
Fork 1
Code Issues 2.7k Pull requests 182 Projects Releases 65 Wiki Activity Actions

WIP: [navigation] Increase finish intermediate stop distance from 20 to 30m for car #5133

Draft
biodranik wants to merge 1 commit from car-checkpoint-tolerance into master
pull from: car-checkpoint-tolerance
merge into: organicmaps:master
Conversation 0 Commits 1 Files changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
routing/routing_settings.cpp
View file

@ -84,7 +84,7 @@ RoutingSettings GetRoutingSettings(VehicleType vehicleType)
50.0 /* m_matchingThresholdM */,
true /* m_showTurnAfterNext */,
measurement_utils::KmphToMps(3.0) /* m_minSpeedForRouteRebuildMpS */,
20.0 /* m_finishToleranceM */,
30.0 /* m_finishToleranceM */,
9 /* m_maxOutgoingPointsCount */,
rtsisyk commented 2023-05-13 06:43:11 +00:00
Review
Copy link

Probably even 50.

Probably even 50.
biodranik commented 2023-05-13 07:53:49 +00:00 (Migrated from github.com)
Review
Copy link

@vng should kOnEndToleranceM be modified instead for intermediate stops? I was confused by the logic:

  double const finishToleranceM = segmentIdx == m_routeSegments.size() - 1
                                      ? m_routingSettings.m_finishToleranceM
                                      : kOnEndToleranceM;
@vng should kOnEndToleranceM be modified instead for intermediate stops? I was confused by the logic: ``` double const finishToleranceM = segmentIdx == m_routeSegments.size() - 1 ? m_routingSettings.m_finishToleranceM : kOnEndToleranceM; ```
biodranik commented 2023-05-13 07:54:35 +00:00 (Migrated from github.com)
Review
Copy link

Let's also rename these variables to make them more clear. What can you suggest?

Let's also rename these variables to make them more clear. What can you suggest?
rtsisyk commented 2023-11-23 09:05:34 +00:00
Review
Copy link

Google Maps finishes my route when I drive 100 meters from the point.

Google Maps finishes my route when I drive 100 meters from the point.
rtsisyk commented 2023-11-23 09:06:37 +00:00
Review
Copy link
  double const finishToleranceM = segmentIdx == m_routeSegments.size() - 1
                                      ? m_routingSettings.m_finishToleranceM
                                      : kOnEndToleranceM;

it looks like that m_finishToleranceM is for the final point, kOnEndToleranceM for intermediate. Why do we need two constants here?

``` double const finishToleranceM = segmentIdx == m_routeSegments.size() - 1 ? m_routingSettings.m_finishToleranceM : kOnEndToleranceM; ``` it looks like that m_finishToleranceM is for the final point, kOnEndToleranceM for intermediate. Why do we need two constants here?
120.0 /* m_minOutgoingDistMeters */,
2 /* m_maxIngoingPointsCount */,