organicmaps/organicmaps-tmp
Archived
13
Fork 1
Code Issues 2.7k Pull requests 182 Projects Releases 65 Wiki Activity Actions

Helicopter/Ruler routing #5381

Merged
root merged 14 commits from helicopter-navigation-v2 into master 2023-08-31 10:29:26 +00:00
Conversation 0 Commits 14 Files changed 104 +843 -145
strump commented 2023-06-22 08:20:40 +00:00
Member
Copy link

Updates for PR #4917
See #5465 #1452 #5431

New routing type is added. In this routing only straight lines connect stop points:

Android iOS

Also new button is added in route planning mode (Android only). Button "Next" appends new stop point to the route. It works for all route types:
Routing buttons

Strings changes

String "Distance" ("placepage_distance") previosly was available only for iOS. Now it's used at Android too.

Known issues:

Issue 1:

Line is drawn below buildings: Fixed:

Issue 2:

Lack of unit tests.

Issue 3:

Empty space in iOS route info on the bottom pannel if only 2 points in the helicopter route. iOS layout fixed.

Usability issue:

Helicopter router is intended for two use cases: simple distance measurement (ruller), and direct line route planing (usefull in forests, waterways, wilds). Ruller case UX should be quick: user get distance between two points. While direct line planing should work more like pedestrian/bike/car route planing. Question: How to combine two cases in a single UX?

TODO:

  • Add heights chart
  • Live navigation along helicopter route
  • Style improvements: draw segment length on the map, draw ruller instead of purple line.

Update 2023-06-30

Changed Android and iOS route details UI. Android uses the same UI as Transit navigation.

Helicopter route line now draws on top of 3D buildings. Other routes are untouched.

Update 2023-07-02

[Android] changed "Next" button icon:

Next button icon update

Update 2023-08-04

[iOS] Changed helicopter route info. Using transit route UI (as we do in Android).

Update 2023-08-21

[Android], [iOS] Changed icon to ruler.

Ruler/Helicopter navigation is extended with a single tap.

[Android] Removed "Next" button from UI.

Updates for PR #4917 See #5465 #1452 #5431 New routing type is added. In this routing only straight lines connect stop points: | Android | iOS | | ------- | --- | | <img src="https://github.com/organicmaps/organicmaps/assets/720808/cbd5f916-3208-4c51-9d0c-3ece898319d2" width="300px"/> | <img src="https://github.com/organicmaps/organicmaps/assets/720808/48a776cc-c634-459d-97ab-59bbda310ed5" width="300px"/> | Also new button is added in route planning mode (Android only). Button "Next" appends new stop point to the route. It works for all route types: <img alt="Routing buttons" src="https://github.com/organicmaps/organicmaps/assets/720808/d82fc562-23ab-40a2-8773-bbcdaa7f38a5" width="300px" /> ## Strings changes String "Distance" (`"placepage_distance"`) previosly was available only for iOS. Now it's used at Android too. ## Known issues: ### Issue 1: <s>Line is drawn below buildings:</s> Fixed: <img src="https://github.com/organicmaps/organicmaps/assets/720808/0c344b47-fdf9-4f3c-b022-594f38bc92be" width="300px"/> ### Issue 2: Lack of unit tests. ### Issue 3: <s>Empty space in iOS route info on the bottom pannel if only 2 points in the helicopter route.</s> iOS layout fixed. ## Usability issue: Helicopter router is intended for two use cases: simple distance measurement (ruller), and direct line route planing (usefull in forests, waterways, wilds). Ruller case UX should be quick: user get distance between two points. While direct line planing should work more like pedestrian/bike/car route planing. Question: How to combine two cases in a single UX? ## TODO: * Add heights chart * Live navigation along helicopter route * Style improvements: draw segment length on the map, draw ruller instead of purple line. ## Update 2023-06-30 Changed Android and iOS route details UI. Android uses the same UI as Transit navigation. Helicopter route line now draws on top of 3D buildings. Other routes are untouched. ## Update 2023-07-02 `[Android]` changed "Next" button icon: <img src="https://github.com/organicmaps/organicmaps/assets/720808/bf5cf598-d5d9-40c9-b7ca-409072864692" width="300px" alt="Next button icon update"/> ## Update 2023-08-04 `[iOS]` Changed helicopter route info. Using transit route UI (as we do in Android). <img src="https://github.com/organicmaps/organicmaps/assets/720808/48a776cc-c634-459d-97ab-59bbda310ed5" width="300px"/> ## Update 2023-08-21 `[Android]`, `[iOS]` Changed icon to ruler. <img src="https://github.com/organicmaps/organicmaps/assets/720808/27a722c0-1cd5-46c0-9d39-e35ae90206fa" width="300px"/> Ruler/Helicopter navigation is extended with a single tap. `[Android]` Removed "Next" button from UI.
vng (Migrated from github.com) reviewed 2023-06-22 13:37:17 +00:00
android/jni/app/organicmaps/Framework.cpp
vng (Migrated from github.com) commented 2023-06-22 13:04:38 +00:00

nit: = mercator::FromLatLon(lat, lon)

nit: = mercator::FromLatLon(lat, lon)
android/src/app/organicmaps/routing/RoutingBottomMenuController.java
vng (Migrated from github.com) commented 2023-06-22 13:12:53 +00:00

nit: Better to keep our common braces style here and below. Don't use braces for one-line expressions.

nit: Better to keep our common braces style here and below. Don't use braces for one-line expressions.
android/src/app/organicmaps/routing/RoutingBottomMenuController.java
vng (Migrated from github.com) commented 2023-06-22 13:11:48 +00:00

https://symbl.cc/en/unicode/blocks/enclosed-alphanumerics/
They are continuous, so can do a trick up to 20:
marker = FromCode((U+2460) + i - 1);

https://symbl.cc/en/unicode/blocks/enclosed-alphanumerics/ They are continuous, so can do a trick up to 20: marker = FromCode((U+2460) + i - 1);
map/routing_manager.cpp
vng (Migrated from github.com) commented 2023-06-22 13:22:35 +00:00

nit: Put this long comment above the line.

nit: Put this long comment above the line.
routing/async_router.cpp
vng (Migrated from github.com) commented 2023-06-22 13:25:22 +00:00

A bit strange, but ok for now ..

A bit strange, but ok for now ..
routing/helicopter_router.cpp
vng (Migrated from github.com) commented 2023-06-22 13:31:30 +00:00

routeSegments.emplace_back(segment, turn, junction, roadNameInfo);

routeSegments.emplace_back(segment, turn, junction, roadNameInfo);
vng (Migrated from github.com) commented 2023-06-22 13:33:01 +00:00 
if (i == points.size() - 1)
  turn = turns::TurnItem(i+1, turns::PedestrianDirection::ReachedYourDestination);
else if (i == 0)
  continue;

routeSegments.emplace_back(segment, turn, junction, roadNameInfo);
times.push_back(0);
``` if (i == points.size() - 1) turn = turns::TurnItem(i+1, turns::PedestrianDirection::ReachedYourDestination); else if (i == 0) continue; routeSegments.emplace_back(segment, turn, junction, roadNameInfo); times.push_back(0); ```
vng (Migrated from github.com) commented 2023-06-22 13:35:24 +00:00 
using PointWA = geometry::PointWithAltitude;

subroutes.emplace_back(PointWA(points[i-1], mockAltitude), PointWA(points[i-1], mockAltitude), i*2-2, i*2-1);

...
``` using PointWA = geometry::PointWithAltitude; subroutes.emplace_back(PointWA(points[i-1], mockAltitude), PointWA(points[i-1], mockAltitude), i*2-2, i*2-1); ... ```
vng (Migrated from github.com) commented 2023-06-22 13:37:07 +00:00

size_t const count = points.size();
ASSERT(count > 0, ());

And use it below.

size_t const count = points.size(); ASSERT(count > 0, ()); And use it below.
vng (Migrated from github.com) reviewed 2023-06-22 14:14:26 +00:00
routing/helicopter_router.cpp
vng (Migrated from github.com) commented 2023-06-22 14:14:25 +00:00

Even better to avoid visual syntax overhead:

auto const ToPointWA = [](m2::PointD const & p)
{
  return geometry::PointWithAltitude(p, 0 /* altitude */);
};

subroutes.emplace_back(ToPointWA(points[i-1]), ToPointWA(points[i-1]), i*2-2, i*2-1);
Even better to avoid visual syntax overhead: ``` auto const ToPointWA = [](m2::PointD const & p) { return geometry::PointWithAltitude(p, 0 /* altitude */); }; subroutes.emplace_back(ToPointWA(points[i-1]), ToPointWA(points[i-1]), i*2-2, i*2-1); ```
strump reviewed 2023-06-22 14:51:01 +00:00
routing/helicopter_router.cpp
strump commented 2023-06-22 14:51:01 +00:00
Author
Member

And what about performance? Would compiler be able to inline lambda here?

And what about performance? Would compiler be able to inline lambda here?
vng (Migrated from github.com) reviewed 2023-06-22 17:25:31 +00:00
routing/helicopter_router.cpp
vng (Migrated from github.com) commented 2023-06-22 17:25:31 +00:00

Yes

Yes
strump reviewed 2023-06-23 19:10:46 +00:00
routing/helicopter_router.cpp
strump commented 2023-06-23 19:10:46 +00:00
Author
Member

In commit #7566d8f I increased end index by 1 because in route.cpp:447 we have:

size_t const segmentIdx = endSegmentIdx - 1;
In commit [#7566d8f](https://git.omaps.dev/organicmaps/organicmaps/pulls/5381/commits/7566d8fbb8ef1628949f3103deee0d7debc719f2) I increased end index by 1 because in [route.cpp:447](https://github.com/organicmaps/organicmaps/blob/master/routing/route.cpp#L448) we have: ```c++ size_t const segmentIdx = endSegmentIdx - 1; ```
biodranik (Migrated from github.com) reviewed 2023-06-23 20:01:05 +00:00
routing/helicopter_router.cpp
biodranik (Migrated from github.com) commented 2023-06-23 20:01:05 +00:00

It's better to put this comment into the code.

It's better to put this comment into the code.
biodranik (Migrated from github.com) reviewed 2023-06-23 20:01:19 +00:00
routing/helicopter_router.cpp
biodranik (Migrated from github.com) commented 2023-06-23 20:01:19 +00:00

@vng PTAL

@vng PTAL
strump reviewed 2023-06-30 10:35:06 +00:00
android/jni/app/organicmaps/Framework.cpp
strump commented 2023-06-30 10:35:05 +00:00
Author
Member

Fixed

Fixed
strump reviewed 2023-06-30 10:35:58 +00:00
android/src/app/organicmaps/routing/RoutingBottomMenuController.java
strump commented 2023-06-30 10:35:58 +00:00
Author
Member

Not relevant. Route details UI is inherited from transit info.

Not relevant. Route details UI is inherited from transit info.
strump reviewed 2023-06-30 10:36:12 +00:00
android/src/app/organicmaps/routing/RoutingBottomMenuController.java
strump commented 2023-06-30 10:36:12 +00:00
Author
Member

Fixed

Fixed
strump reviewed 2023-06-30 10:36:22 +00:00
map/routing_manager.cpp
strump commented 2023-06-30 10:36:22 +00:00
Author
Member

Fixed

Fixed
strump reviewed 2023-06-30 10:36:32 +00:00
routing/helicopter_router.cpp
strump commented 2023-06-30 10:36:31 +00:00
Author
Member

Fixed

Fixed
strump reviewed 2023-06-30 10:36:45 +00:00
routing/helicopter_router.cpp
strump commented 2023-06-30 10:36:45 +00:00
Author
Member

Fixed using your code.

Fixed using your code.
strump reviewed 2023-06-30 10:36:58 +00:00
routing/helicopter_router.cpp
strump commented 2023-06-30 10:36:57 +00:00
Author
Member

Fixed using your code

Fixed using your code
strump reviewed 2023-06-30 10:37:16 +00:00
routing/helicopter_router.cpp
strump commented 2023-06-30 10:37:16 +00:00
Author
Member

Introduced variable.

Introduced variable.
strump reviewed 2023-06-30 10:37:29 +00:00
routing/helicopter_router.cpp
strump commented 2023-06-30 10:37:28 +00:00
Author
Member

Added comment

Added comment
Jean-BaptisteC (Migrated from github.com) requested changes 2023-06-30 10:54:52 +00:00
Jean-BaptisteC (Migrated from github.com) left a comment

❌ Pixel 6 - Android 13
App crashed when i rotate device after used helicopter navigation

❌ Pixel 6 - Android 13 App crashed when i rotate device after used helicopter navigation
biodranik (Migrated from github.com) reviewed 2023-06-30 13:36:08 +00:00
android/src/app/organicmaps/routing/RoutingBottomMenuController.java
biodranik (Migrated from github.com) commented 2023-06-30 13:36:07 +00:00 
    for (int i = 1; i<points.length; i++)
    {
      RouteMarkData segmentStart = points[i - 1];
      RouteMarkData segmentEnd = points[i];
      DistanceAndAzimut dist = Framework.nativeGetDistanceAndAzimuthFromLatLon(segmentStart.mLat, segmentStart.mLon, segmentEnd.mLat, segmentEnd.mLon, 0);
      if (i > 1)
        transitSteps.add(TransitStepInfo.intermediatePoint(i - 2));
```suggestion for (int i = 1; i<points.length; i++) { RouteMarkData segmentStart = points[i - 1]; RouteMarkData segmentEnd = points[i]; DistanceAndAzimut dist = Framework.nativeGetDistanceAndAzimuthFromLatLon(segmentStart.mLat, segmentStart.mLon, segmentEnd.mLat, segmentEnd.mLon, 0); if (i > 1) transitSteps.add(TransitStepInfo.intermediatePoint(i - 2)); ```
vng (Migrated from github.com) reviewed 2023-07-02 12:56:42 +00:00
drape_frontend/frontend_renderer.cpp
vng (Migrated from github.com) commented 2023-07-02 12:48:29 +00:00

Don't understand why it is here?
The difference here is only in call order and supporting Framebuffers

Don't understand why it is here? The difference here is only in call order and supporting Framebuffers
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
vng (Migrated from github.com) commented 2023-07-02 12:51:42 +00:00

Since we are in cpp world here, it can be simplified:

auto const distance = platform::Distance::CreateFormatted(
  ms::DistanceOnEarth(segmentStart.latitude, segmentStart.longitude, segmentEnd.latitude, segmentEnd.longitude));
Since we are in cpp world here, it can be simplified: ``` auto const distance = platform::Distance::CreateFormatted( ms::DistanceOnEarth(segmentStart.latitude, segmentStart.longitude, segmentEnd.latitude, segmentEnd.longitude)); ```
routing/helicopter_router.cpp
vng (Migrated from github.com) commented 2023-07-02 12:56:01 +00:00

Also use ToPointWA

Also use ToPointWA
vng (Migrated from github.com) reviewed 2023-07-02 14:21:06 +00:00
map/routing_manager.cpp
vng (Migrated from github.com) commented 2023-07-02 14:21:05 +00:00

Add comment what do we want to achieve here?
Seems like m_headFakeDistance, m_tailFakeDistance are not supposed to modify outside.
They are for CreateDrapeSubroute internals.

Add comment what do we want to achieve here? Seems like m_headFakeDistance, m_tailFakeDistance are not supposed to modify outside. They are for CreateDrapeSubroute internals.
strump reviewed 2023-07-03 08:05:04 +00:00
drape_frontend/frontend_renderer.cpp
strump commented 2023-07-03 08:05:03 +00:00
Author
Member

The only difference in this if-else block is order of drawing. And to draw route on top of 3D buildings I force else block for helicopter route type.
Is there any better solution?

The only difference in this if-else block is order of drawing. And to draw route on top of 3D buildings I force `else` block for helicopter route type. Is there any better solution?
strump reviewed 2023-07-03 09:14:53 +00:00
map/routing_manager.cpp
strump commented 2023-07-03 09:14:53 +00:00
Author
Member

When I draw straight line with route_dash.fsh.glsl
drape-schema-grey-out

Line tail color is changed to u_fakeColor after some distance. Previosly there was no such long lines. So I increased this distance to 90° in order to not change shader code:

drape-schema
When I draw straight line with `route_dash.fsh.glsl` <img alt="drape-schema-grey-out" src="https://github.com/organicmaps/organicmaps/assets/720808/beca1c0b-e7f2-48dc-b466-4d5b8e7990f0" width="300px"/> Line tail color is changed to `u_fakeColor` after some distance. Previosly there was no such long lines. So I increased this distance to 90° in order to not change shader code: <img alt="drape-schema" src="https://github.com/organicmaps/organicmaps/assets/720808/1a864ba5-1af4-44b6-9e3f-3c5d4f493139" width="300px"/>
strump reviewed 2023-07-03 09:34:03 +00:00
routing/helicopter_router.cpp
strump commented 2023-07-03 09:34:03 +00:00
Author
Member

Fixed!

Fixed!
strump reviewed 2023-07-03 09:34:17 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
strump commented 2023-07-03 09:34:16 +00:00
Author
Member

Fixed using your proposal.

Fixed using your proposal.
strump reviewed 2023-07-03 09:39:28 +00:00
map/routing_manager.cpp
strump commented 2023-07-03 09:39:28 +00:00
Author
Member

An idea came to my mind. Maybe I should change u_fakeColor value for Helicopter route?
This color is loaded in RouteRenderer::RenderSubroute(...) method:

df::GetColorConstant(kRouteFakeColor)

Is RouteRenderer better place to fix the color?

An idea came to my mind. Maybe I should change `u_fakeColor` value for Helicopter route? This color is loaded in `RouteRenderer::RenderSubroute(...)` method: ``` df::GetColorConstant(kRouteFakeColor) ``` Is RouteRenderer better place to fix the color?
biodranik (Migrated from github.com) reviewed 2023-07-04 12:03:02 +00:00
map/routing_manager.cpp
biodranik (Migrated from github.com) commented 2023-07-04 12:03:02 +00:00

@rokuz any hints on how to implement it properly?

@strump In the longer term it may be better to write a separate shader/style for the helicopter navigation. Maybe a thin line with text drawn in it like ---50 km--- would be enough.

@rokuz any hints on how to implement it properly? @strump In the longer term it may be better to write a separate shader/style for the helicopter navigation. Maybe a thin line with text drawn in it like ---50 km--- would be enough.
vng (Migrated from github.com) reviewed 2023-07-05 12:00:37 +00:00
map/routing_manager.cpp
vng (Migrated from github.com) commented 2023-07-05 12:00:37 +00:00

Ah, I see ..
m_headFakeDistance and m_tailFakeDistance are about drawing grey (fake) lines when entering/leaving the normal route.

In helicopter router we don't need it, so better to set:

auto constexpr kBias = 1.0;
subroute->m_headFakeDistance = -kBias;
subroute->m_tailFakeDistance = totalLength + kBias;

Like it is done in CreateDrapeSubroute. Or if we call CreateDrapeSubroute, should debug why route parts are marked as fake.

Ah, I see .. m_headFakeDistance and m_tailFakeDistance are about drawing grey (_fake_) lines when entering/leaving the normal route. In helicopter router we don't need it, so better to set: ``` auto constexpr kBias = 1.0; subroute->m_headFakeDistance = -kBias; subroute->m_tailFakeDistance = totalLength + kBias; ``` Like it is done in CreateDrapeSubroute. Or if we call CreateDrapeSubroute, should debug why route parts are marked as _fake_.
vng (Migrated from github.com) reviewed 2023-07-05 18:09:58 +00:00
drape_frontend/frontend_renderer.cpp
vng (Migrated from github.com) commented 2023-07-05 18:09:57 +00:00

Well, if we want a route line to be on top of everything (other routes don't overlap buildings?), it is an acceptable solution for now.

Well, if we want a route line to be on top of everything (other routes don't overlap buildings?), it is an acceptable solution for now.
strump reviewed 2023-07-19 07:58:00 +00:00
map/routing_manager.cpp
strump commented 2023-07-19 07:58:00 +00:00
Author
Member

@vng fixed m_tailFakeDistance in commit 4825fde

I'm little worried that we have two special route types: transit and helicopter. I have to pass both flags bool isTransit, bool isHelicopter in couple of places. If we have any new such special case in future, let's think on better approach.

@vng fixed `m_tailFakeDistance` in commit [4825fde](https://github.com/strump/organicmaps/commit/4825fde06f842a64fe119a23139ae43dee36a4c7) I'm little worried that we have two special route types: transit and helicopter. I have to pass both flags `bool isTransit`, `bool isHelicopter` in couple of places. If we have any new such special case in future, let's think on better approach.
biodranik (Migrated from github.com) reviewed 2023-07-19 20:20:26 +00:00
map/routing_manager.cpp
biodranik (Migrated from github.com) commented 2023-07-19 20:20:26 +00:00

Are they mutually exclusive? If yes, then an enum could be a better approach.

Are they mutually exclusive? If yes, then an enum could be a better approach.
strump reviewed 2023-08-22 06:37:51 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager.mm
strump commented 2023-08-22 06:37:00 +00:00
Author
Member

With single-tap ruler we get _state == MWMNavigationDashboardStateReady on each tap.
Should we comment out NSAssert(...) or remove this if (...).

With single-tap ruler we get `_state == MWMNavigationDashboardStateReady` on each tap. Should we comment out `NSAssert(...)` or remove this `if (...)`.
biodranik (Migrated from github.com) reviewed 2023-08-23 05:15:52 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager.mm
biodranik (Migrated from github.com) commented 2023-08-23 05:15:51 +00:00

Why is this stateReady needed for each nav type? Logically, we can later add "Start navigation" to the ruler too.

The question is why the assert below happens (why is it called with MWMNavigationDashboardStatePlanning)?

Guessing is not the best strategy here, it may lead to many unexpected bugs...

Why is this stateReady needed for each nav type? Logically, we can later add "Start navigation" to the ruler too. The question is why the assert below happens (why is it called with MWMNavigationDashboardStatePlanning)? Guessing is not the best strategy here, it may lead to many unexpected bugs...
vng (Migrated from github.com) reviewed 2023-08-24 17:37:00 +00:00
vng (Migrated from github.com) left a comment

LGTM

LGTM
android/src/app/organicmaps/routing/RoutingController.java
vng (Migrated from github.com) commented 2023-08-24 17:10:21 +00:00

nit: I think these debug logs are useless, no?

nit: I think these debug logs are useless, no?
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
vng (Migrated from github.com) commented 2023-08-24 17:22:18 +00:00

nit: [@[] mutableCopy] strange construct ..

nit: ```[@[] mutableCopy]``` strange construct ..
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
vng (Migrated from github.com) commented 2023-08-24 17:20:42 +00:00

nit: Probably nil is enough here, and check nil instead of empty below

nit: Probably nil is enough here, and check nil instead of empty below
map/framework.cpp
vng (Migrated from github.com) commented 2023-08-24 17:26:38 +00:00

Remove \, it is not used in c++ (except macroses)

Remove ```\```, it is not used in c++ (except macroses)
map/routing_manager.cpp
vng (Migrated from github.com) commented 2023-08-24 17:29:07 +00:00

nit: std::move(points)

nit: std::move(points)
routing/ruler_router.cpp
vng (Migrated from github.com) commented 2023-08-24 17:33:25 +00:00

nit: Please, align params in column.

nit: Please, align params in column.
strump reviewed 2023-08-25 13:27:22 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
strump commented 2023-08-25 13:27:22 +00:00
Author
Member

Changing to nil requires changing in TransportTransitStepsCollectionView.swift field steps: [MWMRouterTransitStepInfo] to nullable type steps: [MWMRouterTransitStepInfo]? and adding nil checks all over the file. Let's keep empty array for now.

Changing to nil requires changing in `TransportTransitStepsCollectionView.swift` field `steps: [MWMRouterTransitStepInfo]` to nullable type `steps: [MWMRouterTransitStepInfo]?` and adding nil checks all over the file. Let's keep empty array for now.
strump reviewed 2023-08-25 13:28:24 +00:00
android/src/app/organicmaps/routing/RoutingController.java
strump commented 2023-08-25 13:28:24 +00:00
Author
Member

Removed debug logs in RoutingController.setEndPoint() and RoutingController.continueToPoint() methods.

Removed debug logs in `RoutingController.setEndPoint()` and `RoutingController.continueToPoint()` methods.
strump reviewed 2023-08-25 13:28:54 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
strump commented 2023-08-25 13:28:54 +00:00
Author
Member

Replaced with [NSMutableArray new].

Replaced with `[NSMutableArray new]`.
strump reviewed 2023-08-25 13:29:00 +00:00
map/framework.cpp
strump commented 2023-08-25 13:29:00 +00:00
Author
Member

Removed backslashes

Removed backslashes
strump reviewed 2023-08-25 13:29:23 +00:00
map/routing_manager.cpp
strump commented 2023-08-25 13:29:23 +00:00
Author
Member

Added std::move(points) in two places in this method.

Added `std::move(points)` in two places in this method.
strump reviewed 2023-08-25 13:29:30 +00:00
routing/ruler_router.cpp
strump commented 2023-08-25 13:29:29 +00:00
Author
Member

Fixed formatting

Fixed formatting
strump reviewed 2023-08-25 13:47:41 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager.mm
strump commented 2023-08-25 13:47:41 +00:00
Author
Member

When we build or update route from iOS UI method MWMRouter rebuildWithBestRouter: NO is invoked which changes state to MWMNavigationDashboardStatePlanning and calls RoutingManager.BuildRoute().

But with current implementation RoutingManager.BuildRoute() is invoked not from UI code but from Framework::OnTapEvent() and it doesn't trigger planning state.

When we build or update route from iOS UI method `MWMRouter rebuildWithBestRouter: NO` is invoked which changes state to `MWMNavigationDashboardStatePlanning` and calls `RoutingManager.BuildRoute()`. But with current implementation `RoutingManager.BuildRoute()` is invoked not from UI code but from `Framework::OnTapEvent()` and it doesn't trigger planning state.
vng (Migrated from github.com) approved these changes 2023-08-26 00:27:40 +00:00
vng (Migrated from github.com) left a comment

Ok, time to finally merge it, IMO.

  • Actual commits
  • [strings] Regenerated
  • [styles] Regenerated (extract drules_proto_*.txt/bin) into a separate commit
Ok, time to finally merge it, IMO. - Actual commits - [strings] Regenerated - [styles] Regenerated (extract drules_proto_*.txt/bin) into a separate commit
biodranik (Migrated from github.com) reviewed 2023-08-26 22:13:38 +00:00
biodranik (Migrated from github.com) left a comment

Thank you very much for this PR!

  1. iOS doesn't print "Distance:" label.
  2. iOS doesn't show total distance in landscape with some stops.
Thank you very much for this PR! 1. iOS doesn't print "Distance:" label. 2. iOS doesn't show total distance in landscape with some stops.
android/src/app/organicmaps/routing/RoutingBottomMenuController.java
biodranik (Migrated from github.com) commented 2023-08-26 21:46:55 +00:00 
    if (!RoutingController.get().isVehicleRouterType() && !RoutingController.get().isRulerRouterType())
```suggestion if (!RoutingController.get().isVehicleRouterType() && !RoutingController.get().isRulerRouterType()) ```
android/src/app/organicmaps/routing/RoutingBottomMenuController.java
@ -172,6 +177,53 @@ final class RoutingBottomMenuController implements View.OnClickListener
distanceView.setText(info.getTotalPedestrianDistance() + " " + info.getTotalPedestrianDistanceUnits());
biodranik (Migrated from github.com) commented 2023-08-26 21:47:36 +00:00

nit: final for non-modified variables.

nit: final for non-modified variables.
android/src/app/organicmaps/routing/RoutingBottomMenuController.java
@ -206,15 +258,18 @@ final class RoutingBottomMenuController implements View.OnClickListener
UiUtils.hide(mActionFrame);
biodranik (Migrated from github.com) commented 2023-08-26 21:48:44 +00:00 
    if (show)
    {
      mStart.setText(mContext.getText(R.string.p2p_start));
```suggestion if (show) { mStart.setText(mContext.getText(R.string.p2p_start)); ```
android/src/app/organicmaps/routing/RoutingPlanController.java
biodranik (Migrated from github.com) commented 2023-08-26 21:50:04 +00:00 
    final boolean showStartButton = !RoutingController.get().isRulerRouterType();
```suggestion final boolean showStartButton = !RoutingController.get().isRulerRouterType(); ```
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
biodranik (Migrated from github.com) commented 2023-08-26 21:51:52 +00:00 
#import <CoreApi/Framework.h>
```suggestion #import <CoreApi/Framework.h> ```
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
biodranik (Migrated from github.com) commented 2023-08-26 21:52:45 +00:00 
  NSMutableArray<MWMRouterTransitStepInfo *> *steps = [NSMutableArray arrayWithCapacity:[points count] * 2 - 1];
```suggestion NSMutableArray<MWMRouterTransitStepInfo *> *steps = [NSMutableArray arrayWithCapacity:[points count] * 2 - 1]; ```
biodranik (Migrated from github.com) commented 2023-08-26 21:53:36 +00:00

Why is the size points.count * 2 - 1?

Why is the size points.count * 2 - 1?
biodranik (Migrated from github.com) commented 2023-08-26 21:54:06 +00:00 
  for (int i = 0; i < numPoints - 1; i++) {
```suggestion for (int i = 0; i < numPoints - 1; i++) { ```
biodranik (Migrated from github.com) commented 2023-08-26 21:54:17 +00:00 
    MWMRoutePoint* segmentEnd = points[i + 1];
```suggestion MWMRoutePoint* segmentEnd = points[i + 1]; ```
biodranik (Migrated from github.com) commented 2023-08-26 21:54:35 +00:00 
        ms::DistanceOnEarth(segmentStart.latitude, segmentStart.longitude, segmentEnd.latitude, segmentEnd.longitude));
```suggestion ms::DistanceOnEarth(segmentStart.latitude, segmentStart.longitude, segmentEnd.latitude, segmentEnd.longitude)); ```
biodranik (Migrated from github.com) commented 2023-08-26 21:55:00 +00:00 
    steps[i * 2] = segmentInfo;
```suggestion steps[i * 2] = segmentInfo; ```
biodranik (Migrated from github.com) commented 2023-08-26 21:55:12 +00:00 
      steps[i * 2 + 1] = stopInfo;
```suggestion steps[i * 2 + 1] = stopInfo; ```
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
biodranik (Migrated from github.com) commented 2023-08-26 21:57:03 +00:00 
    BOOL const showEta = (type != MWMRouterTypeRuler);
```suggestion BOOL const showEta = (type != MWMRouterTypeRuler); ```
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
biodranik (Migrated from github.com) commented 2023-08-26 21:56:32 +00:00

Is this if necessary? When it can be null?

Is this if necessary? When it can be null?
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager.mm
biodranik (Migrated from github.com) commented 2023-08-26 21:58:27 +00:00 
  bool const isRuler = ([MWMRouter type] == MWMRouterTypeRuler);

nit: The length is the same, but clarity is better.

```suggestion bool const isRuler = ([MWMRouter type] == MWMRouterTypeRuler); ``` nit: The length is the same, but clarity is better.
biodranik (Migrated from github.com) commented 2023-08-26 21:59:02 +00:00 
  self.goButtonsContainer.hidden = isTransport || isRuler;

nit: Simpler is better )

```suggestion self.goButtonsContainer.hidden = isTransport || isRuler; ``` nit: Simpler is better )
iphone/Maps/Classes/CustomViews/NavigationDashboard/Views/RoutePreview/RoutePreviewStatus/TransportRoutePreviewStatus.swift
@ -39,3 +39,3 @@
}
@objc func onNavigationInfoUpdated(_ info: MWMNavigationDashboardEntity) {
@objc func onNavigationInfoUpdated(_ info: MWMNavigationDashboardEntity, prependDistance: Bool) {
biodranik (Migrated from github.com) commented 2023-08-26 22:02:00 +00:00

https://stackoverflow.com/questions/57655129/ios-autolayout-how-to-show-hide-a-view-including-its-margins

https://stackoverflow.com/questions/57655129/ios-autolayout-how-to-show-hide-a-view-including-its-margins
iphone/Maps/Classes/CustomViews/NavigationDashboard/Views/RoutePreview/RoutePreviewStatus/TransportTransitSteps/TransportTransitStepsCollectionView.swift
biodranik (Migrated from github.com) commented 2023-08-26 22:03:30 +00:00 
        TransportTransitTrain.self, TransportRuler.self].forEach {
```suggestion TransportTransitTrain.self, TransportRuler.self].forEach { ```
map/routing_manager.cpp
biodranik (Migrated from github.com) commented 2023-08-26 22:04:54 +00:00

nit: Pass one enum instead if isTransit and isRuler?

nit: Pass one enum instead if isTransit and isRuler?
map/routing_manager.cpp
biodranik (Migrated from github.com) commented 2023-08-26 22:06:26 +00:00

nit: Make pattern a recognizable constant to find and edit it easier?

nit: Make pattern a recognizable constant to find and edit it easier?
routing/ruler_router.cpp
biodranik (Migrated from github.com) commented 2023-08-26 22:08:37 +00:00

reserve?

reserve?
biodranik (Migrated from github.com) commented 2023-08-26 22:08:47 +00:00 
  times.reserve(count * 2 - 1);
```suggestion times.reserve(count * 2 - 1); ```
biodranik (Migrated from github.com) commented 2023-08-26 22:09:31 +00:00 
      turn = turns::TurnItem(i + 1, turns::PedestrianDirection::ReachedYourDestination);
```suggestion turn = turns::TurnItem(i + 1, turns::PedestrianDirection::ReachedYourDestination); ```
biodranik (Migrated from github.com) commented 2023-08-26 22:11:26 +00:00

What should be done here and why? Can the comment be updated?

What should be done here and why? Can the comment be updated?
routing/ruler_router.hpp
@ -0,0 +17,4 @@
bool FindClosestProjectionToRoad(m2::PointD const & point, m2::PointD const & direction,
double radius, EdgeProj & proj) override;
// Do we need guides in this router?
biodranik (Migrated from github.com) commented 2023-08-26 22:12:05 +00:00

What are guides?

What are guides?
strump reviewed 2023-08-27 18:15:26 +00:00
android/src/app/organicmaps/routing/RoutingBottomMenuController.java
strump commented 2023-08-27 18:15:26 +00:00
Author
Member

Fixed formatting

Fixed formatting
strump reviewed 2023-08-27 18:15:38 +00:00
android/src/app/organicmaps/routing/RoutingBottomMenuController.java
@ -172,6 +177,53 @@ final class RoutingBottomMenuController implements View.OnClickListener
distanceView.setText(info.getTotalPedestrianDistance() + " " + info.getTotalPedestrianDistanceUnits());
strump commented 2023-08-27 18:15:38 +00:00
Author
Member

Added final keyword

Added `final` keyword
strump reviewed 2023-08-27 18:15:45 +00:00
android/src/app/organicmaps/routing/RoutingBottomMenuController.java
@ -206,15 +258,18 @@ final class RoutingBottomMenuController implements View.OnClickListener
UiUtils.hide(mActionFrame);
strump commented 2023-08-27 18:15:45 +00:00
Author
Member

Fixed formatting

Fixed formatting
strump reviewed 2023-08-27 18:15:56 +00:00
android/src/app/organicmaps/routing/RoutingPlanController.java
strump commented 2023-08-27 18:15:56 +00:00
Author
Member

Added final keyword

Added `final` keyword
strump reviewed 2023-08-27 18:16:11 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
strump commented 2023-08-27 18:16:10 +00:00
Author
Member

Changed include to import.

Changed `include` to `import`.
strump reviewed 2023-08-27 18:16:25 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
strump commented 2023-08-27 18:16:25 +00:00
Author
Member

Fixed formatting. Added comment.

Fixed formatting. Added comment.
strump reviewed 2023-08-27 18:16:40 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
strump commented 2023-08-27 18:16:40 +00:00
Author
Member

Fixed formatting

Fixed formatting
strump reviewed 2023-08-27 18:16:48 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
strump commented 2023-08-27 18:16:48 +00:00
Author
Member

Fixed formatting

Fixed formatting
strump reviewed 2023-08-27 18:16:57 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
strump commented 2023-08-27 18:16:56 +00:00
Author
Member

Fixed formatting

Fixed formatting
strump reviewed 2023-08-27 18:17:03 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
strump commented 2023-08-27 18:17:03 +00:00
Author
Member

Fixed formatting

Fixed formatting
strump reviewed 2023-08-27 18:17:12 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
strump commented 2023-08-27 18:17:12 +00:00
Author
Member

Fixed formatting

Fixed formatting
strump reviewed 2023-08-27 18:17:29 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
strump commented 2023-08-27 18:17:29 +00:00
Author
Member

added const keyword

added `const` keyword
strump reviewed 2023-08-27 18:17:39 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager.mm
strump commented 2023-08-27 18:17:39 +00:00
Author
Member

Changed type to bool

Changed type to `bool`
strump reviewed 2023-08-27 18:17:49 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager.mm
strump commented 2023-08-27 18:17:49 +00:00
Author
Member

Fixed formatting

Fixed formatting
strump reviewed 2023-08-27 18:18:32 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/Views/RoutePreview/RoutePreviewStatus/TransportRoutePreviewStatus.swift
@ -39,3 +39,3 @@
}
@objc func onNavigationInfoUpdated(_ info: MWMNavigationDashboardEntity) {
@objc func onNavigationInfoUpdated(_ info: MWMNavigationDashboardEntity, prependDistance: Bool) {
strump commented 2023-08-27 18:18:31 +00:00
Author
Member

There was a problem with panel min height = 80. I changed constraint to have height >= 40 and no more empty space ))

There was a problem with panel min height = 80. I changed constraint to have height >= 40 and no more empty space ))
strump reviewed 2023-08-27 18:19:38 +00:00
routing/ruler_router.cpp
strump commented 2023-08-27 18:19:38 +00:00
Author
Member

Added .reserve()

Added `.reserve()`
strump reviewed 2023-08-27 18:19:49 +00:00
routing/ruler_router.cpp
strump commented 2023-08-27 18:19:49 +00:00
Author
Member

Fixed formatting

Fixed formatting
strump reviewed 2023-08-27 18:19:57 +00:00
routing/ruler_router.cpp
strump commented 2023-08-27 18:19:57 +00:00
Author
Member

Fixed formatting

Fixed formatting
strump reviewed 2023-08-28 06:37:13 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
strump commented 2023-08-28 06:37:12 +00:00
Author
Member

This if was added from the very first commit of MWMNavigationDashboardManager+Entity.mm file in 2017. See commit #55b0d06.

This `if` was added from the very first commit of `MWMNavigationDashboardManager+Entity.mm` file in 2017. See [commit #55b0d06](https://git.omaps.dev/organicmaps/organicmaps/commit/55b0d067b72f6531925ba19668472bf2c94c6e2f#diff-5b0565a7871c4509d57c69521ef204faf379a643b95c8dc429b5778a7da31c4bR83).
biodranik (Migrated from github.com) reviewed 2023-08-28 06:58:50 +00:00
iphone/Maps/Classes/CustomViews/NavigationDashboard/MWMNavigationDashboardManager+Entity.mm
biodranik (Migrated from github.com) commented 2023-08-28 06:58:50 +00:00

It would be great to understand the logic now and fix it if necessary.

It would be great to understand the logic now and fix it if necessary.
strump reviewed 2023-08-28 08:25:22 +00:00
routing/ruler_router.cpp
strump commented 2023-08-28 08:25:22 +00:00
Author
Member

Changed comment. Now it tells Ruler router has no connection to road graph.

Changed comment. Now it tells `Ruler router has no connection to road graph.`
strump reviewed 2023-08-28 08:25:36 +00:00
map/routing_manager.cpp
strump commented 2023-08-28 08:25:36 +00:00
Author
Member

Replaced flags with enum

Replaced flags with enum
strump reviewed 2023-08-28 08:28:43 +00:00
map/routing_manager.cpp
strump commented 2023-08-28 08:28:42 +00:00
Author
Member

nit: We should provide constans for Pedestrian and Bycicle dashed lines too. Maybe move those parameters to MapCSS as we did with RouteBicycle-color, RouteRuler-color?

nit: We should provide constans for Pedestrian and Bycicle dashed lines too. Maybe move those parameters to MapCSS as we did with `RouteBicycle-color`, `RouteRuler-color`?
biodranik (Migrated from github.com) reviewed 2023-09-01 06:07:00 +00:00
map/routing_manager.cpp
biodranik (Migrated from github.com) commented 2023-09-01 06:07:00 +00:00

That is a good idea!

That is a good idea!
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Jean-BaptisteC
vng
Labels
Clear labels   
Accessibility

issues affecting users with specific needs

  
Accessibility

issues affecting users with specific needs

  
Address

Issues with addresses, post codes, city/town/village borders

  
Address

Issues with addresses, post codes, city/town/village borders

  
Android

Android development

  
Android

Android development

  
Android Auto

Android Auto

  
Android Auto

Android Auto

  
Android Automotive (AAOS)

   
Android Automotive (AAOS)

   
API

Short Links, deep links and url schemes, including ge0 and om://

  
API

Short Links, deep links and url schemes, including ge0 and om://

  
AppGallery

Huawei AppGallery

  
AppGallery

Huawei AppGallery

  
AppStore

Apple AppStore

  
AppStore

Apple AppStore

  
Battery and Performance

Performance and battery consumption-related issues and optimizations

  
Battery and Performance

Performance and battery consumption-related issues and optimizations

  
Blocker

An issue blocking the release

  
Blocker

An issue blocking the release

  
Bookmarks and Tracks

Bookmarks, imported tracks, and KML, KMZ, KMB, GPX, GPZ import or export

  
Bookmarks and Tracks

Bookmarks, imported tracks, and KML, KMZ, KMB, GPX, GPZ import or export

  
Borders

Country borders and polygons

  
Borders

Country borders and polygons

  
Bug

Something isn't working

  
Bug

Something isn't working

  
Build

Compilation issue

  
Build

Compilation issue

  
CarPlay

CarPlay Integration

  
CarPlay

CarPlay Integration

  
Classificator

Classify object by types

  
Classificator

Classify object by types

  
Community

Community relations

  
Community

Community relations

  
Core

Cross-platform C++ libraries with a core functionality

  
Core

Cross-platform C++ libraries with a core functionality

  
CrashReports

Crash Reporting

  
CrashReports

Crash Reporting

  
Cycling

Bike, cycle, biking and related

  
Cycling

Bike, cycle, biking and related

  
Desktop

Desktop application

  
Desktop

Desktop application

  
DevEx

Developer Experience

  
DevEx

Developer Experience

  
DevOps

Automation and pipelines

  
DevOps

Automation and pipelines

  
dev_sandbox

A desktop app to debug rendering

  
dev_sandbox

A desktop app to debug rendering

  
Directions

Issues with next turns, labels, streets, voice instructions

  
Directions

Issues with next turns, labels, streets, voice instructions

  
Documentation

Improvements or additions to documentation

  
Documentation

Improvements or additions to documentation

  
Downloader

Map dowloader

  
Downloader

Map dowloader

  
Drape

Drape OpenGL, Vulkan and Metal graphics rendering engine

  
Drape

Drape OpenGL, Vulkan and Metal graphics rendering engine

  
Driving

Drive a car related issues

  
Driving

Drive a car related issues

  
Duplicate

This issue or pull request already exists

  
Duplicate

This issue or pull request already exists

  
Editor

OSM Editor

  
Editor

OSM Editor

  
Elevation

Isolines and altitude

  
Elevation

Isolines and altitude

  
Enhancement

New feature or request, an improvement of some existing feature

  
Enhancement

New feature or request, an improvement of some existing feature

  
Epic

A large body work

  
Epic

A large body work

  
External Map Datasets

TIGER, Ordnance Survey, ASTER, SRTM, etc.

  
External Map Datasets

TIGER, Ordnance Survey, ASTER, SRTM, etc.

  
F-Droid

F-Droid build and distribution

  
F-Droid

F-Droid build and distribution

  
Fonts

Font and text rendering

  
Fonts

Font and text rendering

  
Frequently User Reported

Most annoying UX and other issues for users reported by many people

  
Frequently User Reported

Most annoying UX and other issues for users reported by many people

  
Fund

   
Fund

   
Generator

Related to generator tool.

  
Generator

Related to generator tool.

  
Good first issue

Good for newcomers

  
Good first issue

Good for newcomers

  
Google Play

Google Play

  
Google Play

Google Play

  
GPS

Location and positioning issues

  
GPS

Location and positioning issues

  
GSoC

Ideas for Google Summer of Code

  
GSoC

Ideas for Google Summer of Code

  
iCloud

   
iCloud

   
Icons

Map and app icons

  
Icons

Map and app icons

  
iOS

iOS development

  
iOS

iOS development

  
Legal

Legal aspects

  
Legal

Legal aspects

  
Linux Desktop

Ubuntu, Gentoo, Red Hat, Debian, Cent OS, Fedora, etc.

  
Linux Desktop

Ubuntu, Gentoo, Red Hat, Debian, Cent OS, Fedora, etc.

  
Linux packaging

   
Linux packaging

   
Linux Phone

LibreM, PinePhone, Wayland and other mobile Linux versions

  
Linux Phone

LibreM, PinePhone, Wayland and other mobile Linux versions

  
Mac OS

Desktop issues related to Mac OS X, OM running on M1, M2, M3 Apple silicon, or Qt version

  
Mac OS

Desktop issues related to Mac OS X, OM running on M1, M2, M3 Apple silicon, or Qt version

  
Map Data

OpenStreetMap data related issues

  
Map Data

OpenStreetMap data related issues

  
Metro

Subway, Tube, light-rail public transport issues

  
Metro

Subway, Tube, light-rail public transport issues

  
Navigation

Issues related to the active Navigator / Navigation mode

  
Navigation

Issues related to the active Navigator / Navigation mode

  
Need Feedback

Further information is requested

  
Need Feedback

Further information is requested

  
Night Mode

Night or dark mode feature

  
Night Mode

Night or dark mode feature

  
NLnet 2024-06-281

Tasks related to NLnet 2024-06-281 project.

  
NLnet 2024-06-281

Tasks related to NLnet 2024-06-281 project.

  
No Feature Parity

A platform needs this to be implemented to have feature parity with other platforms

  
No Feature Parity

A platform needs this to be implemented to have feature parity with other platforms

  
Opening Hours

Business Hours, off time, holidays, seasonal

  
Opening Hours

Business Hours, off time, holidays, seasonal

  
Outdoors

Hiking, mtb, 4x4...

  
Outdoors

Hiking, mtb, 4x4...

  
POI Info

Feature metadata, OSM tags that are displayed in Place Page

  
POI Info

Feature metadata, OSM tags that are displayed in Place Page

  
Privacy

Privacy

  
Privacy

Privacy

  
Public Transport

Bus, trolleybus, train, tram, metro, subway, light rail

  
Public Transport

Bus, trolleybus, train, tram, metro, subway, light rail

  
Raw Idea

An idea that needs to be elaborated

  
Raw Idea

An idea that needs to be elaborated

  
Refactoring

   
Refactoring

   
Regional

This issue is different depending on the country or region

  
Regional

This issue is different depending on the country or region

  
Regression

A regression bug

  
Regression

A regression bug

  
Releases

Meta-tickets for tracking the release procedure

  
Releases

Meta-tickets for tracking the release procedure

  
RoboTest

Robo / Monkey Auto Tests

  
RoboTest

Robo / Monkey Auto Tests

  
Route Planning

Preview and plan your track

  
Route Planning

Preview and plan your track

  
Routing

Route building issues, e.g. valid route, valid ETA

  
Routing

Route building issues, e.g. valid route, valid ETA

  
Ruler

Helicopter routing, "as a crow flies"

  
Ruler

Helicopter routing, "as a crow flies"

  
Search

Search

  
Search

Search

  
Security

Security improvements

  
Security

Security improvements

  
Styles

Map drawing styles

  
Styles

Map drawing styles

  
Tests

   
Tests

   
Track Recording

Track Recording

  
Track Recording

Track Recording

  
Translations

Localization and translations issues

  
Translations

Localization and translations issues

  
TTS

Text-to-Speech

  
TTS

Text-to-Speech

  
UI

User interface issues

  
UI

User interface issues

  
UX

User eXperience, an issue with usability

  
UX

User eXperience, an issue with usability

  
Walk Navigation

Foot pedestrian mode

  
Walk Navigation

Foot pedestrian mode

  
Watches

Android Watches or Apple Watches support

  
Watches

Android Watches or Apple Watches support

  
Web

https://organicmaps.app/

  
Web

https://organicmaps.app/

  
Wikipedia

Issues related to Wiki articles embedded in OM data files.

  
Wikipedia

Issues related to Wiki articles embedded in OM data files.

  
Windows

Windows

  
Windows

Windows

  
Won't fix

Unfeasible or impossible to resolve

  
Won't fix

Unfeasible or impossible to resolve

  
World Map

Issues about improving the base map of the whole world that is bundled with the app

  
World Map

Issues about improving the base map of the whole world that is bundled with the app

No labels
Accessibility
Accessibility
Address
Address
Android
Android
Android Auto
Android Auto
Android Automotive (AAOS)
Android Automotive (AAOS)
API
API
AppGallery
AppGallery
AppStore
AppStore
Battery and Performance
Battery and Performance
Blocker
Blocker
Bookmarks and Tracks
Bookmarks and Tracks
Borders
Borders
Bug
Bug
Build
Build
CarPlay
CarPlay
Classificator
Classificator
Community
Community
Core
Core
CrashReports
CrashReports
Cycling
Cycling
Desktop
Desktop
DevEx
DevEx
DevOps
DevOps
dev_sandbox
dev_sandbox
Directions
Directions
Documentation
Documentation
Downloader
Downloader
Drape
Drape
Driving
Driving
Duplicate
Duplicate
Editor
Editor
Elevation
Elevation
Enhancement
Enhancement
Epic
Epic
External Map Datasets
External Map Datasets
F-Droid
F-Droid
Fonts
Fonts
Frequently User Reported
Frequently User Reported
Fund
Fund
Generator
Generator
Good first issue
Good first issue
Google Play
Google Play
GPS
GPS
GSoC
GSoC
iCloud
iCloud
Icons
Icons
iOS
iOS
Legal
Legal
Linux Desktop
Linux Desktop
Linux packaging
Linux packaging
Linux Phone
Linux Phone
Mac OS
Mac OS
Map Data
Map Data
Metro
Metro
Navigation
Navigation
Need Feedback
Need Feedback
Night Mode
Night Mode
NLnet 2024-06-281
NLnet 2024-06-281
No Feature Parity
No Feature Parity
Opening Hours
Opening Hours
Outdoors
Outdoors
POI Info
POI Info
Privacy
Privacy
Public Transport
Public Transport
Raw Idea
Raw Idea
Refactoring
Refactoring
Regional
Regional
Regression
Regression
Releases
Releases
RoboTest
RoboTest
Route Planning
Route Planning
Routing
Routing
Ruler
Ruler
Search
Search
Security
Security
Styles
Styles
Tests
Tests
Track Recording
Track Recording
Translations
Translations
TTS
TTS
UI
UI
UX
UX
Walk Navigation
Walk Navigation
Watches
Watches
Web
Web
Wikipedia
Wikipedia
Windows
Windows
Won't fix
Won't fix
World Map
World Map
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#5381
No description provided.
Delete branch "helicopter-navigation-v2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?