WIP: WIP Make major trails more visible than regular ones #5415

Draft

pastk wants to merge 5 commits from pastk-classif-hiking-routes into master

pastk commented

2023-06-30 16:46:44 +00:00

Member

So far just a prototype of case 1. from organicmaps/organicmaps#2185 (comment). Sharing it to discuss the approach / new classification.

The basic idea is to add e.g. highway-path-major for trails which are either popular or physically prominent; any of:

members of route=hiking relations
has a name
has a good quality surface
... good visibility, maybe easy sac_scale, length, other ideas...
Maybe for the main style it'll be just enough to display routes earlier. My concern with the routes-only approach though is that it will work well in well-mapped areas with wide route networks only (e.g. Europe). But e.g. in Turkey or Russia there could be a few routes mapped for the whole country, hence we need another way to identify major trails (named, good surface, etc.) So for the outdoors style we might split into more types even e.g. highway-path-route / highway-path-major / highway-path...

Following screenshots are just demos showing why a trail is considered "major" - reds are routes, blues are named, greens has a good surface.

Now questions to discuss and challenges..

We have a lot of subtypes for highway-path and -track already and looks like the most of them are not actually used - they use the same style and only tranlations are sometimes different.

And the way they're matched now is not good.
E.g. a feature highway=path sac_scale=hiking horse=yes bicycle=yes access=permissive bridge=yes will have 5 OM types
highway-path-bicycle highway-path-horse highway-path-hiking highway-path-permissive highway-path-bridge
with exactly same dashed line style. So.. the renderer will render the same line 5 times! (see e.g. organicmaps/organicmaps#5414).

Of course, if there is a route relation we can just add a highway-path-major into the mix. And it's line will be thicker and visible earlier. Still the renderer will attempt to draw all X lines :)

Maybe some of those types we can remap, e.g. bicyle=yes into a cycleway, horse=yes into a bridleway..
@vng are e.g. highway-path-permissive and highway-track-no-access used in the routing?

But what do we do with sac_scale=?

We can double all the types by adding e.g. highway-path-major-hiking highway-path-major-mountain_hiking etc. of course..

Also, how are we going to translate those types?

So far just a prototype of case 1. from https://git.omaps.dev/organicmaps/organicmaps/issues/2185#issuecomment-1614907113. Sharing it to discuss the approach / new classification. The basic idea is to add e.g. `highway-path-major` for trails which are either popular or physically prominent; any of: - members of `route=hiking` relations - has a name - has a good quality surface - ... good visibility, maybe easy `sac_scale`, length, other ideas... Maybe for the main style it'll be just enough to display routes earlier. My concern with the routes-only approach though is that it will work well in well-mapped areas with wide route networks only (e.g. Europe). But e.g. in Turkey or Russia there could be a few routes mapped for the whole country, hence we need another way to identify major trails (named, good surface, etc.) So for the outdoors style we might split into more types even e.g. `highway-path-route / highway-path-major / highway-path`... Following screenshots are just demos showing why a trail is considered "major" - reds are routes, blues are named, greens has a good surface. ![highway-path-major](https://github.com/organicmaps/organicmaps/assets/18434508/21e34210-4256-4985-a9db-9a513b0ffa59) Now questions to discuss and challenges.. We have a lot of subtypes for `highway-path` and `-track` already and looks like the most of them are not actually used - they use the same style and only tranlations are *sometimes* different. And the way they're matched now is not good. E.g. a feature `highway=path sac_scale=hiking horse=yes bicycle=yes access=permissive bridge=yes` will have 5 OM types `highway-path-bicycle highway-path-horse highway-path-hiking highway-path-permissive highway-path-bridge` with exactly same dashed line style. So.. the renderer will render the same line 5 times! (see e.g. https://git.omaps.dev/organicmaps/organicmaps/issues/5414). Of course, if there is a route relation we can just add a `highway-path-major` into the mix. And it's line will be thicker and visible earlier. Still the renderer will attempt to draw all X lines :) Maybe some of those types we can remap, e.g. `bicyle=yes` into a cycleway, `horse=yes` into a bridleway.. @vng are e.g. `highway-path-permissive` and `highway-track-no-access` used in the routing? But what do we do with `sac_scale=`? We can double all the types by adding e.g. `highway-path-major-hiking highway-path-major-mountain_hiking etc.` of course.. Also, how are we going to translate those types?

biodranik (Migrated from github.com) reviewed 2023-06-30 16:46:44 +00:00

vng (Migrated from github.com) reviewed 2023-06-30 16:46:44 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

biodranik

vng