[tests] Fix distance formatting tests using system locale #6470

gpesquero · 2023-11-04T23:57:43Z

gpesquero commented

2023-11-04 23:57:43 +00:00

This PR fixes distance formatting tests on macOS, as this platform uses system locale for formatting.

vng (Migrated from github.com) reviewed 2023-11-04 23:57:43 +00:00

biodranik (Migrated from github.com) reviewed 2024-02-28 22:30:14 +00:00

platform/platform_tests/distance_tests.cpp

					
				@ -82,4 +88,4 @@

				  }

				  {

				    ScopedSettings const guard(measurement_utils::Units::Imperial);

biodranik (Migrated from github.com) commented

2024-02-28 22:30:14 +00:00

Is there an option to set/override the locale from the test, so we can check different separators for different locales explicitly?

gpesquero reviewed 2024-03-03 15:39:14 +00:00

platform/platform_tests/distance_tests.cpp

					
				@ -82,4 +88,4 @@

				  }

				  {

				    ScopedSettings const guard(measurement_utils::Units::Imperial);

gpesquero commented

2024-03-03 15:39:14 +00:00

Hi @biodranik: I'm afraid that with the current implementation, we may not be able to test the Distance::FormatAltitude() function for different locales.

The main reason is that this function calls the measurement_utils::ToStringPrecision() function, which uses a static variable to store the locale to use. This locale is therefore updated only in the first iteration, so if we change the locale during the tests, it won't have any effect.

We could change the behavior of the measurement_utils::ToStringPrecision() function by removing this static variable, but that would lead to a worse runtime performance.

Hi @biodranik: I'm afraid that with the current implementation, we may not be able to test the `Distance::FormatAltitude()` function for different locales. The main reason is that this function calls the `measurement_utils::ToStringPrecision()` function, which uses a static variable to store the locale to use. This locale is therefore updated only in the first iteration, so if we change the locale during the tests, it won't have any effect. We could change the behavior of the `measurement_utils::ToStringPrecision()` function by removing this static variable, but that would lead to a worse runtime performance.

 @ -0,0 +54,4 @@
 {
   std::string out;
   if (valueString.find(".") != std::string::npos)

Rows
Columns