WIP: [styles] Add Turkey road shield #7153

2024-01-12T17:02:28Z

ahmetlii commented

2024-01-12 17:02:28 +00:00

(Migrated from github.com)

Added road shields for Turkish motorways and state highways.

jfitie (Migrated from github.com) reviewed 2024-01-12 19:21:23 +00:00

indexer/road_shields_parser.cpp

jfitie (Migrated from github.com) commented

2024-01-12 19:21:23 +00:00

TurkeyRoadShieldParser?

vng (Migrated from github.com) reviewed 2024-01-13 11:22:02 +00:00

indexer/road_shields_parser.cpp

vng (Migrated from github.com) commented

2024-01-13 11:22:02 +00:00

It won't compile like this.
Remove (comment) "NumericRoadShieldParser" entry and leave todo. So we can merge your PR now, and I can think about how to implement it properly later.

It won't compile like this. Remove (comment) "NumericRoadShieldParser" entry and leave todo. So we can merge your PR now, and I can think about how to implement it properly later.

vng (Migrated from github.com) reviewed 2024-01-13 11:34:01 +00:00

indexer/road_shields_parser.cpp

					
				@ -74,1 +74,4 @@

				    {"pl:local", RoadShieldType::Generic_White},

				    {"tr:motorway", RoadShieldType::Generic_Orange},

				    {"tr:road", RoadShieldType::Generic_Blue},

				    {"tr:provincial", RoadShieldType::Generic_White},

vng (Migrated from github.com) commented

2024-01-13 11:34:01 +00:00

Where are these come from?
When I make the overpass query like "network"~"tr:" (https://overpass-turbo.eu/s/1FVM), I got nothing.

Where are these come from? When I make the overpass query like "network"~"tr:" (https://overpass-turbo.eu/s/1FVM), I got nothing.

ahmetlii (Migrated from github.com) reviewed 2024-01-13 11:47:40 +00:00

indexer/road_shields_parser.cpp

					
				@ -74,1 +74,4 @@

				    {"pl:local", RoadShieldType::Generic_White},

				    {"tr:motorway", RoadShieldType::Generic_Orange},

				    {"tr:road", RoadShieldType::Generic_Blue},

				    {"tr:provincial", RoadShieldType::Generic_White},

ahmetlii (Migrated from github.com) commented

2024-01-13 11:47:40 +00:00

I didn't realize that it was case-sensitive and thought it wasn't strictly matching. Here are example relations:
TR:motorway
TR-roads
TR:provincial - only one available as a relation

I didn't realize that it was case-sensitive and thought it wasn't strictly matching. Here are example relations: [TR:motorway](https://www.openstreetmap.org/relation/153991) [TR-roads](https://www.openstreetmap.org/relation/1720464) [TR:provincial - only one available as a relation](https://www.openstreetmap.org/relation/16142889)

vng (Migrated from github.com) reviewed 2024-01-13 12:00:43 +00:00

indexer/road_shields_parser.cpp

					
				@ -74,1 +74,4 @@

				    {"pl:local", RoadShieldType::Generic_White},

				    {"tr:motorway", RoadShieldType::Generic_Orange},

				    {"tr:road", RoadShieldType::Generic_Blue},

				    {"tr:provincial", RoadShieldType::Generic_White},

vng (Migrated from github.com) commented

2024-01-13 12:00:43 +00:00

Yes, the processing is case sensitive.
Fix TR and dash and add unit tests here: road_shields_parser_tests.cpp

Yes, the processing is case sensitive. Fix TR and dash and add unit tests here: road_shields_parser_tests.cpp

ahmetlii (Migrated from github.com) reviewed 2024-01-13 12:21:59 +00:00

indexer/road_shields_parser.cpp

					
				@ -74,1 +74,4 @@

				    {"pl:local", RoadShieldType::Generic_White},

				    {"tr:motorway", RoadShieldType::Generic_Orange},

				    {"tr:road", RoadShieldType::Generic_Blue},

				    {"tr:provincial", RoadShieldType::Generic_White},

ahmetlii (Migrated from github.com) commented

2024-01-13 12:21:59 +00:00

Honestly, after thinking about it a bit more, the implementation can wait; because the data on OpenStreetMap is very inconsistent. There are many problems lying with motorway/state road relations, namely:

some motorway relations include their motorway_link junctions.
some portions of state roads are mapped with subsection number (example) on their ref tag.
there is no consistency with the variants of "D".
and finally, motorway sections on construction are included inside Turkish motorway road network relation or existing motorway relations, in turn which makes the situation worse.

I'd like to consult with the local community and take at least some action towards standardizing reference and relation tags, before going further with this pull request.

Honestly, after thinking about it a bit more, the implementation can wait; because the data on OpenStreetMap is very inconsistent. There are many problems lying with motorway/state road relations, namely: - some motorway relations include their motorway_link junctions. - some portions of state roads are mapped with subsection number ([example](https://www.openstreetmap.org/way/191189583)) on their ref tag. - there is no consistency with the variants of "D". - and finally, motorway sections on construction are included inside Turkish motorway road network relation or existing motorway relations, in turn which makes the situation worse. I'd like to consult with the local community and take at least some action towards standardizing reference and relation tags, before going further with this pull request.

vng (Migrated from github.com) reviewed 2024-01-13 13:08:14 +00:00

indexer/road_shields_parser.cpp

					
				@ -74,1 +74,4 @@

				    {"pl:local", RoadShieldType::Generic_White},

				    {"tr:motorway", RoadShieldType::Generic_Orange},

				    {"tr:road", RoadShieldType::Generic_Blue},

				    {"tr:provincial", RoadShieldType::Generic_White},