WIP: [android] Improve phone fragment #7259

2024-01-28T14:47:44Z

Jean-BaptisteC commented

2024-01-28 14:47:44 +00:00

(Migrated from github.com)

This PR adds:

Phone FAB instead textview to add new phone number
Improve how the keyboard is managed

Following suggestion mentioned here

TODO:

Give focus to the last item of recycler view
Close keyboard when user cancel or apply changes -> need to be tested on old devices

This PR adds: - Phone FAB instead textview to add new phone number - Improve how the keyboard is managed Following suggestion mentioned [here](https://git.omaps.dev/organicmaps/organicmaps/pulls/6765#issuecomment-1846135967) TODO: - [ ] Give focus to the last item of recycler view - [ ] Close keyboard when user cancel or apply changes -> need to be tested on old devices

biodranik (Migrated from github.com) reviewed 2024-01-28 20:20:01 +00:00

biodranik (Migrated from github.com) left a comment

2024-01-28 22:19:19.034  3804-3804  AndroidRuntime          app.organicmaps.debug                E  FATAL EXCEPTION: main
                                                                                                    Process: app.organicmaps.debug, PID: 3804
                                                                                                    java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.view.View.requestFocus()' on a null object reference
                                                                                                    	at app.organicmaps.editor.data.PhoneFragment.onViewCreated(PhoneFragment.java:57)
                                                                                                    	at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:3147)
                                                                                                    	at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:588)
                                                                                                    	at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:272)
                                                                                                    	at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1943)
                                                                                                    	at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1839)
                                                                                                    	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1782)
                                                                                                    	at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:565)
                                                                                                    	at android.os.Handler.handleCallback(Handler.java:739)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:95)
                                                                                                    	at android.os.Looper.loop(Looper.java:135)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:5221)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at java.lang.reflect.Method.invoke(Method.java:372)
                                                                                                    	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)

``` 2024-01-28 22:19:19.034 3804-3804 AndroidRuntime app.organicmaps.debug E FATAL EXCEPTION: main Process: app.organicmaps.debug, PID: 3804 java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.view.View.requestFocus()' on a null object reference at app.organicmaps.editor.data.PhoneFragment.onViewCreated(PhoneFragment.java:57) at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:3147) at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:588) at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:272) at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1943) at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1839) at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1782) at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:565) at android.os.Handler.handleCallback(Handler.java:739) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:135) at android.app.ActivityThread.main(ActivityThread.java:5221) at java.lang.reflect.Method.invoke(Native Method) at java.lang.reflect.Method.invoke(Method.java:372) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694) ```

 @ -22,3 +24,4 @@
   final Integer maxAdapter = 5;
   @Override
   public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState)

Rows
Columns