Improve desktop place page dialog #7505

Merged
Ferenc- merged 12 commits from improve-desktop-place-page-dialog into master 2024-03-23 21:56:49 +00:00
10 changed files with 316 additions and 14 deletions

View file

@ -21,6 +21,7 @@ namespace settings
using namespace std;
char const * kMeasurementUnits = "Units";
char const * kDeveloperMode = "DeveloperMode";
StringStorage::StringStorage() : StringStorageBase(GetPlatform().SettingsPathForFile(SETTINGS_FILE_NAME)) {}

View file

@ -11,6 +11,8 @@ namespace settings
/// Metric or Imperial.
extern char const * kMeasurementUnits;
extern char const * kDeveloperMode;
template <class T>
bool FromString(std::string const & str, T & outValue);

View file

@ -36,8 +36,10 @@ set(SRC
mwms_borders_selection.hpp
osm_auth_dialog.cpp
osm_auth_dialog.hpp
place_page_dialog.cpp
place_page_dialog.hpp
place_page_dialog_developer.cpp
place_page_dialog_developer.hpp
place_page_dialog_user.cpp
place_page_dialog_user.hpp
preferences_dialog.cpp
preferences_dialog.hpp
popup_menu_holder.cpp

View file

@ -2,7 +2,8 @@
#include "qt/create_feature_dialog.hpp"
#include "qt/editor_dialog.hpp"
#include "qt/place_page_dialog.hpp"
#include "qt/place_page_dialog_developer.hpp"
#include "qt/place_page_dialog_user.hpp"
#include "qt/qt_common/helpers.hpp"
#include "qt/routing_settings_dialog.hpp"
#include "qt/screenshoter.hpp"
@ -649,8 +650,14 @@ void DrawWidget::ShowPlacePage()
address = m_framework.GetAddressAtPoint(info.GetMercator());
}
PlacePageDialog dlg(this, info, address);
if (dlg.exec() == QDialog::Accepted)
std::unique_ptr<QDialog> placePageDialog = nullptr;
bool developerMode;
if (settings::Get(settings::kDeveloperMode, developerMode) && developerMode)
placePageDialog = std::make_unique<PlacePageDialogDeveloper>(this, info, address);
else
placePageDialog = std::make_unique<PlacePageDialogUser>(this, info, address);
if (placePageDialog->exec() == QDialog::Accepted)
{
osm::EditableMapObject emo;
if (m_framework.GetEditableMapObject(info.GetID(), emo))

View file

@ -148,6 +148,16 @@ int main(int argc, char * argv[])
QApplication::setApplicationName("Organic Maps");
#endif
#ifdef DEBUG
static bool constexpr developerMode = true;
#else
static bool constexpr developerMode = false;
#endif
bool outvalue;
if (!settings::Get(settings::kDeveloperMode, outvalue))
settings::Set(settings::kDeveloperMode, developerMode);
// Display EULA if needed.
char const * settingsEULA = "EulaAccepted";
bool eulaAccepted = false;

View file

@ -1,4 +1,4 @@
#include "qt/place_page_dialog.hpp"
#include "qt/place_page_dialog_developer.hpp"
#include "qt/qt_common/text_dialog.hpp"
@ -12,8 +12,8 @@
#include <string>
PlacePageDialog::PlacePageDialog(QWidget * parent, place_page::Info const & info,
search::ReverseGeocoder::Address const & address)
PlacePageDialogDeveloper::PlacePageDialogDeveloper(QWidget * parent, place_page::Info const & info,
search::ReverseGeocoder::Address const & address)
: QDialog(parent)
{
QGridLayout * grid = new QGridLayout();
@ -86,13 +86,13 @@ PlacePageDialog::PlacePageDialog(QWidget * parent, place_page::Info const & info
QDialogButtonBox * dbb = new QDialogButtonBox();
QPushButton * closeButton = new QPushButton("Close");
closeButton->setDefault(true);
connect(closeButton, &QAbstractButton::clicked, this, &PlacePageDialog::OnClose);
connect(closeButton, &QAbstractButton::clicked, this, &PlacePageDialogDeveloper::OnClose);
dbb->addButton(closeButton, QDialogButtonBox::RejectRole);
if (info.ShouldShowEditPlace())
{
QPushButton * editButton = new QPushButton("Edit Place");
connect(editButton, &QAbstractButton::clicked, this, &PlacePageDialog::OnEdit);
connect(editButton, &QAbstractButton::clicked, this, &PlacePageDialogDeveloper::OnEdit);
dbb->addButton(editButton, QDialogButtonBox::AcceptRole);
}
@ -137,5 +137,5 @@ PlacePageDialog::PlacePageDialog(QWidget * parent, place_page::Info const & info
setWindowTitle(ppTitle.c_str());
}
void PlacePageDialog::OnClose() { reject(); }
void PlacePageDialog::OnEdit() { accept(); }
void PlacePageDialogDeveloper::OnClose() { reject(); }
void PlacePageDialogDeveloper::OnEdit() { accept(); }

View file

@ -0,0 +1,22 @@
#pragma once
#include "search/reverse_geocoder.hpp"
#include <QtWidgets/QDialog>
namespace place_page
{
class Info;
}
class PlacePageDialogDeveloper : public QDialog
{
Q_OBJECT
public:
PlacePageDialogDeveloper(QWidget * parent, place_page::Info const & info,
search::ReverseGeocoder::Address const & address);
private slots:
void OnClose();
void OnEdit();
};

View file

@ -0,0 +1,246 @@
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
#include "qt/place_page_dialog_user.hpp"
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
#include "qt/qt_common/text_dialog.hpp"
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
#include "map/place_page_info.hpp"
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
#include "indexer/validate_and_format_contacts.hpp"
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
#include "platform/settings.hpp"
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
#include <QtWidgets/QDialogButtonBox>
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
#include <QtWidgets/QGridLayout>
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
#include <QtWidgets/QHBoxLayout>
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
#include <QtWidgets/QLabel>
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
#include <QtWidgets/QPushButton>
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
#include <QtWidgets/QBoxLayout>
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
#include <QtWidgets/QDialog>
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
#include <QtWidgets/QGridLayout>
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
#include <sstream>
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
#include <string>
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
namespace
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
static int constexpr kMaxLengthOfPlacePageDescription = 500;
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
static int constexpr kMinWidthOfShortDescription = 390;
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
std::string_view stripSchemeFromURI(std::string_view uri) {
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
for (std::string_view prefix : {"https://", "http://"})
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (strings::StartsWith(uri, prefix))
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
return uri.substr(prefix.size());
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
return uri;
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
} // namespace
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
class QHLine : public QFrame
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
public:
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
QHLine(QWidget * parent = nullptr) : QFrame(parent)
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
setFrameShape(QFrame::HLine);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
setFrameShadow(QFrame::Sunken);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
};
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
PlacePageDialogUser::PlacePageDialogUser(QWidget * parent, place_page::Info const & info,
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
search::ReverseGeocoder::Address const & address)
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
: QDialog(parent)
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
auto const & title = info.GetTitle();
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
QVBoxLayout * layout = new QVBoxLayout();
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
QVBoxLayout * header = new QVBoxLayout();
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (!title.empty())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
header->addWidget(new QLabel(QString::fromStdString("<h1>" + title + "</h1>")));
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (auto subTitle = info.GetSubtitle(); !subTitle.empty())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
header->addWidget(new QLabel(QString::fromStdString(subTitle)));
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (auto addressFormatted = address.FormatAddress(); !addressFormatted.empty())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
header->addWidget(new QLabel(QString::fromStdString(addressFormatted)));
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
layout->addLayout(header);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
QHLine * line = new QHLine();
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
layout->addWidget(line);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
QGridLayout * data = new QGridLayout();
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
int row = 0;
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
auto const addEntry = [data, &row](std::string const & key, std::string const & value, bool isLink = false)
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
data->addWidget(new QLabel(QString::fromStdString(key)), row, 0);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
QLabel * label = new QLabel(QString::fromStdString(value));
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
label->setTextInteractionFlags(Qt::TextSelectableByMouse);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (isLink)
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
label->setOpenExternalLinks(true);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
label->setTextInteractionFlags(Qt::TextBrowserInteraction);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
label->setText(QString::fromStdString("<a href=\"" + value + "\">" + value + "</a>"));
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
data->addWidget(label, row++, 1);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
return label;
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
};
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (info.IsBookmark())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
addEntry("Bookmark", "Yes");
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
// Wikipedia fragment
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (auto const & wikipedia = info.GetMetadata(feature::Metadata::EType::FMD_WIKIPEDIA); !wikipedia.empty())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
QLabel * name = new QLabel("Wikipedia");
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
name->setOpenExternalLinks(true);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
name->setTextInteractionFlags(Qt::TextBrowserInteraction);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
name->setText(QString::fromStdString("<a href=\"" + feature::Metadata::ToWikiURL(std::string(wikipedia)) + "\">Wikipedia</a>"));
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
data->addWidget(name, row++, 0);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
// Description
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (auto description = info.GetWikiDescription(); !description.empty())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
QPushButton * wikiButton = new QPushButton("Wikipedia Description");
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
wikiButton->setAutoDefault(false);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
connect(wikiButton, &QAbstractButton::clicked, this, [this, description, title]()
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
auto textDialog = TextDialog(this, QString::fromStdString(description), QString::fromStdString("Wikipedia: " + title));
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
textDialog.exec();
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
});
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
data->addWidget(wikiButton, row++, 0, 1, 2, Qt::AlignLeft);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
// Opening hours fragment
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (auto openingHours = info.GetOpeningHours(); !openingHours.empty())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
addEntry("Opening hours", std::string(openingHours));
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
// Cuisine fragment
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (auto cuisines = info.FormatCuisines(); !cuisines.empty())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
addEntry("Cuisine", cuisines);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
// Entrance fragment
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
// TODO
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
// Phone fragment
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (auto phoneNumber = info.GetMetadata(feature::Metadata::EType::FMD_PHONE_NUMBER); !phoneNumber.empty())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
data->addWidget(new QLabel("Phone"), row, 0);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
QLabel * value = new QLabel(QString::fromStdString("<a href='tel:" + std::string(phoneNumber) + "'>" + std::string(phoneNumber) + "</a>"));
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
value->setOpenExternalLinks(true);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
data->addWidget(value, row++, 1);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
// Operator fragment
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (auto operatorName = info.GetMetadata(feature::Metadata::EType::FMD_OPERATOR); !operatorName.empty())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
addEntry("Operator", std::string(operatorName));
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
// Wifi fragment
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (info.HasWifi())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
addEntry("Wi-Fi", "Yes");
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
// Links fragment
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (auto website = info.GetMetadata(feature::Metadata::EType::FMD_WEBSITE); !website.empty())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
addEntry("Website", std::string(stripSchemeFromURI(website)), true);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (auto email = info.GetMetadata(feature::Metadata::EType::FMD_EMAIL); !email.empty())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
data->addWidget(new QLabel("Email"), row, 0);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
QLabel * value = new QLabel(QString::fromStdString("<a href='mailto:" + std::string(email) + "'>" + std::string(email) + "</a>"));
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
value->setOpenExternalLinks(true);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
data->addWidget(value, row++, 1);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
// Social networks
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
auto addSocialNetworkWidget = [data, &info, &row](const std::string label, const feature::Metadata::EType eType)
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (auto item = info.GetMetadata(eType); !item.empty())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
data->addWidget(new QLabel(QString::fromStdString(label)), row, 0);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
QLabel * value = new QLabel(QString::fromStdString("<a href='" + osm::socialContactToURL(eType, std::string(item)) + "'>" + std::string(item) + "</a>"));
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
value->setOpenExternalLinks(true);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
value->setTextInteractionFlags(Qt::TextBrowserInteraction);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
data->addWidget(value, row++, 1);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
};
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
addSocialNetworkWidget("Facebook", feature::Metadata::EType::FMD_CONTACT_FACEBOOK);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
addSocialNetworkWidget("Instagram", feature::Metadata::EType::FMD_CONTACT_INSTAGRAM);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
addSocialNetworkWidget("Instagram", feature::Metadata::EType::FMD_CONTACT_INSTAGRAM);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
addSocialNetworkWidget("Twitter", feature::Metadata::EType::FMD_CONTACT_TWITTER);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
addSocialNetworkWidget("VK", feature::Metadata::EType::FMD_CONTACT_VK);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
addSocialNetworkWidget("Line", feature::Metadata::EType::FMD_CONTACT_LINE);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (auto wikimedia_commons = info.GetMetadata(feature::Metadata::EType::FMD_WIKIMEDIA_COMMONS); !wikimedia_commons.empty())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
QLabel * value = new QLabel(QString::fromStdString("<a href='" + feature::Metadata::ToWikimediaCommonsURL(std::string(wikimedia_commons)) + "'>Wikimedia Commons</a>"));
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
value->setOpenExternalLinks(true);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
value->setTextInteractionFlags(Qt::TextBrowserInteraction);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
data->addWidget(value, row++, 0);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
// Level fragment
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
addEntry("Level", std::string(level));
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
// ATM fragment
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (info.HasAtm())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
addEntry("ATM", "Yes");
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
// Latlon fragment
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
ms::LatLon const ll = info.GetLatLon();
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
addEntry("Coordinates", strings::to_string_dac(ll.m_lat, 7) + ", " + strings::to_string_dac(ll.m_lon, 7));
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
layout->addLayout(data);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
QHLine * line = new QHLine();
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
layout->addWidget(line);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
QDialogButtonBox * dbb = new QDialogButtonBox();
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
QPushButton * closeButton = new QPushButton("Close");
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
closeButton->setDefault(true);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
connect(closeButton, &QAbstractButton::clicked, this, &PlacePageDialogUser::OnClose);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
dbb->addButton(closeButton, QDialogButtonBox::RejectRole);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
if (info.ShouldShowEditPlace())
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
{
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
QPushButton * editButton = new QPushButton("Edit Place");
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
connect(editButton, &QAbstractButton::clicked, this, &PlacePageDialogUser::OnEdit);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
dbb->addButton(editButton, QDialogButtonBox::ActionRole);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
layout->addWidget(dbb, Qt::AlignCenter);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
setLayout(layout);
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
auto const ppTitle = std::string("Place Page") + (info.IsBookmark() ? " (bookmarked)" : "");
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
setWindowTitle(ppTitle.c_str());
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
}
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
void PlacePageDialogUser::OnClose() { reject(); }
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.
void PlacePageDialogUser::OnEdit() { accept(); }
biodranik commented 2024-03-22 23:17:01 +00:00 (Migrated from github.com)
Review

No global vars please. Put them into an anonymous namespace.

int constexpr kMaxLengthOfPlacePageDescription = 500;
int constexpr kMinWidthOfShortDescription = 390;
No global vars please. Put them into an anonymous namespace. ```suggestion int constexpr kMaxLengthOfPlacePageDescription = 500; int constexpr kMinWidthOfShortDescription = 390; ```
biodranik commented 2024-03-22 23:25:38 +00:00 (Migrated from github.com)
Review

Note formatting and the absence of memory allocations.

namespace
{
std::string_view stripSchemeFromURI(std::string_view uri) {
  for (std::string_view prefix : {"https://", "http://"})
  {
    if (strings::StartsWith(uri, prefix))
      return uri.substr(prefix.size());
  }
  return uri;
}
}  // namespace
Note formatting and the absence of memory allocations. ```suggestion namespace { std::string_view stripSchemeFromURI(std::string_view uri) { for (std::string_view prefix : {"https://", "http://"}) { if (strings::StartsWith(uri, prefix)) return uri.substr(prefix.size()); } return uri; } } // namespace ```
biodranik commented 2024-03-22 23:27:08 +00:00 (Migrated from github.com)
Review

Where is it used? Can it be rewritten with string_view?

Where is it used? Can it be rewritten with string_view?
biodranik commented 2024-03-22 23:27:23 +00:00 (Migrated from github.com)
Review

indent?

indent?
biodranik commented 2024-03-22 23:29:18 +00:00 (Migrated from github.com)
Review

As we're using BSD style for bracers, there's no need to introduce K&R one everywhere.

    if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty())
    {
As we're using BSD style for bracers, there's no need to introduce K&R one everywhere. ```suggestion if (auto facebook = info.GetMetadata(feature::Metadata::EType::FMD_CONTACT_FACEBOOK); !facebook.empty()) { ```
biodranik commented 2024-03-22 23:31:37 +00:00 (Migrated from github.com)
Review

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can addEntry lambda be reused?

Is it possible to avoid duplication for social networks by creating a lambda that takes a pair of parameters: "VK" and FMD_CONTACT_VK ? Can `addEntry` lambda be reused?
biodranik commented 2024-03-22 23:35:36 +00:00 (Migrated from github.com)
Review

One liners without bracers here and in other places.

    if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty())
      addEntry("Level", std::string(level));
One liners without bracers here and in other places. ```suggestion if (auto level = info.GetMetadata(feature::Metadata::EType::FMD_LEVEL); !level.empty()) addEntry("Level", std::string(level)); ```
biodranik commented 2024-03-22 23:36:29 +00:00 (Migrated from github.com)
Review

Btw, did you try to use git-clang-format? Make a commit before doing it.

Btw, did you try to use git-clang-format? Make a commit before doing it.
Ferenc- commented 2024-03-23 09:03:08 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:05:26 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 09:06:52 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:03:30 +00:00 (Migrated from github.com)
Review

done

done
Ferenc- commented 2024-03-23 12:04:55 +00:00 (Migrated from github.com)
Review

Removed.

Removed.
Ferenc- commented 2024-03-23 12:12:00 +00:00 (Migrated from github.com)
Review

Braces are done. I will check the tool

Braces are done. I will check the tool
Ferenc- commented 2024-03-23 12:35:05 +00:00 (Migrated from github.com)
Review

I have created a new lambda for this.

I have created a new lambda for this.

View file

@ -9,11 +9,11 @@ namespace place_page
class Info;
}
class PlacePageDialog : public QDialog
class PlacePageDialogUser : public QDialog
{
Q_OBJECT
public:
PlacePageDialog(QWidget * parent, place_page::Info const & info,
PlacePageDialogUser(QWidget * parent, place_page::Info const & info,
search::ReverseGeocoder::Address const & address);
private slots:

View file

@ -86,6 +86,17 @@ namespace qt
});
}
QCheckBox * developerModeCheckBox = new QCheckBox("Developer Mode");
{
bool developerMode;
if (settings::Get(settings::kDeveloperMode, developerMode) && developerMode)
developerModeCheckBox->setChecked(developerMode);
connect(developerModeCheckBox, &QCheckBox::stateChanged, [](int i)
{
settings::Set(settings::kDeveloperMode, static_cast<bool>(i));
});
}
#ifdef BUILD_DESIGNER
QCheckBox * indexRegenCheckBox = new QCheckBox("Enable auto regeneration of geometry index");
{
@ -115,6 +126,7 @@ namespace qt
QVBoxLayout * finalLayout = new QVBoxLayout();
finalLayout->addWidget(unitsRadioBox);
finalLayout->addWidget(largeFontCheckBox);
finalLayout->addWidget(developerModeCheckBox);
#ifdef BUILD_DESIGNER
finalLayout->addWidget(indexRegenCheckBox);
#endif