WIP: [android] Rework TTS setup advice #7553

RedAuburn · 2024-03-09T20:22:35Z

RedAuburn commented

2024-03-09 20:22:35 +00:00

fixes organicmaps/organicmaps#2383 and organicmaps/organicmaps#6025

This way, information is explained simply, the user is directed to set up the system settings, and we don't need to maintain the webpage (and translate it to multiple languages).

before / after:

fixes https://git.omaps.dev/organicmaps/organicmaps/issues/2383 and https://git.omaps.dev/organicmaps/organicmaps/issues/6025 This way, information is explained simply, the user is directed to set up the system settings, and we don't need to maintain the webpage (and translate it to multiple languages). before / after: ![image1](https://github.com/organicmaps/organicmaps/assets/26939824/76579421-14b9-4256-8525-68de71ce37a3)

rtsisyk reviewed 2024-03-09 20:22:35 +00:00

Jean-BaptisteC (Migrated from github.com) reviewed 2024-03-14 17:21:55 +00:00

android/app/src/main/java/app/organicmaps/settings/VoiceInstructionsSettingsFragment.java

Jean-BaptisteC (Migrated from github.com) commented

2024-03-14 17:21:55 +00:00

Not possible to use getString directly in Toast.makeText?

biodranik (Migrated from github.com) reviewed 2024-03-15 00:17:30 +00:00

biodranik (Migrated from github.com) left a comment

Thanks! I like these changes. The problem is that this long text and its title don't look like a clickable button. It could be better/clearer to leave only a title and move the detailed text with a link at the bottom, after the other buttons. And make that text clickable (open our FAQ)?

Maybe "Speech synthesis system settings" can also be made clearer in terms that users should understand the importance of opening system settings and doing appropriate setup there. "Set up speech synthesis"?

Thanks! I like these changes. The problem is that this long text and its title don't look like a clickable button. It could be better/clearer to leave only a title and move the detailed text with a link at the bottom, after the other buttons. And make that text clickable (open our FAQ)? Maybe "Speech synthesis system settings" can also be made clearer in terms that users should understand the importance of opening system settings and doing appropriate setup there. "Set up speech synthesis"?

data/strings/strings.txt

					
				@ -19691,2 +19692,3 @@

				    zh-Hant = 如果無法啟用語音指令或您的語言不受支持，請確保您的系統已設定為使用此捷徑進行語音合成。如果不是，請先從應用程式商店安裝支援您的語言的文字轉語音引擎。

				  [prefs_languages_information_off]

				  [prefs_tts_info_guide_link]

biodranik (Migrated from github.com) commented

2024-03-15 00:14:01 +00:00

This text solves different issues:

Informs that user may need to install another software to make TTS work.
Informs that the system should be properly set up in the TTS settings.
Informs that the language of directions depends on the system settings and installed engine.

Are there any ideas on how to simplify this text?

This text solves different issues: 1. Informs that user may need to install another software to make TTS work. 2. Informs that the system should be properly set up in the TTS settings. 3. Informs that the language of directions depends on the system settings and installed engine. Are there any ideas on how to simplify this text?

data/strings/strings.txt

biodranik (Migrated from github.com) commented

2024-03-14 23:56:29 +00:00

This is a great idea! Let's add the same arrow symbol to each LTR language.

data/strings/strings.txt

biodranik (Migrated from github.com) commented

2024-03-14 23:49:07 +00:00

Hint: to copy url without percent escaping, insert a space in the beginning before copying.

    ru = https://organicmaps.app/ru/faq/синтез-речи-tts-на-android/

Hint: to copy url without percent escaping, insert a space in the beginning before copying. ```suggestion ru = https://organicmaps.app/ru/faq/синтез-речи-tts-на-android/ ```

gpesquero reviewed 2024-03-27 20:40:13 +00:00

data/strings/strings.txt

gpesquero commented

2024-03-27 20:40:13 +00:00

@RedAuburn: Please fix the URL for FAQ in Spanish and add the URL for Italian...

    es = https://organicmaps.app/es/faq/instrucciones-de-voz-tts-en-android/
    it = https://organicmaps.app/it/faq/sintesi-vocale-tts-su-android/

@RedAuburn: Please fix the URL for FAQ in Spanish and add the URL for Italian... ```suggestion es = https://organicmaps.app/es/faq/instrucciones-de-voz-tts-en-android/ it = https://organicmaps.app/it/faq/sintesi-vocale-tts-su-android/ ```

gpesquero requested changes 2024-03-27 20:57:01 +00:00

gpesquero left a comment

Strings of android:key params shall not be translatable...

Strings of `android:key` params shall not be translatable...

android/app/src/main/res/values/donottranslate.xml

					
				@ -24,8 +24,6 @@

				  <string name="pref_tts_info" translatable="false">TtsInfo</string>

				  <string name="pref_tts_info_link" translatable="false">TtsInfoLink</string>

gpesquero commented

2024-03-27 20:52:27 +00:00

  <string name="pref_tts_info_link" translatable="false">TtsInfoLink</string>
  <string name="pref_tts_system_setup" translatable="false">TtsSystemSetup</string>
  <string name="pref_tts_info_guide_link" translatable="false">TtsInfoGuideLink</string>

```suggestion <string name="pref_tts_info_link" translatable="false">TtsInfoLink</string> <string name="pref_tts_system_setup" translatable="false">TtsSystemSetup</string> <string name="pref_tts_info_guide_link" translatable="false">TtsInfoGuideLink</string> ```

android/app/src/main/res/xml/prefs_voice_instructions.xml

					
				@ -19,2 +20,3 @@

				      android:key="@string/pref_tts_open_system_settings"

				      android:title="@string/pref_tts_open_system_settings" />

				      android:title="@string/pref_tts_open_system_settings"

				      android:summary="@string/prefs_tts_system_setup" />

gpesquero commented

2024-03-27 20:50:15 +00:00

      android:title="@string/pref_tts_open_system_settings_title"

```suggestion android:title="@string/pref_tts_open_system_settings_title" ```

android/app/src/main/res/xml/prefs_voice_instructions.xml

gpesquero commented

2024-03-27 20:50:37 +00:00

      android:title="@string/prefs_tts_info_guide_link_title"/>

```suggestion android:title="@string/prefs_tts_info_guide_link_title"/> ```

data/strings/strings.txt

					
				@ -19647,3 +19647,3 @@

				  [prefs_languages_information]

				  [prefs_tts_system_setup]

				    tags = android

gpesquero commented

2024-03-27 20:55:38 +00:00

  [prefs_tts_system_setup_title]

```suggestion [prefs_tts_system_setup_title] ```

data/strings/strings.txt

gpesquero commented

2024-03-27 20:56:45 +00:00

  [prefs_tts_info_guide_link_title]

```suggestion [prefs_tts_info_guide_link_title] ```

gpesquero reviewed 2024-03-28 14:59:59 +00:00

data/strings/strings.txt

					
				@ -19691,2 +19692,3 @@

				    zh-Hant = 如果無法啟用語音指令或您的語言不受支持，請確保您的系統已設定為使用此捷徑進行語音合成。如果不是，請先從應用程式商店安裝支援您的語言的文字轉語音引擎。

				  [prefs_languages_information_off]

				  [prefs_tts_info_guide_link]

gpesquero commented

2024-03-28 14:59:58 +00:00

@RedAuburn, @biodranik: If it's any help, in organicmaps/organicmaps#5981 we proposed the following wording:

Organic Maps uses system TTS (Text-To-Speech) for voice instructions. For support on TTS installation or troubleshooting, please check the [link: TTS FAQs (Frequently Asked Questions)]>

@RedAuburn, @biodranik: If it's any help, in https://git.omaps.dev/organicmaps/organicmaps/pulls/5981 we proposed the following wording: `Organic Maps uses system TTS (Text-To-Speech) for voice instructions. For support on TTS installation or troubleshooting, please check the [link: TTS FAQs (Frequently Asked Questions)]>`

This repo is archived. You cannot comment on pull requests.

No reviewers

rtsisyk