WIP: [styles] Add London Overground icon #7784

RedAuburn · 2024-04-02T14:03:50Z

charlie2clarke commented

2024-04-02 14:03:50 +00:00

(Migrated from github.com)

Part of #3419

This is a WIP as the icon isn't being shown yet.

The only OSM tag available to distinguish the London Overground service is operator= (see below)

I think the fact 'London Overground' has spaces in it might be tripping something up, though I've tried wrapping it in quotes in Subways.mapcss and it made no difference.

Note: I will add this as a POI type once the icon is sorted.

Part of #3419 **This is a WIP** as the icon isn't being shown yet. The only OSM tag available to distinguish the London Overground service is `operator=` (see below) <img src="https://github.com/organicmaps/organicmaps/assets/58811769/a114a2ca-8be9-4372-961f-4e4b73af52f6" width="30%" height="30%" /> I think the fact 'London Overground' has spaces in it might be tripping something up, though I've tried wrapping it in quotes in `Subways.mapcss` and it made no difference. _Note: I will add this as a POI type once the icon is sorted._

👍 2

vng (Migrated from github.com) reviewed 2024-04-04 03:17:51 +00:00

.gitmodules

vng (Migrated from github.com) commented

2024-04-04 03:11:36 +00:00

Please, update submodules before committing your changes. This change is not from this PR, definitely.

data/mapcss-mapping.csv

					
				@ -1683,3 +1683,4 @@ railway|station|subway|singapore;[railway=station][transport=subway][city=singap

				railway|subway_entrance|singapore;[railway=subway_entrance][city=singapore];;name;int_name;1595;

				railway|station|subway|boston;[railway=station][transport=subway][city=boston],[railway=station][station=subway][city=boston];;name;int_name;1596;

				railway|subway_entrance|boston;[railway=subway_entrance][city=boston];;name;int_name;1597;

				railway|station|overground|london;[railway=station][operator=London Overground];;name;int_name;1598;

vng (Migrated from github.com) commented

2024-04-04 03:17:47 +00:00

Well, if it works good (probably should add one test in osm_tyoe_test.cpp) I'm ok with that.

@RedAuburn Can we trust operator=London Overground ?

Well, if it works good (probably should add one test in osm_tyoe_test.cpp) I'm ok with that. @RedAuburn Can we trust operator=London Overground ?

RedAuburn reviewed 2024-04-04 12:06:29 +00:00

data/mapcss-mapping.csv

					
				@ -1683,3 +1683,4 @@ railway|station|subway|singapore;[railway=station][transport=subway][city=singap

				railway|subway_entrance|singapore;[railway=subway_entrance][city=singapore];;name;int_name;1595;

				railway|station|subway|boston;[railway=station][transport=subway][city=boston],[railway=station][station=subway][city=boston];;name;int_name;1596;

				railway|subway_entrance|boston;[railway=subway_entrance][city=boston];;name;int_name;1597;

				railway|station|overground|london;[railway=station][operator=London Overground];;name;int_name;1598;

RedAuburn commented

2024-04-04 12:06:29 +00:00

hmmm... looks like it's going to be a bit more complicated :/

railway=station+operator=London Overground only finds 62 stations.

This query finds all 113 stations the Overground serves:

[out:json][timeout:25];
{{geocodeArea:United Kingdom}}->.searchArea;
// OR
(
  // should match =London Underground;London Overground
  nwr["railway"="station"]["network"~"London Overground"](area.searchArea);
  nwr["railway"="station"]["operator"~"London Overground"](area.searchArea);
);
// print results
out geom;

need to search for all nodes where either network=* or operator=* contains London Overground (non-case sensitive). And not just an exact string match as POI can have things like network=London Underground;London Overground

hmmm... looks like it's going to be a bit more complicated :/ `railway=station`+`operator=London Overground` only finds 62 stations. This query finds all 113 stations the Overground serves: ``` [out:json][timeout:25]; {{geocodeArea:United Kingdom}}->.searchArea; // OR ( // should match =London Underground;London Overground nwr["railway"="station"]["network"~"London Overground"](area.searchArea); nwr["railway"="station"]["operator"~"London Overground"](area.searchArea); ); // print results out geom; ``` need to search for all nodes where _either_ `network=*` or `operator=*` _contains_ `London Overground` (non-case sensitive). And not just an exact string match as POI can have things like `network=London Underground;London Overground`

pastk reviewed 2024-04-04 12:29:02 +00:00

data/mapcss-mapping.csv

					
				@ -1683,3 +1683,4 @@ railway|station|subway|singapore;[railway=station][transport=subway][city=singap

				railway|subway_entrance|singapore;[railway=subway_entrance][city=singapore];;name;int_name;1595;

				railway|station|subway|boston;[railway=station][transport=subway][city=boston],[railway=station][station=subway][city=boston];;name;int_name;1596;

				railway|subway_entrance|boston;[railway=subway_entrance][city=boston];;name;int_name;1597;

				railway|station|overground|london;[railway=station][operator=London Overground];;name;int_name;1598;

pastk commented

2024-04-04 12:29:01 +00:00

railway|station|overground|london;[railway=station][operator=London Overground],[railway=station][network=London Overground]; :)

but IDK how do we treat case and multiple values might need a special processing...

`railway|station|overground|london;[railway=station][operator=London Overground],[railway=station][network=London Overground];` :) but IDK how do we treat case and multiple values might need a special processing...

charlie2clarke (Migrated from github.com) reviewed 2024-04-04 14:07:39 +00:00

data/mapcss-mapping.csv

					
				@ -1683,3 +1683,4 @@ railway|station|subway|singapore;[railway=station][transport=subway][city=singap

				railway|subway_entrance|singapore;[railway=subway_entrance][city=singapore];;name;int_name;1595;

				railway|station|subway|boston;[railway=station][transport=subway][city=boston],[railway=station][station=subway][city=boston];;name;int_name;1596;

				railway|subway_entrance|boston;[railway=subway_entrance][city=boston];;name;int_name;1597;

				railway|station|overground|london;[railway=station][operator=London Overground];;name;int_name;1598;

charlie2clarke (Migrated from github.com) commented

2024-04-04 14:07:39 +00:00

Would adding another wildcard to signify case insensitivity not be ok? I'd like to help make the changes for how this might be parsed, but I'm having trouble working out how to build and run the generator code by itself (and not driven by tools/python/map_generator) to allow me to debug it.

pastk reviewed 2024-04-04 14:42:12 +00:00

data/mapcss-mapping.csv

					
				@ -1683,3 +1683,4 @@ railway|station|subway|singapore;[railway=station][transport=subway][city=singap

				railway|subway_entrance|singapore;[railway=subway_entrance][city=singapore];;name;int_name;1595;

				railway|station|subway|boston;[railway=station][transport=subway][city=boston],[railway=station][station=subway][city=boston];;name;int_name;1596;

				railway|subway_entrance|boston;[railway=subway_entrance][city=boston];;name;int_name;1597;

				railway|station|overground|london;[railway=station][operator=London Overground];;name;int_name;1598;

pastk commented

2024-04-04 14:42:12 +00:00

IMO all OSM tags matching should be case-insensitive (maybe its the case already?)

RedAuburn reviewed 2024-04-06 14:32:33 +00:00

data/mapcss-mapping.csv

					
				@ -1683,3 +1683,4 @@ railway|station|subway|singapore;[railway=station][transport=subway][city=singap

				railway|subway_entrance|singapore;[railway=subway_entrance][city=singapore];;name;int_name;1595;

				railway|station|subway|boston;[railway=station][transport=subway][city=boston],[railway=station][station=subway][city=boston];;name;int_name;1596;

				railway|subway_entrance|boston;[railway=subway_entrance][city=boston];;name;int_name;1597;

				railway|station|overground|london;[railway=station][operator=London Overground];;name;int_name;1598;

RedAuburn commented

2024-04-06 14:32:33 +00:00

but IDK how do we treat case and multiple values might need a special processing...

@vng do you know if the generator can handle case & multiple values?

> but IDK how do we treat case and multiple values might need a special processing... @vng do you know if the generator can handle case & multiple values?

vng (Migrated from github.com) reviewed 2024-04-06 14:36:03 +00:00

data/mapcss-mapping.csv

					
				@ -1683,3 +1683,4 @@ railway|station|subway|singapore;[railway=station][transport=subway][city=singap

				railway|subway_entrance|singapore;[railway=subway_entrance][city=singapore];;name;int_name;1595;

				railway|station|subway|boston;[railway=station][transport=subway][city=boston],[railway=station][station=subway][city=boston];;name;int_name;1596;

				railway|subway_entrance|boston;[railway=subway_entrance][city=boston];;name;int_name;1597;

				railway|station|overground|london;[railway=station][operator=London Overground];;name;int_name;1598;