[core] Fix unused-parameter warnings #8110

AndrewShkrob · 2024-05-06T19:33:13Z

AndrewShkrob commented

2024-05-06 19:33:13 +00:00

No description provided.

vng (Migrated from github.com) reviewed 2024-05-06 19:33:13 +00:00

biodranik (Migrated from github.com) reviewed 2024-05-06 21:41:07 +00:00

cmake/OmimConfig.cmake

					
				@ -2,4 +2,3 @@

				set(OMIM_WARNING_FLAGS

				  $<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wall -Wextra -Wpedantic>

				  $<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wno-unused-parameter>  # We have a lot of functions with unused parameters

				)

biodranik (Migrated from github.com) commented

2024-05-06 21:40:52 +00:00

What are the pros of enabling this warning? I see the following cons:

Git blame is more complicated.
Where parameter names are removed, they're not clear and the reader should guess to understand.
Where parameter names are commented, it is not possible to comment large blocks of code with /* */ anymore.

What are the pros of enabling this warning? I see the following cons: - Git blame is more complicated. - Where parameter names are removed, they're not clear and the reader should guess to understand. - Where parameter names are commented, it is not possible to comment large blocks of code with /* */ anymore.

indexer/CMakeLists.txt

					
				@ -151,4 +145,1 @@

				file(COPY ${OTHER_FILES} DESTINATION ${CMAKE_BINARY_DIR})

				omim_add_library(${PROJECT_NAME} ${SRC})

biodranik (Migrated from github.com) commented

2024-05-06 21:33:19 +00:00

Is it not needed anymore?

indexer/CMakeLists.txt

biodranik (Migrated from github.com) commented

2024-05-06 21:33:23 +00:00

ditto

indexer/editable_map_object.cpp

					
				@ -107,3 +105,4 @@

				                                                      int8_t const)

				{

				  NamesDataSource result;

				  auto & names = result.names;

biodranik (Migrated from github.com) commented

2024-05-06 21:34:16 +00:00

cmon )

NamesDataSource EditableMapObject::GetNamesDataSource(StringUtf8Multilang const & source, vector<int8_t> const &, int8_t const)

cmon ) ```suggestion NamesDataSource EditableMapObject::GetNamesDataSource(StringUtf8Multilang const & source, vector<int8_t> const &, int8_t const) ```

storage/storage_tests/downloader_tests.cpp

					
				@ -13,3 +13,3 @@

				{

				  virtual void Download(storage::QueuedCountry && queuedCountry)

				  void Download(storage::QueuedCountry &&) override

				  {

biodranik (Migrated from github.com) commented

2024-05-06 21:37:10 +00:00

This is a different warning )

rtsisyk approved these changes 2025-01-11 09:12:29 +00:00

base/pprof.cpp

					
				@ -13,2 +13,4 @@

				#if defined(USE_PPROF)

				  ProfilerStart(path.c_str());

				#else

				  UNUSED_VALUE(path);

rtsisyk commented

2025-01-11 09:12:26 +00:00

AFAIK, Qt, which is one of examples of more or less readable C++ code, uses a similar macro to suppress unused arguments when they are unavoidable (e.g., when overriding certain interfaces). Does it make sense to use it everywhere instead of commenting out arguments in the declaration?

AndrewShkrob reviewed 2025-01-11 14:40:01 +00:00

base/pprof.cpp

					
				@ -13,2 +13,4 @@

				#if defined(USE_PPROF)

				  ProfilerStart(path.c_str());

				#else

				  UNUSED_VALUE(path);

AndrewShkrob commented

2025-01-11 14:40:01 +00:00

What about building for Android/iOS? We don't want to include Qt libs there, don't we?

This repo is archived. You cannot comment on pull requests.

No reviewers

vng

rtsisyk

No labels

Android Automotive (AAOS)

API

AppGallery

AppStore

Battery and Performance

External Map Datasets

F-Droid

Fonts

Frequently User Reported

No milestone

No project

No assignees

3 participants

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#8110

Rows
Columns