WIP: [routing] User routes feature #8260

Draft

fgbg03 wants to merge 8 commits from fgbg03/user_routes_feature into master

fgbg03 commented

2024-05-23 12:37:36 +00:00

(Migrated from github.com)

Enables users to save, load, delete and rename routes stored in their devices.

Adds overloads of existing functions that handle saved route points.
These keep the same functionality but take in the name of the file as an argument.
Adds functions that use these overloads to save/ load/ check if user routes exist.

Adds User Interface for android devices.
A button on the map screen opens a bottom sheet to the user routes menu.
From this menu the currently displayed route can be saved and the saved routes can be loaded, deleted and renamed.

~~The test is just a simple draft I could not verify was running/ being added correctly to be run.~~
Adds testes for the backend.
The last test is commented because LoadRoutePoints uses Thread::Gui which I'm unable to use on the CLASS_UNIT_TEST.

Enables users to save, load, delete and rename routes stored in their devices. Adds overloads of existing functions that handle saved route points. These keep the same functionality but take in the name of the file as an argument. Adds functions that use these overloads to save/ load/ check if user routes exist. Adds User Interface for android devices. A button on the map screen opens a bottom sheet to the user routes menu. From this menu the currently displayed route can be saved and the saved routes can be loaded, deleted and renamed. ~~The test is just a simple draft I could not verify was running/ being added correctly to be run.~~ Adds testes for the backend. The last test is commented because LoadRoutePoints uses Thread::Gui which I'm unable to use on the CLASS_UNIT_TEST.

🎉 3

vng (Migrated from github.com) reviewed 2024-05-23 12:37:36 +00:00

rtsisyk reviewed 2024-05-23 12:37:36 +00:00

biodranik (Migrated from github.com) reviewed 2024-05-23 21:58:04 +00:00

map/map_tests/user_routes_test.cpp

biodranik (Migrated from github.com) commented

2024-05-23 21:58:04 +00:00

Is this line printed when you run ../omim-build-debug/map_tests binary?

Is this line printed when you run `../omim-build-debug/map_tests` binary?

fgbg03 (Migrated from github.com) reviewed 2024-05-23 22:07:24 +00:00

map/map_tests/user_routes_test.cpp

fgbg03 (Migrated from github.com) commented

2024-05-23 22:07:24 +00:00

Yes, thanks for pointing me to the binary. This way it shows up. I'll finish up the test in the morning.

fgbg03 (Migrated from github.com) reviewed 2024-05-26 16:06:46 +00:00

map/map_tests/user_routes_test.cpp

fgbg03 (Migrated from github.com) commented

2024-05-26 16:06:46 +00:00

This test has now been expanded to further tests

biodranik (Migrated from github.com) requested changes 2024-08-12 19:07:30 +00:00

biodranik (Migrated from github.com) left a comment

Thanks! That is a different approach to the one we were discussing and planning in organicmaps/organicmaps#1785

In short:

A route should be saved into internal KML format in the C++ core, in the same way as other imported tracks are saved now (and as recorded tracks will be saved)
A route is different from tracks (e.g. it has stops, no elevation, no timing data. etc.)

This approach allows to:

share a route later in GPX, KML or even as an API url
restore and drive a route locally
easily delete a route
change route color
rename a route
move it into a different list/folder

Thanks! That is a different approach to the one we were discussing and planning in https://git.omaps.dev/organicmaps/organicmaps/issues/1785 In short: - A route should be saved into internal KML format in the C++ core, in the same way as other imported tracks are saved now (and as recorded tracks will be saved) - A route is different from tracks (e.g. it has stops, no elevation, no timing data. etc.) This approach allows to: - share a route later in GPX, KML or even as an API url - restore and drive a route locally - easily delete a route - change route color - rename a route - move it into a different list/folder

This repo is archived. You cannot comment on pull requests.

No reviewers

vng

rtsisyk

biodranik