organicmaps/organicmaps-tmp

Archived

WIP: Hyphenate interpolated addresses #8683

Draft

zyphlar wants to merge 1 commit from zyphlar/hyphenate_interpolated_addresses into master

zyphlar commented

2024-07-12 06:37:16 +00:00

Member

Addresses like "123:456 Main Street" don't make intuitive sense to most people, however some other way of indicating a range (which may vary by locale) would be more understandable, like "123 – 456 Main Street"

It's important to not simply use a hyphen, either, since some house numbers are literally "12-345" etc.

Addresses like "123:456 Main Street" don't make intuitive sense to most people, however some other way of indicating a range (which may vary by locale) would be more understandable, like "123 – 456 Main Street" It's important to not simply use a hyphen, either, since some house numbers are literally "12-345" etc.

biodranik (Migrated from github.com) reviewed 2024-07-12 21:37:40 +00:00

biodranik (Migrated from github.com) left a comment

Will using … look better and cause less confusion?

Will using … look better and cause less confusion?

biodranik (Migrated from github.com) requested changes 2024-08-26 07:49:27 +00:00

biodranik (Migrated from github.com) left a comment

@vng how to properly replace the colon in displayed interpolated addresses with – ?

@vng how to properly replace the colon in displayed interpolated addresses with ` – `?

search/reverse_geocoder.hpp

					
				@ -89,3 +98,4 @@

				    }

				    std::string const & GetHouseNumber() const { return m_building.m_name; }

				    std::string const & GetStreetName() const { return m_street.m_name; }

				    double GetDistance() const { return m_building.m_distanceMeters; }

biodranik (Migrated from github.com) commented

2024-08-26 07:48:39 +00:00

No, we don't want/need to use regexes in such cases.

No, we don't want/need to use regexes in such cases.

tools/python/maps_generator/README.md

					
				@ -69,3 +69,3 @@

				Make sure that requested countries are contained in your planet dump file indeed. Filenames in `data/borders/` (without the `.poly` extension) represent all valid country names.

				Make sure that you specify country names that are actually contained in your pbf file, or you'll get errors in the next step. Check the filenames in the `data/borders/` folder (without the `.poly` extension) for a list of all valid country names. For example, New York City is in `US_New York_New_York` and all of England (minus Ireland, Scotland, and Wales) can be generated by specifying `UK_England_*`.

biodranik (Migrated from github.com) commented

2024-08-26 07:48:12 +00:00

Please make a separate PR with documentation.

Please make a separate PR with documentation.

This repo is archived. You cannot comment on pull requests.

No reviewers

No labels

Android Automotive (AAOS)

Android Automotive (AAOS)

Battery and Performance

Battery and Performance

Bookmarks and Tracks

Bookmarks and Tracks

External Map Datasets

External Map Datasets

Frequently User Reported

Frequently User Reported

Good first issue

Good first issue

Linux packaging

Linux packaging

NLnet 2024-06-281

NLnet 2024-06-281

No Feature Parity

No Feature Parity

Public Transport

Public Transport

Track Recording

Track Recording

Walk Navigation

Walk Navigation

No milestone

No project

No assignees

2 participants

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#8683

No description provided.