Add camp_pitch #8757

patepelo · 2024-07-24T16:06:12Z

willcohen commented

2024-07-24 16:06:12 +00:00

(Migrated from github.com)

While I have been unable to successfully regenerate the map file to test locally, I do believe I followed the initial steps at https://github.com/organicmaps/organicmaps/blob/master/docs/STYLES.md#how-to-add-a-new-map-feature--poi-type.

Pending testing confirmation, would address #1660.

While I have been unable to successfully regenerate the map file to test locally, I do believe I followed the initial steps at https://github.com/organicmaps/organicmaps/blob/master/docs/STYLES.md#how-to-add-a-new-map-feature--poi-type. Pending testing confirmation, would address #1660.

👍 1

biodranik (Migrated from github.com) reviewed 2024-08-01 17:26:58 +00:00

biodranik (Migrated from github.com) left a comment

What is the value of adding and displaying individual pitches? Are there many camp sites with each pitch inside properly mapped?

data/editor.config

					
				@ -991,6 +991,9 @@

				      <type id="attraction-animal">

				        <include field="name" />

				      </type>

				      <type id="tourism-camp_pitch" group="accomodation">

biodranik (Migrated from github.com) commented

2024-08-01 17:24:57 +00:00

What's the value of adding individual pitches as POIs?

data/editor.config

					
				@ -992,2 +992,4 @@

				        <include field="name" />

				      </type>

				      <type id="tourism-camp_pitch" group="accomodation">

				        <include group="poi_internet" />

biodranik (Migrated from github.com) commented

2024-08-01 17:11:13 +00:00

Are there camp pitches with the internet? Should this tag belong to the camp site?

data/mapcss-mapping.csv

					
				@ -584,3 +584,3 @@

				amenity|telephone;471;

				deprecated|deprecated;472;x

				tourism|camp_pitch;472;

				deprecated|deprecated;473;x

biodranik (Migrated from github.com) commented

2024-08-01 17:11:46 +00:00

@vng is it the right ID for the pitch?

data/strings/types_strings.txt

					
				@ -29857,1 +29857,4 @@

				  [type.tourism.camp_pitch]

				    en = Camp Pitch

				    en-GB = Camp Pitch

biodranik (Migrated from github.com) commented

2024-08-01 17:12:17 +00:00

No need to type equal translations for sublanguages.

Some translations are missing, how did you translate it? Not with tools/python/translate.py, right?

    en = Camp site
    af = Kampplek
    ar = موقع المخيم
    az = Düşərgə yeri
    be = Пляцоўка для лагера
    bg = Къмпинг
    ca = Càmping
    cs = Tábořiště
    da = Lejrplads
    de = Zeltplatz
    el = Χώρος κατασκήνωσης
    es = Camping
    et = Laagriplats
    eu = Kanpalekua
    fa = سایت کمپ
    fi = Leirintäalue
    fr = Camping
    he = אתר מחנה
    hi = शिविर स्थल
    hu = Táborhely
    id = Lokasi perkemahan
    it = Campeggio
    ja = キャンプサイト
    ko = 캠프 사이트
    lt = Stovyklavietė
    mr = कॅम्प साइट
    nb = Leirplass
    nl = Camping
    pl = Kemping
    pt = Acampamento
    pt-BR = Local do acampamento
    ro = Locul de campare
    ru = Площадка для лагеря
    sk = Táborisko
    sv = Campingplats
    sw = Tovuti ya kambi
    th = เว็บไซต์ค่าย
    tr = Kamp alanı
    uk = Майданчик для таборування
    vi = Khu cắm trại
    zh-Hans = 营地
    zh-Hant = 營地

No need to type equal translations for sublanguages. Some translations are missing, how did you translate it? Not with tools/python/translate.py, right? ``` en = Camp site af = Kampplek ar = موقع المخيم az = Düşərgə yeri be = Пляцоўка для лагера bg = Къмпинг ca = Càmping cs = Tábořiště da = Lejrplads de = Zeltplatz el = Χώρος κατασκήνωσης es = Camping et = Laagriplats eu = Kanpalekua fa = سایت کمپ fi = Leirintäalue fr = Camping he = אתר מחנה hi = शिविर स्थल hu = Táborhely id = Lokasi perkemahan it = Campeggio ja = キャンプサイト ko = 캠프 사이트 lt = Stovyklavietė mr = कॅम्प साइट nb = Leirplass nl = Camping pl = Kemping pt = Acampamento pt-BR = Local do acampamento ro = Locul de campare ru = Площадка для лагеря sk = Táborisko sv = Campingplats sw = Tovuti ya kambi th = เว็บไซต์ค่าย tr = Kamp alanı uk = Майданчик для таборування vi = Khu cắm trại zh-Hans = 营地 zh-Hant = 營地 ```

vng (Migrated from github.com) reviewed 2024-08-02 14:43:22 +00:00

data/mapcss-mapping.csv

					
				@ -584,3 +584,3 @@

				amenity|telephone;471;

				deprecated|deprecated;472;x

				tourism|camp_pitch;472;

				deprecated|deprecated;473;x

vng (Migrated from github.com) commented

2024-08-02 14:43:22 +00:00

No problem here.

orblivion (Migrated from github.com) reviewed 2024-08-22 03:46:14 +00:00

data/editor.config

					
				@ -992,2 +992,4 @@

				        <include field="name" />

				      </type>

				      <type id="tourism-camp_pitch" group="accomodation">

				        <include group="poi_internet" />

orblivion (Migrated from github.com) commented

2024-08-22 03:46:14 +00:00

I would also think it belongs to the camp site as a whole, unless maybe only part of the facility has reach to the wifi?

In any case, FWIW, internet_access is in the wiki under "Tags used in combination":

https://wiki.openstreetmap.org/wiki/Tag:tourism%3Dcamp_pitch

I would also think it belongs to the camp site as a whole, unless maybe only part of the facility has reach to the wifi? In any case, FWIW, `internet_access` is in the wiki under "Tags used in combination": https://wiki.openstreetmap.org/wiki/Tag:tourism%3Dcamp_pitch

orblivion (Migrated from github.com) reviewed 2024-08-22 03:55:57 +00:00

data/strings/types_strings.txt

					
				@ -29856,2 +29856,4 @@

				    ref = type.tourism.attraction

				  [type.tourism.camp_pitch]

				    en = Camp Pitch

orblivion (Migrated from github.com) commented

2024-08-22 03:55:57 +00:00

It looks like en refers to American English? (I'm not an Organic Maps dev) This checks out below: "Campground" in en-US translates to "Campsite" in en-GB.

Well, with that in mind, what British folks refer to as a "Camp Pitch", us Americans refer to, confusingly enough, as a "Campsite". ("Camp Pitch" is not a phrase I'd heard of before looking this up the other day, and it made it hard to find this feature in the OSM taxonomy). This is currently mentioned in the opening paragraph here: https://wiki.openstreetmap.org/wiki/Tag:tourism%3Dcamp_site

It looks like `en` refers to American English? (I'm not an Organic Maps dev) This checks out below: "Campground" in `en-US` translates to "Campsite" in `en-GB`. Well, with that in mind, what British folks refer to as a "Camp Pitch", us Americans refer to, confusingly enough, as a "Campsite". ("Camp Pitch" is not a phrase I'd heard of before looking this up the other day, and it made it hard to find this feature in the OSM taxonomy). This is currently mentioned in the opening paragraph here: https://wiki.openstreetmap.org/wiki/Tag:tourism%3Dcamp_site

brdbkr (Migrated from github.com) reviewed 2024-09-03 04:34:28 +00:00

data/strings/types_strings.txt

					
				@ -29856,2 +29856,4 @@

				    ref = type.tourism.attraction

				  [type.tourism.camp_pitch]

				    en = Camp Pitch

brdbkr (Migrated from github.com) commented

2024-09-03 04:34:28 +00:00

Yes, "camp pitch" is a term I have never, ever heard in the US.

willcohen (Migrated from github.com) reviewed 2024-09-30 23:41:41 +00:00

data/editor.config

					
				@ -992,2 +992,4 @@

				        <include field="name" />

				      </type>

				      <type id="tourism-camp_pitch" group="accomodation">

				        <include group="poi_internet" />