organicmaps/organicmaps-tmp

Archived

[Android] Speed limit in navigation mode #8897

Merged

root merged 6 commits from android-speed-limit into master

2024-08-15 10:23:09 +00:00

strump commented

2024-08-09 06:54:14 +00:00

Member

Changed navigation UI to show speed and speed limit with '/' separator (as in iOS).

Q1. How to test it without having a ride in a car?

How to check it on emulator?

Expected result: speed limit should be displayed in navigation mode:

ios speed limit

Testing:

Screenshot 2024-08-09 at 10 55 04

I used GPX track Florida. Busch Gardens - Pollo Tropical.gpx to emulate city ride.

Changed navigation UI to show speed and speed limit with `'/'` separator (as in iOS). ### Q1. How to test it without having a ride in a car? How to check it on emulator? **Expected result:** speed limit should be displayed in navigation mode: <img width="400" alt="ios speed limit" src="https://github.com/user-attachments/assets/712e4705-a44d-463f-b6d2-1b4114defe8e" /> ### Testing: <img width="400" alt="Screenshot 2024-08-09 at 10 55 04" src="https://github.com/user-attachments/assets/5d2e20b7-257a-4b45-910e-114b74f45379"/> I used GPX track [Florida. Busch Gardens - Pollo Tropical.gpx](https://gist.github.com/strump/d4b8cadde7324e4cba5dc802b9d9cb99) to emulate city ride.

biodranik (Migrated from github.com) reviewed 2024-08-09 07:13:04 +00:00

android/app/src/main/java/app/organicmaps/widget/menu/NavMenu.java

					
				@ -211,9 +214,26 @@ public class NavMenu

				    Pair<String, String> speedAndUnits = StringUtils.nativeFormatSpeedAndUnits(last.getSpeed());

biodranik (Migrated from github.com) commented

2024-08-09 07:13:04 +00:00

Would this narrow non-breaking space look better? https://www.compart.com/en/unicode/U+202F

Would this narrow non-breaking space look better? https://www.compart.com/en/unicode/U+202F

biodranik (Migrated from github.com) reviewed 2024-08-09 07:13:14 +00:00

android/app/src/main/java/app/organicmaps/widget/menu/NavMenu.java

					
				@ -211,9 +214,26 @@ public class NavMenu

				    Pair<String, String> speedAndUnits = StringUtils.nativeFormatSpeedAndUnits(last.getSpeed());

biodranik (Migrated from github.com) commented

2024-08-09 07:13:14 +00:00

It can also be used on iOS btw.

It can also be used on iOS btw.

strump reviewed 2024-08-09 07:39:06 +00:00

android/app/src/main/java/app/organicmaps/widget/menu/NavMenu.java

					
				@ -211,9 +214,26 @@ public class NavMenu

				    Pair<String, String> speedAndUnits = StringUtils.nativeFormatSpeedAndUnits(last.getSpeed());

strump commented

2024-08-09 07:39:06 +00:00

Author

Member

You mean replace " / " with "\u202F/\u202F"?

You mean replace `" / "` with `"\u202F/\u202F"`?

biodranik (Migrated from github.com) reviewed 2024-08-09 10:20:16 +00:00

android/app/src/main/java/app/organicmaps/widget/menu/NavMenu.java

					
				@ -211,9 +214,26 @@ public class NavMenu

				    Pair<String, String> speedAndUnits = StringUtils.nativeFormatSpeedAndUnits(last.getSpeed());

biodranik (Migrated from github.com) commented

2024-08-09 10:20:16 +00:00

Yes, or just copy the necessary space symbol and insert it directly into the string.

Yes, or just copy the necessary space symbol and insert it directly into the string.

strump reviewed 2024-08-14 08:40:46 +00:00

android/app/src/main/java/app/organicmaps/widget/menu/NavMenu.java

strump commented

2024-08-14 08:40:46 +00:00

Author

Member

This line 216 makes speedometer backgound red. Removed it. Now only text color is red.

This line 216 makes speedometer backgound red. Removed it. Now only text color is red.

biodranik (Migrated from github.com) approved these changes 2024-08-14 19:47:01 +00:00

biodranik (Migrated from github.com) left a comment

LGTM with nits.

LGTM with nits.

android/app/src/main/java/app/organicmaps/widget/menu/NavMenu.java

biodranik (Migrated from github.com) commented

2024-08-14 19:45:15 +00:00

        // Red text for speeding if there's no camera

Or you can drop these comments, the code is self-explanatory.

```suggestion // Red text for speeding if there's no camera ``` Or you can drop these comments, the code is self-explanatory.

android/app/src/main/java/app/organicmaps/widget/menu/NavMenu.java

biodranik (Migrated from github.com) commented

2024-08-14 19:46:42 +00:00

This comment is not relevant anymore, right?

This comment is not relevant anymore, right?

biodranik (Migrated from github.com) approved these changes 2024-08-15 10:22:37 +00:00

biodranik (Migrated from github.com) left a comment

Thanks and let's proceed with the release!

Thanks and let's proceed with the release!

android/app/src/main/java/app/organicmaps/widget/menu/NavMenu.java

biodranik (Migrated from github.com) commented

2024-08-15 10:21:57 +00:00

```suggestion ```

biodranik (Migrated from github.com) commented

2024-08-15 10:22:08 +00:00

```suggestion ```

This repo is archived. You cannot comment on pull requests.

No reviewers

No labels

Android Automotive (AAOS)

Android Automotive (AAOS)

Battery and Performance

Battery and Performance

Bookmarks and Tracks

Bookmarks and Tracks

External Map Datasets

External Map Datasets

Frequently User Reported

Frequently User Reported

Good first issue

Good first issue

Linux packaging

Linux packaging

NLnet 2024-06-281

NLnet 2024-06-281

No Feature Parity

No Feature Parity

Public Transport

Public Transport

Track Recording

Track Recording

Walk Navigation

Walk Navigation

No milestone

No project

No assignees

2 participants

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#8897

No description provided.