organicmaps/organicmaps-tmp

Archived

Add android dockerfile #9090

Open

cortadocodes wants to merge 1 commit from cortadocodes/create-reproducible-build-dockerfile into master

cortadocodes commented

2024-08-25 11:21:17 +00:00

(Migrated from github.com)

No description provided.

biodranik (Migrated from github.com) reviewed 2024-08-25 11:31:00 +00:00

biodranik (Migrated from github.com) left a comment

Thanks! A few comments.

Thanks! A few comments.

android/docker/Dockerfile

					
				@ -0,0 +6,4 @@

				ENV ANDROID_COMMAND_LINE_TOOLS_FILENAME commandlinetools-linux-10406996_latest.zip

				ENV ANDROID_API_LEVELS                  android-34

				ENV ANDROID_BUILD_TOOLS_VERSION         34.0.0

biodranik (Migrated from github.com) commented

2024-08-25 11:24:16 +00:00

These variables and their values should be taken from the repo, to avoid copy-paste and sync issues.
Can Dockerfile be in the root folder? Why is it in the docker subfolder?

1. These variables and their values should be taken from the repo, to avoid copy-paste and sync issues. 2. Can Dockerfile be in the root folder? Why is it in the docker subfolder?

android/docker/Dockerfile

					
				@ -0,0 +12,4 @@

				ENV PATH         ${PATH}:${ANDROID_HOME}/tools:${ANDROID_HOME}/platform-tools:${ANDROID_HOME}/cmdline-tools/bin

				RUN cd /usr/local/

				RUN wget -q "https://dl.google.com/android/repository/${ANDROID_COMMAND_LINE_TOOLS_FILENAME}"

biodranik (Migrated from github.com) commented

2024-08-25 11:26:55 +00:00

Won't sudo snap install androidsdk work?

Won't `sudo snap install androidsdk` work?

android/docker/Dockerfile

					
				@ -0,0 +17,4 @@

				RUN rm ${ANDROID_COMMAND_LINE_TOOLS_FILENAME}

				RUN yes | sdkmanager --update --sdk_root="${ANDROID_HOME}"

				RUN yes | sdkmanager --sdk_root="${ANDROID_HOME}" "platforms;${ANDROID_API_LEVELS}" "build-tools;${ANDROID_BUILD_TOOLS_VERSION}" "extras;google;m2repository" "extras;android;m2repository" "extras;google;google_play_services" "ndk;26.3.11579264" "cmake;3.22.1"

biodranik (Migrated from github.com) commented

2024-08-25 11:28:44 +00:00

Aren't these dependencies downloaded/installed automatically when the project is built?
Caching already downloaded sdk dependencies will save time on failed/repeated builds.
Please avoid hard-coding anything here, for example, the ndk version has just been updated in #9087

1. Aren't these dependencies downloaded/installed automatically when the project is built? 2. Caching already downloaded sdk dependencies will save time on failed/repeated builds. 3. Please avoid hard-coding anything here, for example, the ndk version has just been updated in #9087

android/docker/Dockerfile

					
				@ -0,0 +23,4 @@

				RUN rm -rf ${ANDROID_HOME}/tools

				RUN git config --global --add safe.directory /project

biodranik (Migrated from github.com) commented

2024-08-25 11:29:00 +00:00

Why is it needed? Clarifying comments would help a lot.

Why is it needed? Clarifying comments would help a lot.

android/docker/Dockerfile

					
				@ -0,0 +31,4 @@

				WORKDIR /build/android

				RUN ./gradlew assembleFdroidBeta -Parm64 && ./gradlew clean

biodranik (Migrated from github.com) commented

2024-08-25 11:30:51 +00:00

assembleWebBeta is preferred, it will work better with network location.
is there any benefit in clean?

1. assembleWebBeta is preferred, it will work better with network location. 2. is there any benefit in clean?

This repo is archived. You cannot comment on pull requests.

No reviewers

No labels

Android Automotive (AAOS)

Android Automotive (AAOS)

Battery and Performance

Battery and Performance

Bookmarks and Tracks

Bookmarks and Tracks

External Map Datasets

External Map Datasets

Frequently User Reported

Frequently User Reported

Good first issue

Good first issue

Linux packaging

Linux packaging

NLnet 2024-06-281

NLnet 2024-06-281

No Feature Parity

No Feature Parity

Public Transport

Public Transport

Track Recording

Track Recording

Walk Navigation

Walk Navigation

No milestone

No project

No assignees

1 participant

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#9090

No description provided.