WIP: [core] Add the timestamps to the tracks #9107

kirylkaveryn · 2024-08-26T08:09:50Z

kirylkaveryn commented

2024-08-26 08:09:50 +00:00

References:

http://www.topografix.com/gpx/1/1/#type_wptType
https://developers.google.com/kml/documentation/kmlreference#gx:track

TODO:

store the timestamps as a vector in the Multiline geometry
save the timestamps to the kml https://developers.google.com/kml/documentation/kmlreference#gxtrack
save the timestamps to the gpx http://www.topografix.com/gpx/1/1/#type_wptType
parse the timestamps from the gpx
parse the timestamps from the kml
support for the MultiTrack
Fix timestamps parsing organicmaps/organicmaps#9127
Support for the <altitudeMode> (see https://developers.google.com/kml/documentation/kmlreference#elements-specific-to-track)
Unit test - Fix the old and and cover the new logic

### References: http://www.topografix.com/gpx/1/1/#type_wptType https://developers.google.com/kml/documentation/kmlreference#gx:track ### TODO: - [x] store the timestamps as a vector in the Multiline geometry - [x] save the timestamps to the kml https://developers.google.com/kml/documentation/kmlreference#gxtrack - [x] save the timestamps to the gpx http://www.topografix.com/gpx/1/1/#type_wptType - [x] parse the timestamps from the gpx - [x] parse the timestamps from the kml - [x] support for the `MultiTrack` - [ ] Fix timestamps parsing https://git.omaps.dev/organicmaps/organicmaps/issues/9127 - [ ] Support for the `<altitudeMode>` (see https://developers.google.com/kml/documentation/kmlreference#elements-specific-to-track) - [ ] Unit test - Fix the old and and cover the new logic

biodranik (Migrated from github.com) reviewed 2024-08-26 08:36:26 +00:00

platform/location.hpp

biodranik (Migrated from github.com) commented

2024-08-26 08:36:26 +00:00

I don't see any reason to duplicate GpsInfo with GpsTrackInfo now when we decided to save detailed track data. GPX and KML can also store accuracy and bearing. Instead of copying the same functionality, it looks like GpsTrackInfo can be deleted completely and replaced by GpsInfo struct everywhere in a separate PR.

biodranik (Migrated from github.com) reviewed 2024-08-26 09:42:29 +00:00

platform/location.hpp

biodranik (Migrated from github.com) commented

2024-08-26 09:42:29 +00:00

See organicmaps/organicmaps#9109

See https://git.omaps.dev/organicmaps/organicmaps/pulls/9109

biodranik (Migrated from github.com) reviewed 2024-08-27 11:11:02 +00:00

kml/serdes.cpp

					
				@ -490,0 +529,4 @@

				        CHECK_EQUAL(line.size(), timestampsForLine.size(), ("Timestamps size mismatch for track:", lineIndex));

				        auto const timeStr = base::SecondsSinceEpochToString(timestampsForLine[pointIndex]);

				        writer << linesIndent << kIndent4 << "<when>" << timeStr << "</when>\n";

				      }

biodranik (Migrated from github.com) commented

2024-08-27 11:11:02 +00:00

Should the old approach be used for tracks without timestamps, and gx:Track/MultiTrack for timestamped data?

kirylkaveryn reviewed 2024-08-27 11:21:19 +00:00

kml/serdes.cpp

					
				@ -490,0 +529,4 @@

				        CHECK_EQUAL(line.size(), timestampsForLine.size(), ("Timestamps size mismatch for track:", lineIndex));

				        auto const timeStr = base::SecondsSinceEpochToString(timestampsForLine[pointIndex]);

				        writer << linesIndent << kIndent4 << "<when>" << timeStr << "</when>\n";

				      }

kirylkaveryn commented

2024-08-27 11:21:19 +00:00

The track can successfully be saved using only the gx:track tags without the timestamps (only the points).
Maybe only to support by the others apps (I dunno which)?

The track can successfully be saved using only the gx:track tags without the timestamps (only the points). Maybe only to support by the others apps (I dunno which)?

kirylkaveryn reviewed 2024-08-27 16:46:31 +00:00

kml/serdes.cpp

					
				@ -490,0 +529,4 @@

				        CHECK_EQUAL(line.size(), timestampsForLine.size(), ("Timestamps size mismatch for track:", lineIndex));

				        auto const timeStr = base::SecondsSinceEpochToString(timestampsForLine[pointIndex]);

				        writer << linesIndent << kIndent4 << "<when>" << timeStr << "</when>\n";

				      }