organicmaps/organicmaps-tmp

Archived

Fork 1

[android] Increases touch area of eye and 3 dot #9697

Open

kavikhalique wants to merge 2 commits from kavikhalique/expand-touch into master

kavikhalique commented

2024-11-20 12:01:05 +00:00

(Migrated from github.com)

Fixes #9649
Increases the touchable area of eye and options button (3 dots) of bookmarks

https://github.com/user-attachments/assets/f73984db-f13c-4f73-8fa5-dad1d62971bb

Fixes #9649 Increases the touchable area of eye and options button (3 dots) of bookmarks https://github.com/user-attachments/assets/f73984db-f13c-4f73-8fa5-dad1d62971bb

biodranik (Migrated from github.com) reviewed 2024-11-20 12:01:05 +00:00

rtsisyk reviewed 2024-11-20 12:01:05 +00:00

vng (Migrated from github.com) reviewed 2024-11-20 15:34:28 +00:00

android/app/src/main/java/app/organicmaps/bookmarks/Holders.java

vng (Migrated from github.com) commented

2024-11-20 15:34:23 +00:00

I'm not familiar with this Android specific, but aren't the listener will be triggered twice then?
When my tap is inside a button and its parent container.

I'm not familiar with this Android specific, but aren't the listener will be triggered twice then? When my tap is inside a button and its parent container.

kavikhalique (Migrated from github.com) reviewed 2024-11-20 15:44:48 +00:00

android/app/src/main/java/app/organicmaps/bookmarks/Holders.java

kavikhalique (Migrated from github.com) commented

2024-11-20 15:44:48 +00:00

I tested it by logging the trigger inside listener and i found that it gets triggered only once in both the cases either click is directly on button inside parent container or on the parent container itself.

kavikhalique (Migrated from github.com) reviewed 2024-11-20 17:58:18 +00:00

android/app/src/main/java/app/organicmaps/bookmarks/Holders.java

kavikhalique (Migrated from github.com) commented

2024-11-20 17:58:18 +00:00

I changed the logic so this problem will not arise.

vng (Migrated from github.com) approved these changes 2024-11-23 03:00:17 +00:00

AndrewShkrob reviewed 2024-11-25 09:57:19 +00:00

android/app/src/main/res/layout/item_bookmark_category.xml

AndrewShkrob commented

2024-11-25 09:57:18 +00:00

Member

What are the magic values?
Why not to have the same padding for all dimensions? android:padding="..."

What are the magic values? Why not to have the same padding for all dimensions? `android:padding="..."`

kavikhalique (Migrated from github.com) reviewed 2024-11-25 10:00:21 +00:00

android/app/src/main/res/layout/item_bookmark_category.xml

kavikhalique (Migrated from github.com) commented

2024-11-25 10:00:21 +00:00

Actually i calculated the top and bottom paddings from the text's padding to fit the icons exactly in center.

AndrewShkrob reviewed 2024-11-25 19:57:02 +00:00

android/app/src/main/res/layout/item_bookmark_category.xml

AndrewShkrob commented

2024-11-25 19:57:02 +00:00

Member

I don't think it should be solved this way. How about other screen resolutions - bigger/smaller screens, tablets? Have you checked it in the landscape mode?
I don't really like this approach but if it looks OK for different screens then OK :)

I don't think it should be solved this way. How about other screen resolutions - bigger/smaller screens, tablets? Have you checked it in the landscape mode? I don't really like this approach but if it looks OK for different screens then OK :)

kavikhalique (Migrated from github.com) reviewed 2024-12-06 19:56:32 +00:00

android/app/src/main/res/layout/item_bookmark_category.xml

kavikhalique (Migrated from github.com) commented

2024-12-06 19:56:32 +00:00

I will test it on different screens.
But technically increasing padding is just increasing the button area so that click can be done easily. For different screens i guess it will adjust itself accordingly, but still i will look for some other better solution with lesser code changes.

I will test it on different screens. But technically increasing padding is just increasing the button area so that click can be done easily. For different screens i guess it will adjust itself accordingly, but still i will look for some other better solution with lesser code changes.

This repo is archived. You cannot comment on pull requests.

No reviewers

biodranik

rtsisyk

vng