[tools] Rewrite Ruby scripts in Python for consistency #9791

rtsisyk · 2024-11-30T20:55:37Z

meenbeese commented

2024-11-30 20:55:37 +00:00

(Migrated from github.com)

Rewrote the scripts in Python with same functionality
Relocated the scripts to be under tools/python
Tested them with the latest Python 3.13 version

- Rewrote the scripts in Python with same functionality - Relocated the scripts to be under `tools/python` - Tested them with the latest Python 3.13 version

👍 1

rtsisyk reviewed 2024-11-30 20:55:37 +00:00

pastk reviewed 2024-12-03 12:18:09 +00:00

docs/TRANSLATIONS.md

					
				@ -58,9 +58,10 @@ By default, it searches `strings.txt`, to check `types_strings.txt` add a `-t` o

				There are many more other options, e.g. print various translation statistics, validate and re-format translation files.

				Check `tools/python/strings_utils.py -h` to see all of them.

pastk commented

2024-12-03 12:17:42 +00:00

But the script operates with string.txt...

Could you please add a comment to the script describing what exactly does it check?
I've tried to make some changes to the UI search categories in categories.txt but couldn't make the script fail.

But the script operates with `string.txt`... Could you please add a comment to the script describing what exactly does it check? I've tried to make some changes to the UI search categories in categories.txt but couldn't make the script fail.

meenbeese (Migrated from github.com) reviewed 2024-12-03 18:39:27 +00:00

pastk reviewed 2024-12-03 18:58:49 +00:00

meenbeese (Migrated from github.com) reviewed 2024-12-03 19:08:44 +00:00

meenbeese (Migrated from github.com) reviewed 2024-12-03 19:22:34 +00:00

docs/TRANSLATIONS.md

					
				@ -58,9 +58,10 @@ By default, it searches `strings.txt`, to check `types_strings.txt` add a `-t` o

				There are many more other options, e.g. print various translation statistics, validate and re-format translation files.

				Check `tools/python/strings_utils.py -h` to see all of them.

meenbeese (Migrated from github.com) commented

2024-12-03 19:22:33 +00:00

Added a comment in the script and updated the documentation.

pastk reviewed 2024-12-03 20:15:13 +00:00

meenbeese (Migrated from github.com) reviewed 2024-12-04 03:34:58 +00:00

strump reviewed 2024-12-04 09:55:02 +00:00

tools/python/category/check_consistency.py

					
				@ -0,0 +46,4 @@

				    return [cat.strip().strip('"') for cat in raw_categories.split(",")]

				def compare_categories(string_cats, search_cats, cpp_cats):

strump commented

2024-12-04 09:49:40 +00:00

Please add type annotations like you did in omim_parsers.py

tools/python/category/check_consistency.py

					
				@ -0,0 +53,4 @@

				    for category_name in search_cats.keys():

				        if category_name not in string_cats:

				            missing_categories.append(category_name)

strump commented

2024-12-04 09:52:25 +00:00

You can simplify this code by using set collection. For example:

missing_categories = search_cats.keys() - set(string_cats)

You can simplify this code by using `set` collection. For example: ```python missing_categories = search_cats.keys() - set(string_cats) ```

tools/python/category/check_consistency.py

					
				@ -0,0 +57,4 @@

				    for cpp_cat in cpp_cats:

				        if cpp_cat not in search_cats:

				            extra_categories.append(cpp_cat)

strump commented

2024-12-04 09:53:37 +00:00

You can simplify this code by using set collection. For example:

extra_categories = set(cpp_cats) - set(search_cats)

You can simplify this code by using `set` collection. For example: ```python extra_categories = set(cpp_cats) - set(search_cats) ```

tools/python/category/omim_parsers.py

					
				@ -0,0 +36,4 @@

				                    continue

				                # Match a new category

				                category_match = self.category().match(line)

strump commented

2024-12-04 09:02:07 +00:00

Small optimization here: no need to call self.category() for every line.

Please create new variable at the start of parse_file(...) method and put there result of self.category()
For example:

category_regex = self.category()
with open(...):
    ...
    category_match = category_regex.match(line)

Small optimization here: no need to call `self.category()` for every line. Please create new variable at the start of `parse_file(...)` method and put there result of `self.category()` For example: ```python category_regex = self.category() with open(...): ... category_match = category_regex.match(line) ```

tools/python/category/omim_parsers.py

					
				@ -0,0 +52,4 @@

				        return result

				    def category(self) -> re.Pattern:

strump commented

2024-12-04 08:59:38 +00:00

Let's rename method from category(self) to category_re(self).

Let's rename method from `category(self)` to `category_re(self)`.

pastk requested changes 2024-12-10 15:17:22 +00:00

pastk left a comment

As commented above need to fix the check logic..

This repo is archived. You cannot comment on pull requests.

No reviewers

rtsisyk

pastk

No labels

Android Automotive (AAOS)

API

AppGallery

AppStore

Battery and Performance

External Map Datasets

F-Droid

Fonts

Frequently User Reported

No milestone

No project

No assignees

4 participants

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#9791

Rows
Columns