organicmaps/organicmaps-tmp

Archived

Modified startForeground() method call to adapt for android 14+ #9835

Open

kavikhalique wants to merge 1 commit from kavikhalique/foreground-crash-fix into master

kavikhalique commented

2024-12-06 11:55:32 +00:00

(Migrated from github.com)

Fixes #9395

Its not sure it fixes the crash or not but this could be the cause of crash since in android api 34 and above we need to specify the foreground service type while calling the startForegound method for track recording and navigation.

Reference android documentation - https://developer.android.com/develop/background-work/services/foreground-services#start

Please test and provide feedback if its solves the crash or not

Fixes #9395 Its not sure it fixes the crash or not but this could be the cause of crash since in android api 34 and above we need to specify the foreground service type while calling the startForegound method for track recording and navigation. Reference android documentation - https://developer.android.com/develop/background-work/services/foreground-services#start Please test and provide feedback if its solves the crash or not

biodranik (Migrated from github.com) reviewed 2024-12-06 11:55:32 +00:00

vng (Migrated from github.com) reviewed 2024-12-06 11:55:32 +00:00

rtsisyk reviewed 2024-12-06 11:55:32 +00:00

AndrewShkrob reviewed 2024-12-06 16:03:29 +00:00

android/app/src/main/java/app/organicmaps/location/TrackRecordingService.java

AndrewShkrob commented

2024-12-06 16:03:29 +00:00

Member

What is the point of specifying the service type that was defined in the manifest and already has a service type specified?

<service android:name=".location.TrackRecordingService"
      android:foregroundServiceType="location"
      android:exported="false"
      android:enabled="true"
      android:stopWithTask="false"
      />

If this is a legitimate change then I'd prefer to set this value: FOREGROUND_SERVICE_TYPE_MANIFEST. It should automatically use all values from manifest and no need to define them in two places.

What is the point of specifying the service type that was defined in the manifest and already has a service type specified? ```xml <service android:name=".location.TrackRecordingService" android:foregroundServiceType="location" android:exported="false" android:enabled="true" android:stopWithTask="false" /> ```` If this is a legitimate change then I'd prefer to set this value: [FOREGROUND_SERVICE_TYPE_MANIFEST](https://developer.android.com/reference/android/content/pm/ServiceInfo.html#FOREGROUND_SERVICE_TYPE_MANIFEST). It should automatically use all values from manifest and no need to define them in two places.

kavikhalique (Migrated from github.com) reviewed 2024-12-06 16:14:49 +00:00

android/app/src/main/java/app/organicmaps/location/TrackRecordingService.java

kavikhalique (Migrated from github.com) commented

2024-12-06 16:14:49 +00:00

I am also not very sure that it gonna solve the issue correctly or not but i read that from android 14 above we need to provide the type of foreground service. Since i was unable to regenerate the issue i cannot say it will resolve it since everything else seems fine.

I am also not very sure that it gonna solve the issue correctly or not but i read that from android 14 above we need to provide the type of foreground service. Since i was unable to regenerate the issue i cannot say it will resolve it since everything else seems fine.

kavikhalique (Migrated from github.com) reviewed 2024-12-06 16:26:46 +00:00

android/app/src/main/java/app/organicmaps/location/TrackRecordingService.java

kavikhalique (Migrated from github.com) commented

2024-12-06 16:26:46 +00:00

https://developer.android.com/about/versions/14/changes/fgs-types-required#location

In this doc it states the steps while starting foreground service which requires location service. We need both manifest declaration as well as runtime declaration too i guess.

Kindly have a look @AndrewShkrob , i think this will probably solve the issue

https://developer.android.com/about/versions/14/changes/fgs-types-required#location In this doc it states the steps while starting foreground service which requires location service. We need both manifest declaration as well as runtime declaration too i guess. Kindly have a look @AndrewShkrob , i think this will probably solve the issue

This repo is archived. You cannot comment on pull requests.

No reviewers

No labels

Android Automotive (AAOS)

Android Automotive (AAOS)

Battery and Performance

Battery and Performance

Bookmarks and Tracks

Bookmarks and Tracks

External Map Datasets

External Map Datasets

Frequently User Reported

Frequently User Reported

Good first issue

Good first issue

Linux packaging

Linux packaging

NLnet 2024-06-281

NLnet 2024-06-281

No Feature Parity

No Feature Parity

Public Transport

Public Transport

Track Recording

Track Recording

Walk Navigation

Walk Navigation

No milestone

No project

No assignees

3 participants

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#9835

No description provided.