Changed styling of mtb trails to better differenciate them from cycleways #9887

Open

IsiGebauer wants to merge 20 commits from IsiGebauer/StylingMtbTrails into master

IsiGebauer commented

2024-12-17 21:25:59 +00:00

(Migrated from github.com)

"_mtb_rating" as "easy" if a cycleway has an "mtb:score" of "S0", an "mtb:scale:imba"-Score of 1 or a "smoothness"-Score of "bad" or "very_bad"
"_mtb_rating" as "intermediate" if a cycleway has an "mtb:score" of "S1" or "S2", an "mtb:scale:imba"-Score of 2 or a "smoothness"-Score of "horrible"
"_mtb_rating" as "difficult" if a cycleway has an "mtb:score" of "S3", an mtb:scale:imba"-Score of 3 or a "smoothness"-Score of "very_horrible"
"_mtb_rating" as "expert" if a cycleway has an "mtb:score" of "S4" or "S5", an mtb:scale:imba"-Score of 4

I take the maximum of the resulting rating from the "mtb:score", "mtb:score:imba" and "smoothness".
I am currently still working on the styling, below you can find a small screenshot of an intermediate and a difficult trail.

This solves the issue #9768

I added a tag "_mtb_rating" (from easy to expert) which is a combination of the OSM-Tag "mtb:scale" (from S0-S5), "mtb:scale:imba" (from 1=green to 4=double back diamond) and the smoothness of the track. At the moment I defined an 1. "_mtb_rating" as "easy" if a cycleway has an "mtb:score" of "S0", an "mtb:scale:imba"-Score of 1 or a "smoothness"-Score of "bad" or "very_bad" 2. "_mtb_rating" as "intermediate" if a cycleway has an "mtb:score" of "S1" or "S2", an "mtb:scale:imba"-Score of 2 or a "smoothness"-Score of "horrible" 3. "_mtb_rating" as "difficult" if a cycleway has an "mtb:score" of "S3", an mtb:scale:imba"-Score of 3 or a "smoothness"-Score of "very_horrible" 4. "_mtb_rating" as "expert" if a cycleway has an "mtb:score" of "S4" or "S5", an mtb:scale:imba"-Score of 4 I take the maximum of the resulting rating from the "mtb:score", "mtb:score:imba" and "smoothness". I am currently still working on the styling, below you can find a small screenshot of an intermediate and a difficult trail. ![Screenshot from 2024-12-17 22-23-45](https://github.com/user-attachments/assets/831db9fb-2ce2-4169-b9fa-57776212229d) This solves the issue [#9768]([https://git.omaps.dev/organicmaps/organicmaps/issues/9768](https://git.omaps.dev/organicmaps/organicmaps/pulls/9887#9768))

🚀 1

pastk reviewed 2024-12-18 19:16:34 +00:00

pastk left a comment

Member

Thanks for starting this!

base/file_name_utils.hpp

pastk commented

2024-12-18 18:59:26 +00:00

Member

it'd be good to put unrelated changes into a separate PR

docs/STYLES.md

pastk commented

2024-12-18 18:58:52 +00:00

Member

classificator.txt is an auto-generated file

generator/osm2type.cpp

pastk commented

2024-12-18 19:15:10 +00:00

Member

"S" values seem to be never used, see https://taginfo.openstreetmap.org/keys/mtb%3Ascale#values

pastk reviewed 2024-12-23 18:15:14 +00:00

routing_common/bicycle_model.cpp

pastk commented

2024-12-23 18:15:14 +00:00

Member

I think there will be a lot of cases with psurface-unpaved_bad and _mtb_rating-* at the same time, so the factors will multiply (which is unwanted)

I think the most simple solution is to ensure there is a psurface-unpaved_bad when mtb rating is present (even if there are no surface & smoothness tags).
This way all mtb trails will be considered as "slow" and normally the router will avoid to route all the cyclists there

I think there will be a lot of cases with `psurface-unpaved_bad` and `_mtb_rating-*` at the same time, so the factors will multiply (which is unwanted) I think the most simple solution is to ensure there is a `psurface-unpaved_bad` when mtb rating is present (even if there are no surface & smoothness tags). This way all mtb trails will be considered as "slow" and normally the router will avoid to route all the cyclists there

This repo is archived. You cannot comment on pull requests.

No reviewers