Cleanup iOS. #99

rtsisyk · 2021-01-25T07:19:33Z

vng commented

2021-01-25 07:19:33 +00:00

(Migrated from github.com)

Fixes #42
Fixes #43
Fixes #44
Fixes #45
Fixes #69
Fixes #70
Fixes #73
Fixes #79

Fixes #42 Fixes #43 Fixes #44 Fixes #45 Fixes #69 Fixes #70 Fixes #73 Fixes #79

👍 1 🎉 1 🚀 1

rtsisyk requested changes 2021-01-25 08:49:59 +00:00

rtsisyk left a comment

Let's keep crashlytics, we need crash reports.
Please also remove Google && Facebook from Settings->OpenStreetMap Login

1. Let's keep crashlytics, we need crash reports. 2. Please also remove Google && Facebook from Settings->OpenStreetMap Login

iphone/Maps/Categories/UIKitCategories.m

					
				@ -3,4 +3,3 @@

				#import "UIImageView+Coloring.h"

				#import <FirebaseCrashlytics/FirebaseCrashlytics.h>

				#import <SafariServices/SafariServices.h>

rtsisyk commented

2021-01-25 07:30:13 +00:00

Let's keep crashlytics for now. We need to get crash reports somehow.

tools/autobuild/detect_qmake.sh

rtsisyk commented

2021-01-25 07:29:10 +00:00

Please keep at least ~/Qt/5.?/clang_64/bin/qmake. I've just tried to install Qt from the website, and it installed to ~/Qt/5.15.2/clang_64/bim/cmake by default.

Please keep at least ` ~/Qt/5.?/clang_64/bin/qmake`. I've just tried to install Qt from the website, and it installed to `~/Qt/5.15.2/clang_64/bim/cmake` by default.

vng (Migrated from github.com) reviewed 2021-01-25 09:01:23 +00:00

tools/autobuild/detect_qmake.sh

vng (Migrated from github.com) commented

2021-01-25 09:01:23 +00:00

Looks like this detect_qmake.sh is not needed any more .. I also don't have Qt/5.8

rtsisyk reviewed 2021-01-25 10:56:53 +00:00

tools/autobuild/detect_qmake.sh

rtsisyk commented

2021-01-25 10:56:53 +00:00

Let's remove this script then.

rtsisyk commented

2021-01-25 21:01:24 +00:00

The last, but not least: please accept DCO and add "Signed-off-by" to each commit:

git rebase -i HEAD~[NUMBER OF COMMITS]
"reword"
append Signed-off-by: Your real name <email>

The last, but not least: please accept [DCO](https://github.com/omapsapp/omapsapp/blob/master/docs/DCO.md) and add ["Signed-off-by" to each commit](https://github.com/omapsapp/omapsapp/blob/master/docs/CONTRIBUTING.md#pull-requests): 1. git rebase -i HEAD~[NUMBER OF COMMITS] 2. "reword" 3. append `Signed-off-by: Your real name <email>`

rtsisyk reviewed 2021-01-26 18:13:13 +00:00

rtsisyk approved these changes 2021-01-26 18:30:42 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

rtsisyk