[platform] Separate the location_service lib #9981

pastk · 2025-01-01T04:26:10Z

Ferenc- commented

2025-01-01 04:26:10 +00:00

(Migrated from github.com)

Fixes organicmaps/organicmaps#9728
An alternative to organicmaps/organicmaps#9731

Fixes https://git.omaps.dev/organicmaps/organicmaps/issues/9728 An alternative to https://git.omaps.dev/organicmaps/organicmaps/pulls/9731

biodranik (Migrated from github.com) reviewed 2025-01-01 04:26:10 +00:00

biodranik (Migrated from github.com) reviewed 2025-01-19 23:41:26 +00:00

platform/CMakeLists.txt

biodranik (Migrated from github.com) commented

2025-01-19 23:34:20 +00:00

What was the original intent in supporting SKIP_QT_GUI (SKIP_DESKTOP) flag? Is it still valid/important? Can this flag be dropped completely in favor of an explicit target list when building binaries? A cleaner find_package(Qt6) approach may be needed (e.g. do it only if the related target is built).
Why is location service considered as "GUI" module here?

1. What was the original intent in supporting SKIP_QT_GUI (SKIP_DESKTOP) flag? Is it still valid/important? Can this flag be dropped completely in favor of an explicit target list when building binaries? A cleaner find_package(Qt6) approach may be needed (e.g. do it only if the related target is built). 2. Why is location service considered as "GUI" module here?

platform/location_service/CMakeLists.txt

biodranik (Migrated from github.com) commented

2025-01-19 23:40:14 +00:00

Are these options repeated somewhere? Would it be better to set globally CMAKE_OBJCXX_FLAGS instead on Mac/iOS?

platform/location_service/CMakeLists.txt

					
				@ -0,0 +1,28 @@

				project(location_service)

biodranik (Migrated from github.com) commented

2025-01-19 23:36:38 +00:00

nit

project(location_service LANGUAGES CXX OBJCXX)

nit ```suggestion project(location_service LANGUAGES CXX OBJCXX) ```

Ferenc- (Migrated from github.com) reviewed 2025-01-28 12:27:11 +00:00

platform/location_service/CMakeLists.txt

					
				@ -0,0 +1,28 @@

				project(location_service)

Ferenc- (Migrated from github.com) commented

2025-01-28 12:27:11 +00:00

CXX is enabled by default and we should not repeat ourselves.
Adding OBJCXX would completely break existing Linux builds, as adding this would force the Linux systems to also install an objective-c++ compiler all of a sudden, for no actual reason, as it is not needed for a Linux build at all. So I don't think that these changes are in our interest.

`CXX` is enabled by default and we should not repeat ourselves. Adding `OBJCXX` would completely break existing Linux builds, as adding this would force the Linux systems to also install an `objective-c++` compiler all of a sudden, for no actual reason, as it is not needed for a Linux build at all. So I don't think that these changes are in our interest.

Ferenc- (Migrated from github.com) reviewed 2025-01-28 12:58:10 +00:00

platform/location_service/CMakeLists.txt

Ferenc- (Migrated from github.com) commented

2025-01-28 12:58:09 +00:00

Removed.

Ferenc- (Migrated from github.com) reviewed 2025-01-28 15:59:57 +00:00

platform/CMakeLists.txt

Ferenc- (Migrated from github.com) commented

2025-01-28 15:59:57 +00:00

What was the original intent in supporting SKIP_QT_GUI (SKIP_DESKTOP) flag?

The original intent was to remove the dependency on the Qt "Positioning" component when not needed for example when building the generator_tool, pointed out by you in organicmaps/organicmaps#5823 (comment)

Is it still valid/important?

The intent of reducing the dependency is still valid and important.

Can this flag be dropped completely in favor of an explicit target list when building binaries?

Most probably the answer is yes. And we would need to answer a whole lot of more questions, like how to properly build the generator_tool target because currently it is a complete mess IMHO. And such a refactor is not the topic of this PR.

Why is location service considered as "GUI" module here?
Very simple, because only GUI can possibly make real use of the location service at the moment. That I don't forsee chaning, but it is true that after some thorough refactoring probably a different variable would be here if any.

> 1. What was the original intent in supporting SKIP_QT_GUI (SKIP_DESKTOP) flag? The original intent was to remove the dependency on the Qt "Positioning" component when not needed for example when building the `generator_tool`, pointed out by you in https://git.omaps.dev/organicmaps/organicmaps/pulls/5823#issuecomment-1722211350 > Is it still valid/important? The intent of reducing the dependency is still valid and important. > Can this flag be dropped completely in favor of an explicit target list when building binaries? Most probably the answer is yes. And we would need to answer a whole lot of more questions, like how to properly build the generator_tool target because currently it is a complete mess IMHO. And such a refactor is not the topic of this PR. > Why is location service considered as "GUI" module here? Very simple, because only GUI can possibly make real use of the location service at the moment. That I don't forsee chaning, but it is true that after some thorough refactoring probably a different variable would be here if any.